Re: clean up kernel_{read,write} & friends v2

2020-06-05 Thread Nicolas Pitre
On Fri, 5 Jun 2020, Philippe Mathieu-Daudé wrote: > Unfortunately refreshable braille displays have that "hardware > limitations". 80 cells displays are very expensive. > Visual impairments is rarely a "choice". > Relaxing the 80-char limit make it harder for blind developers > to contribute. Wel

Re: clean up kernel_{read,write} & friends v2

2020-06-04 Thread Philippe Mathieu-Daudé
Hi Linus, On 5/29/20 9:19 PM, Linus Torvalds wrote: > On Fri, May 29, 2020 at 6:08 AM David Laight wrote: >> >> A wide monitor is for looking at lots of files. > > Not necessarily. > > Excessive line breaks are BAD. They cause real and every-day problems. > > They cause problems for things lik

Re: clean up kernel_{read,write} & friends v2

2020-05-29 Thread Casey Schaufler
On 5/29/2020 12:19 PM, Linus Torvalds wrote: > On Fri, May 29, 2020 at 6:08 AM David Laight wrote: >> A wide monitor is for looking at lots of files. > Not necessarily. > > Excessive line breaks are BAD. They cause real and every-day problems. > > They cause problems for things like "grep" both in

Re: clean up kernel_{read,write} & friends v2

2020-05-29 Thread Linus Torvalds
On Fri, May 29, 2020 at 6:08 AM David Laight wrote: > > A wide monitor is for looking at lots of files. Not necessarily. Excessive line breaks are BAD. They cause real and every-day problems. They cause problems for things like "grep" both in the patterns and in the output, since grep (and a lo

RE: clean up kernel_{read,write} & friends v2

2020-05-29 Thread David Laight
From: Casey Schaufler > Sent: 28 May 2020 22:21 > It's true, nobody uses a TTY33 anymore. Those of us who have done so > understand how "{" is preferable to "BEGIN" and why tabs are better than > multiple spaces. A narrow "terminal" requires less neck and mouse movement. > Any width limit is arbitr

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Casey Schaufler
On 5/28/2020 1:17 PM, David Howells wrote: > Linus Torvalds wrote: > >> Or maybe make it check for something more reasonable, like 100 characters. > Yes please! No, thank you! C is a symbolic language, not a text language. Encouraging newbies to declare int iterator; instead of

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Joe Perches
On Thu, 2020-05-28 at 12:22 -0700, Joe Perches wrote: > On Thu, 2020-05-28 at 11:51 -0700, Linus Torvalds wrote: > > On Wed, May 27, 2020 at 10:40 PM Christoph Hellwig wrote: > > > this series fixes a few issues and cleans up the helpers that read from > > > or write to kernel space buffers, and e

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Dave Airlie
On Fri, 29 May 2020 at 05:35, Al Viro wrote: > > On Thu, May 28, 2020 at 12:22:08PM -0700, Joe Perches wrote: > > > Hard limits at 80 really don't work well, especially with > > some of the 25+ character length identifiers used today. > > IMO any such identifier is a good reason for a warning. > >

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Joe Perches
On Thu, 2020-05-28 at 12:44 -0700, Matthew Wilcox wrote: > On Thu, May 28, 2020 at 08:33:40PM +0100, Al Viro wrote: > > On Thu, May 28, 2020 at 12:22:08PM -0700, Joe Perches wrote: > > > > > Hard limits at 80 really don't work well, especially with > > > some of the 25+ character length identifier

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread David Howells
Linus Torvalds wrote: > Or maybe make it check for something more reasonable, like 100 characters. Yes please! David

RE: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Deucher, Alexander
ells ; Linux > Kernel Mailing List ; linux-fsdevel fsde...@vger.kernel.org>; LSM List mod...@vger.kernel.org>; NetFilter ; > Deucher, Alexander ; David Airlie > > Subject: Re: clean up kernel_{read,write} & friends v2 > > On Thu, May 28, 2020 at 12:44:41PM -0700, Mat

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Al Viro
On Thu, May 28, 2020 at 12:44:41PM -0700, Matthew Wilcox wrote: > On Thu, May 28, 2020 at 08:33:40PM +0100, Al Viro wrote: > > On Thu, May 28, 2020 at 12:22:08PM -0700, Joe Perches wrote: > > > > > Hard limits at 80 really don't work well, especially with > > > some of the 25+ character length ide

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Matthew Wilcox
On Thu, May 28, 2020 at 08:33:40PM +0100, Al Viro wrote: > On Thu, May 28, 2020 at 12:22:08PM -0700, Joe Perches wrote: > > > Hard limits at 80 really don't work well, especially with > > some of the 25+ character length identifiers used today. > > IMO any such identifier is a good reason for a w

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Al Viro
On Thu, May 28, 2020 at 12:22:08PM -0700, Joe Perches wrote: > Hard limits at 80 really don't work well, especially with > some of the 25+ character length identifiers used today. IMO any such identifier is a good reason for a warning. The litmus test is actually very simple: how unpleasant woul

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Joe Perches
On Thu, 2020-05-28 at 11:51 -0700, Linus Torvalds wrote: > On Wed, May 27, 2020 at 10:40 PM Christoph Hellwig wrote: > > this series fixes a few issues and cleans up the helpers that read from > > or write to kernel space buffers, and ensures that we don't change the > > address limit if we are us

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Sedat Dilek
On Thu, May 28, 2020 at 8:53 PM Linus Torvalds wrote: > > On Wed, May 27, 2020 at 10:40 PM Christoph Hellwig wrote: > > > > this series fixes a few issues and cleans up the helpers that read from > > or write to kernel space buffers, and ensures that we don't change the > > address limit if we ar

Re: clean up kernel_{read,write} & friends v2

2020-05-28 Thread Linus Torvalds
On Wed, May 27, 2020 at 10:40 PM Christoph Hellwig wrote: > > this series fixes a few issues and cleans up the helpers that read from > or write to kernel space buffers, and ensures that we don't change the > address limit if we are using the ->read_iter and ->write_iter methods > that don't need

clean up kernel_{read,write} & friends v2

2020-05-27 Thread Christoph Hellwig
Hi Al, this series fixes a few issues and cleans up the helpers that read from or write to kernel space buffers, and ensures that we don't change the address limit if we are using the ->read_iter and ->write_iter methods that don't need the changed address limit. Changes since v2: - picked up a

Re: clean up kernel_{read,write} & friends v2

2020-05-20 Thread Christoph Hellwig
ping? On Wed, May 13, 2020 at 08:56:42AM +0200, Christoph Hellwig wrote: > Hi Al, > > this series fixes a few issues and cleans up the helpers that read from > or write to kernel space buffers, and ensures that we don't change the > address limit if we are using the ->read_iter and ->write_iter m

clean up kernel_{read,write} & friends v2

2020-05-12 Thread Christoph Hellwig
Hi Al, this series fixes a few issues and cleans up the helpers that read from or write to kernel space buffers, and ensures that we don't change the address limit if we are using the ->read_iter and ->write_iter methods that don't need the changed address limit. Changes since v1: - __kernel_wri