Re: cpu/hotplug: broken sibling thread hotplug

2019-01-28 Thread Igor Mammedov
On Mon, 28 Jan 2019 06:52:52 -0600 Josh Poimboeuf wrote: > On Mon, Jan 28, 2019 at 11:13:04AM +0100, Igor Mammedov wrote: > > On Fri, 25 Jan 2019 11:02:03 -0600 > > Josh Poimboeuf wrote: > > > > > On Fri, Jan 25, 2019 at 10:36:57AM -0600, Josh Poimboeuf wrote: > > > > How about this patch?

Re: cpu/hotplug: broken sibling thread hotplug

2019-01-28 Thread Josh Poimboeuf
On Mon, Jan 28, 2019 at 11:13:04AM +0100, Igor Mammedov wrote: > On Fri, 25 Jan 2019 11:02:03 -0600 > Josh Poimboeuf wrote: > > > On Fri, Jan 25, 2019 at 10:36:57AM -0600, Josh Poimboeuf wrote: > > > How about this patch? It's just a revert of 73d5e2b47264 and > > > bc2d8d262cba, plus the 1-line

Re: cpu/hotplug: broken sibling thread hotplug

2019-01-28 Thread Igor Mammedov
On Fri, 25 Jan 2019 11:02:03 -0600 Josh Poimboeuf wrote: > On Fri, Jan 25, 2019 at 10:36:57AM -0600, Josh Poimboeuf wrote: > > How about this patch? It's just a revert of 73d5e2b47264 and > > bc2d8d262cba, plus the 1-line vmx_vm_init() change. If it looks ok to > > you, I can clean it up and su

Re: cpu/hotplug: broken sibling thread hotplug

2019-01-25 Thread Josh Poimboeuf
On Fri, Jan 25, 2019 at 10:36:57AM -0600, Josh Poimboeuf wrote: > How about this patch? It's just a revert of 73d5e2b47264 and > bc2d8d262cba, plus the 1-line vmx_vm_init() change. If it looks ok to > you, I can clean it up and submit an official version. This one actually compiles... diff --g

Re: cpu/hotplug: broken sibling thread hotplug

2019-01-25 Thread Josh Poimboeuf
On Thu, Jan 24, 2019 at 04:57:13PM +0100, Igor Mammedov wrote: > In case guest is booted with one CPU present and then later > a sibling CPU is hotplugged [1], it stays offline since SMT > is disabled. > > Bisects to > 73d5e2b47264 ("cpu/hotplug: detect SMT disabled by BIOS") > which used __max_s

cpu/hotplug: broken sibling thread hotplug

2019-01-24 Thread Igor Mammedov
In case guest is booted with one CPU present and then later a sibling CPU is hotplugged [1], it stays offline since SMT is disabled. Bisects to 73d5e2b47264 ("cpu/hotplug: detect SMT disabled by BIOS") which used __max_smt_threads to decide disabling SMT and in case [1] only primary CPU thread is