Re: device-mapper: fix TB stripe data corruption

2005-01-22 Thread Alasdair G Kergon
On Fri, Jan 21, 2005 at 03:57:38PM -0600, Kevin Corry wrote: > On Friday 21 January 2005 3:20 pm, Roland Dreier wrote: > > If I understand you correctly, do_div() (defined in ) I went for the simplest and safest fix first as this is a data corruption problem and I want assurance that this fixes de

Re: device-mapper: fix TB stripe data corruption

2005-01-21 Thread Kevin Corry
On Friday 21 January 2005 3:20 pm, Roland Dreier wrote: > Kevin> We have to take a mod of the chunk value and the number of > Kevin> stripes (which can be a non-power-of-2, so a shift won't > Kevin> work). It's been my understanding that you couldn't mod a > Kevin> 64-bit value with

Re: device-mapper: fix TB stripe data corruption

2005-01-21 Thread Roland Dreier
Kevin> We have to take a mod of the chunk value and the number of Kevin> stripes (which can be a non-power-of-2, so a shift won't Kevin> work). It's been my understanding that you couldn't mod a Kevin> 64-bit value with a 32-bit value in the kernel. If I understand you correctly, d

Re: device-mapper: fix TB stripe data corruption

2005-01-21 Thread Kevin Corry
On Friday 21 January 2005 2:33 pm, Benjamin LaHaise wrote: > On Fri, Jan 21, 2005 at 06:12:03PM +, Alasdair G Kergon wrote: > > Missing cast thought to cause data corruption on devices with stripes > > > ~1TB. > > Why not make chunk a sector_t? We have to take a mod of the chunk value and the

Re: device-mapper: fix TB stripe data corruption

2005-01-21 Thread Benjamin LaHaise
On Fri, Jan 21, 2005 at 06:12:03PM +, Alasdair G Kergon wrote: > Missing cast thought to cause data corruption on devices with stripes > ~1TB. Why not make chunk a sector_t? -ben - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

device-mapper: fix TB stripe data corruption

2005-01-21 Thread Alasdair G Kergon
Missing cast thought to cause data corruption on devices with stripes > ~1TB. Signed-Off-By: Alasdair G Kergon <[EMAIL PROTECTED]> --- diff/drivers/md/dm-stripe.c 2005-01-20 17:32:37.0 + +++ source/drivers/md/dm-stripe.c 2005-01-20 17:32:26.0 + @@ -179,7 +179,7 @@