Re: dm bufio: Reduce dm_bufio_lock contention

2018-06-22 Thread Michal Hocko
On Thu 21-06-18 21:17:24, Mikulas Patocka wrote: [...] > > But seriously, isn't the best way around the throttling issue to use > > PF_LESS_THROTTLE? > > Yes - it could be done by setting PF_LESS_THROTTLE. But I think it would > be better to change it just in one place than to add

Re: dm bufio: Reduce dm_bufio_lock contention

2018-06-22 Thread Michal Hocko
On Thu 21-06-18 21:17:24, Mikulas Patocka wrote: [...] > > But seriously, isn't the best way around the throttling issue to use > > PF_LESS_THROTTLE? > > Yes - it could be done by setting PF_LESS_THROTTLE. But I think it would > be better to change it just in one place than to add

Re: dm bufio: Reduce dm_bufio_lock contention

2018-06-19 Thread Michal Hocko
On Mon 18-06-18 18:11:26, Mikulas Patocka wrote: [...] > I grepped the kernel for __GFP_NORETRY and triaged them. I found 16 cases > without a fallback - those are bugs that make various functions randomly > return -ENOMEM. Well, maybe those are just optimistic attempts to allocate memory and

Re: dm bufio: Reduce dm_bufio_lock contention

2018-06-19 Thread Michal Hocko
On Mon 18-06-18 18:11:26, Mikulas Patocka wrote: [...] > I grepped the kernel for __GFP_NORETRY and triaged them. I found 16 cases > without a fallback - those are bugs that make various functions randomly > return -ENOMEM. Well, maybe those are just optimistic attempts to allocate memory and

Re: dm bufio: Reduce dm_bufio_lock contention

2018-06-14 Thread jing xia
Thank for your comment,I appreciate it. On Wed, Jun 13, 2018 at 5:20 AM, Mike Snitzer wrote: > On Tue, Jun 12 2018 at 4:03am -0400, > Jing Xia wrote: > >> Performance test in android reports that the phone sometimes gets >> hanged and shows black screen for about several minutes.The sysdump

Re: dm bufio: Reduce dm_bufio_lock contention

2018-06-14 Thread jing xia
Thank for your comment,I appreciate it. On Wed, Jun 13, 2018 at 5:20 AM, Mike Snitzer wrote: > On Tue, Jun 12 2018 at 4:03am -0400, > Jing Xia wrote: > >> Performance test in android reports that the phone sometimes gets >> hanged and shows black screen for about several minutes.The sysdump