Re: [RFC] DMA mapping error check analysis

2012-09-10 Thread Stefan Richter
On Sep 10 Clemens Ladisch wrote: > fw_iso_buffer_map_dma() maps as many pages as it can, and saves in > ->page_count_mapped how many pages need unmapping. > > When fw_iso_buffer_map_dma() fails, ioctl_create_iso_context() does _not_ > call fw_iso_buffer_destroy() but takes care to not change the c

Re: [RFC] DMA mapping error check analysis

2012-09-10 Thread Clemens Ladisch
Stefan Richter wrote: > On Sep 10 Shuah Khan wrote: http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_Error_Analysis >>> File Name # of calls Status drivers/firewire/core-iso.c 1Unmap Broken drivers/firewire/ohci.c 1Unm

Re: [RFC] DMA mapping error check analysis

2012-09-10 Thread Stefan Richter
On Sep 10 Shuah Khan wrote: > > > > > > > http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_Error_Analysis > > > > > File Name # of calls Status > > > drivers/firewire/core-iso.c 1Unmap Broken > > > drivers/firewire/ohci.c 1Unmap Broken >

Re: [RFC] DMA mapping error check analysis

2012-09-10 Thread Shuah Khan
> > > > http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_Error_Analysis > > > File Name # of calls Status > > drivers/firewire/core-iso.c 1Unmap Broken > > drivers/firewire/ohci.c 1Unmap Broken > > In ohci.c, ar_context_release() take

Re: [RFC] DMA mapping error check analysis

2012-09-10 Thread Clemens Ladisch
Shuah Khan wrote: > I analyzed all calls to dma_map_single() and dma_map_page() in the > kernel, to see if callers check for mapping errors, before using the > returned address. > > The goal of this analysis is to find drivers that currently do not > check dma mapping errors, and fix them. > > I do

Re: [RFC] DMA mapping error check analysis

2012-09-07 Thread Shuah Khan
On Fri, 2012-09-07 at 12:20 -0400, Alan Stern wrote: > On Fri, 7 Sep 2012, Shuah Khan wrote: > > > I analyzed all calls to dma_map_single() and dma_map_page() in the > > kernel, to see if callers check for mapping errors, before using the > > returned address. > > > > The goal of this analysis is

Re: [RFC] DMA mapping error check analysis

2012-09-07 Thread Alan Stern
On Fri, 7 Sep 2012, Shuah Khan wrote: > I analyzed all calls to dma_map_single() and dma_map_page() in the > kernel, to see if callers check for mapping errors, before using the > returned address. > > The goal of this analysis is to find drivers that currently do not > check dma mapping errors,

[RFC] DMA mapping error check analysis

2012-09-07 Thread Shuah Khan
I analyzed all calls to dma_map_single() and dma_map_page() in the kernel, to see if callers check for mapping errors, before using the returned address. The goal of this analysis is to find drivers that currently do not check dma mapping errors, and fix them. I documented the results of this an

Re: dma mapping error check analysis

2012-08-17 Thread Shuah Khan
On Fri, 2012-08-17 at 10:11 -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Aug 10, 2012 at 04:46:42PM -0600, Shuah Khan wrote: > > I analyzed current calls to dma_map_single() and dma_map_page() in the > > kernel > > to see if dma mapping errors are checked after mapping routines return. > > > > R

Re: dma mapping error check analysis

2012-08-17 Thread Konrad Rzeszutek Wilk
On Fri, Aug 10, 2012 at 04:46:42PM -0600, Shuah Khan wrote: > I analyzed current calls to dma_map_single() and dma_map_page() in the kernel > to see if dma mapping errors are checked after mapping routines return. > > Reference linux-next August 6 2012. > > This analysis stemmed from the discussi

dma mapping error check analysis

2012-08-10 Thread Shuah Khan
I analyzed current calls to dma_map_single() and dma_map_page() in the kernel to see if dma mapping errors are checked after mapping routines return. Reference linux-next August 6 2012. This analysis stemmed from the discussion on my patch that disables swiotlb overflow as a first step towards re