Re: don't use module_init in non-modular ... (was: Re: [PATCH] m68k: don't use module_init in non-modular mvme16x/rtc.c code)

2014-01-21 Thread Geert Uytterhoeven
On Mon, Jan 20, 2014 at 4:27 AM, Paul Gortmaker wrote: >> > Fix this up now, so that we can relocate module_init from >> > init.h into module.h in the future. If we don't do this, we'd >> > have to add module.h to obviously non-modular code, and that >> > would be a worse thing. >> >> The word "m

Re: don't use module_init in non-modular ... (was: Re: [PATCH] m68k: don't use module_init in non-modular mvme16x/rtc.c code)

2014-01-19 Thread Josh Juran
On Jan 19, 2014, at 7:27 PM, Paul Gortmaker wrote: [Re: don't use module_init in non-modular ... (was: Re: [PATCH] m68k: don't use module_init in non-modular mvme16x/rtc.c code)] On 19/01/2014 (Sun 10:40) Geert Uytterhoeven wrote: The word "module" has different m

Re: don't use module_init in non-modular ... (was: Re: [PATCH] m68k: don't use module_init in non-modular mvme16x/rtc.c code)

2014-01-19 Thread Paul Gortmaker
[Re: don't use module_init in non-modular ... (was: Re: [PATCH] m68k: don't use module_init in non-modular mvme16x/rtc.c code)] On 19/01/2014 (Sun 10:40) Geert Uytterhoeven wrote: > Hi Paul, > > On Thu, Jan 16, 2014 at 11:15 PM, Paul Gortmaker > wrote: > > The r

Re: don't use module_init in non-modular ... (was: Re: [PATCH] m68k: don't use module_init in non-modular mvme16x/rtc.c code)

2014-01-19 Thread Geert Uytterhoeven
Hi Paul, On Thu, Jan 16, 2014 at 11:15 PM, Paul Gortmaker wrote: > The rtc.o is built for obj-y, i.e. always built in. It will > never be modular, so using module_init as an alias for __initcall > can be somewhat misleading. > > Fix this up now, so that we can relocate module_init from > init.h