Re: drivers/ide/pci/cs5535.c: array overrun

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 24 July 2007, Jordan Crouse wrote: > > The Coverity checker spotted the following array overrun in > > drivers/ide/pci/cs5535.c: > > <-- snip --> > > > if (speed >= XFER_UDMA_0 && speed <= XFER_UDMA_7) > > reg |= cs5535_udma_timings[speed - XFER_UDMA_0]; Not a b

Re: drivers/ide/pci/cs5535.c: array overrun

2007-07-24 Thread Jordan Crouse
> The Coverity checker spotted the following array overrun in > drivers/ide/pci/cs5535.c: <-- snip --> > if (speed >= XFER_UDMA_0 && speed <= XFER_UDMA_7) > reg |= cs5535_udma_timings[speed - XFER_UDMA_0]; Fix is attached. Somebody got overzealous - the 5535 only supports u

drivers/ide/pci/cs5535.c: array overrun

2007-07-24 Thread Adrian Bunk
The Coverity checker spotted the following array overrun in drivers/ide/pci/cs5535.c: <-- snip --> ... static unsigned int cs5535_udma_timings[5] = { 0x7F7436A1, 0x7F733481, 0x7F723261, 0x7F713161, 0x7F703061 }; ... static void cs5535_set_speed(ide_drive_t *drive, u8 speed) { ...