drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1388:5: warning: 'strncpy' output may be truncated copying 32 bytes from a string of length 32

2020-07-27 Thread kernel test robot
attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/staging/rtl8192u/iee

[PATCH] drivers/staging/rtl8192u: fix indentation issue, remove extra tab

2019-07-23 Thread Colin King
From: Colin Ian King A statement is indented one level too deeply; clean this up by removing a tab. Signed-off-by: Colin Ian King --- drivers/staging/rtl8192u/r8192U_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers

[PATCH v3 1/2] drivers/staging/rtl8192u: drop first comment line

2019-07-01 Thread Christian Müller
one in this patch series. v3 contains the same patch again, but this time with this changelog appended. drivers/staging/rtl8192u/r8192U_dm.c | 69 ++-- 1 file changed, 23 insertions(+), 46 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging

[PATCH v3 2/2] drivers/staging/rtl8192u: style nonstyled comments

2019-07-01 Thread Christian Müller
-by: Felix Trommer --- v1 contains the initial patch. v2 contains the same patch, but with a different subject to better distinguish this patch from the other one in this patch series. v3 contains the same patch again, but this time with this changelog appended. drivers/staging/rtl8192u/r

Re: [PATCH v2 1/2] drivers/staging/rtl8192u: drop first comment line

2019-06-27 Thread Greg KH
omments in this file initially looked like the first example. > But since this file is part of a networking driver and thus should > be moved to drivers/net/ one day, this patch adjusts the comments > such that they are fitting to the style imposed for drivers/net/. > > Signed-off-by:

[PATCH v2 2/2] drivers/staging/rtl8192u: style nonstyled comments

2019-06-27 Thread Christian Müller
-by: Felix Trommer --- drivers/staging/rtl8192u/r8192U_dm.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index 86215fee8f0b..cb6c653e624d 100644 --- a/drivers/stagin

[PATCH v2 1/2] drivers/staging/rtl8192u: drop first comment line

2019-06-27 Thread Christian Müller
adjusts the comments such that they are fitting to the style imposed for drivers/net/. Signed-off-by: Christian Müller Signed-off-by: Felix Trommer --- drivers/staging/rtl8192u/r8192U_dm.c | 69 ++-- 1 file changed, 23 insertions(+), 46 deletions(-) diff --git a/drivers

Re: [PATCH 1/2] drivers/staging/rtl8192u: adjust block comments

2019-06-25 Thread Greg KH
On Mon, Jun 24, 2019 at 11:46:39AM +0200, Christian Müller wrote: > As stated in coding-styles.rst multiline comments should be structured in a > way, > that the actual comment starts on the second line of the commented portion. > E.g: You sent 2 patches that did different things, yet have the

[PATCH 2/2] drivers/staging/rtl8192u: adjust block comments

2019-06-24 Thread Christian Müller
-by: Felix Trommer --- drivers/staging/rtl8192u/r8192U_dm.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index 86215fee8f0b..cb6c653e624d 100644 --- a/drivers/stagin

[PATCH 1/2] drivers/staging/rtl8192u: adjust block comments

2019-06-24 Thread Christian Müller
adjusts the comments such that they are fitting to the style imposed for drivers/net/. Signed-off-by: Christian Müller Signed-off-by: Felix Trommer --- drivers/staging/rtl8192u/r8192U_dm.c | 69 ++-- 1 file changed, 23 insertions(+), 46 deletions(-) diff --git a/drivers

[PATCH 0/2] drivers/staging/rtl8192u: adjust block comments

2019-06-24 Thread Christian Müller
such that they obey these standards. All multiline-comments in this file now look like the following example: /* Multiline comments * in r8192U_dm.c * now look like this. */ Christian Müller (2): drivers/staging/rtl8192u: adjust block comments drivers/staging/rtl8192u: adjust block comments

[PATCH 0/1] drivers/staging/rtl8192u: adjust block comments

2019-06-20 Thread Christian Müller
drivers/staging/rtl8192u/r819xU_phy.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) -- 2.17.1

Re: [PATCH 3/3] drivers/staging/rtl8192u: Fix of checkpatch-errors

2019-06-03 Thread Joe Perches
block of this patch doesn't look like it could ever compile properly. > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h > b/drivers/staging/rtl8192u/ieee80211/ieee80211.h [] > @@ -446,26 +446,26 @@ typedef enum _InitialGainOpType { [] > #else > -#define IEEE80

Re: [PATCH 2/3] drivers/staging/rtl8192u: Remove comment-out code

2019-06-03 Thread Greg KH
ot;pseudo-code"-like nature of the > code that helped to clarify certain functionalities. > > Signed-off-by: Felix Trommer > Signed-off-by: Christian Müller > --- > drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 +- > .../staging/rtl8192u/ieee80211/ieee802

Re: [PATCH 3/3] drivers/staging/rtl8192u: Fix of checkpatch-errors

2019-06-03 Thread Greg KH
On Mon, Jun 03, 2019 at 02:21:04PM +0200, Christian Müller wrote: > Fix issues that lead to multiple checkpatch warnings and errors, most of > them regarding formatting of code and comments. > Comments that contain only commented out code are removed as well. > > Signed-off-by: Felix Trommer > Si

Re: [PATCH 1/3] drivers/staging/rtl8192u: Reformat comments

2019-06-03 Thread Greg KH
On Mon, Jun 03, 2019 at 02:21:02PM +0200, Christian Müller wrote: > From: Felix Trommer > > Replace C99-Style comments with C89-Style comments. What does that mean? > if (MaxChnlNum >= pTriple->first_channel) { > - /* It is not in a monotonically increasing ord

[PATCH 2/3] drivers/staging/rtl8192u: Remove comment-out code

2019-06-03 Thread Christian Müller
s. Signed-off-by: Felix Trommer Signed-off-by: Christian Müller --- drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 +- .../staging/rtl8192u/ieee80211/ieee80211.h| 35 ++- .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 1 - .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 1 - ..

[PATCH 3/3] drivers/staging/rtl8192u: Fix of checkpatch-errors

2019-06-03 Thread Christian Müller
/ieee80211_wx.c | 59 +- .../rtl8192u/ieee80211/rtl819x_BAProc.c | 18 +- .../staging/rtl8192u/ieee80211/rtl819x_HT.h | 15 +- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 16 +- .../rtl8192u/ieee80211/rtl819x_TSProc.c | 14 +- drivers/staging/rtl8192u/r8192U_dm.c | 53

Re: [PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

2018-09-27 Thread Kees Cook
ed check >> before kfree(). >> >> Reported-by: John Whitmore >> Signed-off-by: Valdis Kletnieks >> --- >> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c >> b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c >> index 90a097f2cd4

Re: [PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

2018-09-27 Thread Dan Carpenter
e > Signed-off-by: Valdis Kletnieks > --- > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > index 90a097f2cd4e..97ff0371b5bb 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c > +

Re: [PATCH 01/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct braces

2018-05-15 Thread Greg KH
On Mon, May 14, 2018 at 10:24:08PM +0100, John Whitmore wrote: > Coding style edit to clear the checkpatch.pl errors of the type: > ERROR: that open brace { should be on the previous line > > Signed-off-by: John Whitmore > --- Any reason why your subject line has the full path and not the shorte

coding style changes to drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

2018-05-14 Thread John Whitmore
Second attempt at this commit, apologies for that. Coding style changes to resolve some of the scripts/checkpatch.pl issues with the file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c. There remain line length and CamelCase issues unresolved in the file.

[PATCH 02/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: space before ','

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl errors of the type: ERROR: space prohibited before that ',' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagin

[PATCH 03/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct space before ')'

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl errors of the type: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) di

[PATCH 06/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct braces of else statement

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl error: ERROR: space required after that close brace '}' And balanced the brace of the same else statement: CHECK: Unbalanced braces around else statement Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT

[PATCH 05/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct missing space before '('

2018-05-14 Thread John Whitmore
ff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index f66f181e24f2..ed3e3acd78a3 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c @@ -67,7 +67

[PATCH 08/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct whitespace style errors

2018-05-14 Thread John Whitmore
Coding style edit to clear the remaining checkpatch.pl errors: ERROR: trailing whitespace ERROR: space prohibited after that open parenthesis '(' ERROR: space required before the open brace '{' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HT

[PATCH 07/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct indentation of switch statements

2018-05-14 Thread John Whitmore
/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index beecdbfe401b..5591cde8a5a0 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c @@ -177,35 +177,35 @@ void HTDebugHTInfo(u8 *InfoIE

[PATCH 09/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed redundant return statement

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl warning: WARNING: void function return statements are not generally useful Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 12/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed space from start of line

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl warning: WARNING: please, no spaces at the start of a line Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 10/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Added missing blank line after declarations.

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl warnings: WARNING: Missing a blank line after declarations Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 13/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed redundant braces

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 16/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed blank lines before closing brace

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl check: CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/s

[PATCH 14/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: corrected block comment style

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging

[PATCH 15/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Use __func__ instead of hardcoded function name

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl warnings: WARNING: Prefer using '"%s...", __func__' to using '', this function's name, in a string Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++--

[PATCH 19/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed extra blank lines

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl check: CHECK: Please don't use multiple blank lines Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 24 -- 1 file changed, 24 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee

[PATCH 17/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Added blank line after function

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl check: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging

[PATCH 22/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: coding style correction of a function declaration

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl check: CHECK: Lines should not end with a '(' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 23/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed unnecessary parentheses

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl check: CHECK: Unnecessary parentheses around ... Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 25/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Added prefered spacing around operators

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl check: CHECK: spaces preferred around that 'x' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/stagin

[PATCH 24/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: coding style correction of NULL tests

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl check: CHECK: Comparison to NULL could be written "!..." Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/stagin

[PATCH 27/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: removed redundant return statement

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl warnings: WARNING: void function return statements are not generally useful Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH 26/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Spelling correction in a comment

2018-05-14 Thread John Whitmore
Spelling correction in comment: singal -> signal Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80

[PATCH 11/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: corrected block comments

2018-05-14 Thread John Whitmore
/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 3342c9ccec3f..425ea1279b87 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c @@ -213,8 +213,8 @@ void HTDebugHTInfo(u8

[PATCH 01/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct braces

2018-05-14 Thread John Whitmore
--git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index bf7b7122d042..c116bd895b50 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c @@ -7,28 +7,28 @@ u8

[PATCH 21/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: corrected indentation

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl check: CHECK: Alignment should match open parenthesis Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 18/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: Removed blank lines after opening brace

2018-05-14 Thread John Whitmore
Coding style edit to clear the checkpatch.pl check: CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 04/27] drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc: correct spaces around operators

2018-05-14 Thread John Whitmore
/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index d4ab8481ee30..f66f181e24f2 100644 --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c @@ -60,8 +60,8 @@ void HTUpdateDefaultSetting(struct

Coding Style of drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

2018-05-14 Thread John Whitmore
There were a lot of coding style issues with this file, but I think I've reduced the number down to mainly line length and CamelCase issues. I've put it in 13 patches to, hopefully, make it easier to review, and see that I've made no changes to functionality of the code, (I hope). John

drivers/staging/rtl8192u

2017-02-12 Thread Colin Ian King
Hi, Static analysis via CoverityScan picked up an issue in cmpk_handle_query_config_rx where the following operation on an u8 is clearly not correct: rx_query_cfg.cfg_action = (pmsg[4] & 0x8000) >> 31; The result of this operation is always zero. I suspect this should be:

Re: [PATCH 1/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c

2015-07-22 Thread Greg KH
On Fri, Jul 17, 2015 at 03:59:16PM +0200, Joseph-Eugene Winzer wrote: > Fixing several coding style issues, like > C99 Comment Style > Trailing whitespaces > Inconsistent spacing of operators > Started to reformat comments/expressions for 80 character limit These are multiple thing

Re: [PATCH 2/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c

2015-07-19 Thread Dan Carpenter
On Sat, Jul 18, 2015 at 02:29:19PM +0200, m...@openmailbox.org wrote: > Rather than polluting the main mailing list I should look at the kernelnewbies > mailing list for further criticism on my patch attemps. Use the de...@driverdev.osuosl.org it's fine. No one reads linux-kernel@vger.kernel.org

Re: [PATCH 2/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c

2015-07-18 Thread m999
t; Very few of these seem to be improvements and many > of them should likely be in separate patches. > > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c > > b/drivers/staging/rtl8192u/r8192U_core.c > [] > > @@ -143,17 +143,35 @@ struct CHANNEL_LIST { > > }; > &

Re: [PATCH 5/5] drivers: staging: rtl8192u: fixed coding style issues in r8192U_core.c

2015-07-17 Thread Joe Perches
On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote: > Fixed a few lines that were longer than 80 chars. [] > diff --git a/drivers/staging/rtl8192u/r8192U_core.c > b/drivers/staging/rtl8192u/r8192U_core.c [] > @@ -212,7 +212,9 @@ static void rtl819x_set_channel_map(u8

Re: [PATCH 2/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c

2015-07-17 Thread Joe Perches
patches. > diff --git a/drivers/staging/rtl8192u/r8192U_core.c > b/drivers/staging/rtl8192u/r8192U_core.c [] > @@ -143,17 +143,35 @@ struct CHANNEL_LIST { > }; > > static struct CHANNEL_LIST ChannelPlan[] = { > - {{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 36, 40, 44, 48, 52, 5

[PATCH 4/5] drivers: staging: rtl8192u: included linux/uaccess.h instead of asm/uaccess.h

2015-07-17 Thread Joseph-Eugene Winzer
Checkpatch didn't stop complaining about it and as linux/uaccess.h also includes asm/uaccess.h, there shouldn't be a problem. Signed-off-by: Joseph-Eugene Winzer --- drivers/staging/rtl8192u/r8192U_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH 5/5] drivers: staging: rtl8192u: fixed coding style issues in r8192U_core.c

2015-07-17 Thread Joseph-Eugene Winzer
Fixed a few lines that were longer than 80 chars. Signed-off-by: Joseph-Eugene Winzer --- drivers/staging/rtl8192u/r8192U_core.c | 61 +++--- 1 file changed, 41 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging

[PATCH 2/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c

2015-07-17 Thread Joseph-Eugene Winzer
Reformatting the code without introducing other warnings like 'Avoid unnecessary line continuations' or breaking strings. Signed-off-by: Joseph-Eugene Winzer --- drivers/staging/rtl8192u/r8192U_core.c | 809 ++--- 1 file changed, 536 insertions(+), 273

[PATCH 1/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c

2015-07-17 Thread Joseph-Eugene Winzer
Fixing several coding style issues, like C99 Comment Style Trailing whitespaces Inconsistent spacing of operators Started to reformat comments/expressions for 80 character limit Signed-off-by: Joseph-Eugene Winzer --- drivers/staging/rtl8192u/r8192U_core.c | 1323

[PATCH 3/5] drivers: staging: rtl8192u: removed pointer check for kfree in r8192U_core.c

2015-07-17 Thread Joseph-Eugene Winzer
kfree() can handle NULL pointers itself, so the check is unnecessary. Signed-off-by: Joseph-Eugene Winzer --- drivers/staging/rtl8192u/r8192U_core.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-07-14 Thread Greg Kroah-Hartman
- > 1 file changed, 44 insertions(+), 53 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c > b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c > index c2588f8..df20979 100644 > --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c >

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-06-23 Thread Greg Donald
On Tue, Jun 23, 2015 at 3:01 AM, Dan Carpenter wrote: > Actually, Greg complains about these all the time. All I know is he's yet to turn away a single one of my patches. > And here is a useless URL that you can look at: http://slashdot.org > I'm sure it supports my argument. > > But seriously,

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-06-23 Thread Dan Carpenter
On Mon, Jun 22, 2015 at 06:25:11AM -0500, Greg Donald wrote: > Umm.. you have to fix more than one error if there's more than one > error on or very near the same line you are already fixing, else > checkpatch.pl complains that your patch has errors. Not to mention > Greg KH has never complained:

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-06-22 Thread Greg Donald
Donald >> --- >> .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 >> ++ >> 1 file changed, 44 insertions(+), 53 deletions(-) >> >> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c >> b/drivers/staging/rtl8192u/i

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-06-22 Thread Sudip Mukherjee
- > 1 file changed, 44 insertions(+), 53 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c > b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c > index c2588f8..df20979 100644 > --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c >

[PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

2015-06-20 Thread Greg Donald
Fix checkpatch.pl "space required before the open parenthesis '('" errors Signed-off-by: Greg Donald --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97 ++ 1 file changed, 44 insertions(+), 53 deletions(-) diff --git a/drivers/stagin

Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix

2015-05-30 Thread Tolga Ceylan
I appreciate the suggestions. I simply grepped this piece of code by chance while looking at an actual sparse warning somewhere else. There's no symptoms and I'm not sure under what conditions this debug statement is printed nor why/when. But this is an obviously buggy code only impacting debug/tr

Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix

2015-05-25 Thread Dan Carpenter
Good advice. This was actually found by Sparse and the changelog should say: Sparse complains about this: ieee80211_softmac.c:1561:16: warning: cast from restricted __le16 ieee80211_softmac.c:1561:16: warning: incorrect type in return expression (different base types) ieee80211_softmac.c:1561:1

Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix

2015-05-25 Thread Paul Gortmaker
On 15-05-23 10:53 PM, tolga ceylan wrote: > On 05/12/2015 08:55 PM, Tolga Ceylan wrote: >> Error code returned from auth_parse() should in cpu byte order. >> >> Signed-off-by: Tolga Ceylan >> --- >> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-

Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix

2015-05-24 Thread Sudip Mukherjee
On Sat, May 23, 2015 at 07:53:28PM -0700, tolga ceylan wrote: > On 05/12/2015 08:55 PM, Tolga Ceylan wrote: > > > > > > I haven't gotten a response for this patch. Just checking back. no response means no one is having anything to say about it. Final say will be Greg's when he reviews that when h

Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix

2015-05-23 Thread tolga ceylan
On 05/12/2015 08:55 PM, Tolga Ceylan wrote: Error code returned from auth_parse() should in cpu byte order. Signed-off-by: Tolga Ceylan --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u

[PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix

2015-05-12 Thread Tolga Ceylan
Error code returned from auth_parse() should in cpu byte order. Signed-off-by: Tolga Ceylan --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging

[PATCH] drivers: staging: rtl8192u driver cleanup

2015-01-11 Thread Rene Kolarik
Correct redundant initialization reported by sparse Signed-off-by: Rene Kolarik --- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c b/drivers/staging/rtl8192u/ieee80211

RE: [PATCH] drivers: staging: rtl8192u: Fix "space prohibited after that open parenthesis '('" errors

2014-10-27 Thread Sharma, Sanjeev
...@driverdev.osuosl.org; linux-kernel@vger.kernel.org Cc: Greg Donald Subject: [PATCH] drivers: staging: rtl8192u: Fix "space prohibited after that open parenthesis '('" errors Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors Signed-off-by: Gr

[PATCH] drivers: staging: rtl8192u: Fix "space prohibited after that open parenthesis '('" errors

2014-10-26 Thread Greg Donald
Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 22 +- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 11 --- ..

[PATCH] drivers: staging: rtl8192u: Fix "space required before that '*'" errors

2014-09-04 Thread Greg Donald
Fix checkpatch.pl "space required before that '*'" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 6 +++--- drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 8 ---- driv

[PATCH] drivers: staging: rtl8192u: Fix "space prohibited after that open parenthesis '('" errors

2014-09-02 Thread Greg Donald
Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors Signed-off-by: Greg Donald --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 18 +++- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 4 +-- drivers/staging/rtl8192u/ieee80211/

[PATCH] drivers: staging: rtl8192u: Fix switch and case should be at the same indent errors

2014-08-24 Thread Greg Donald
Fix checkpatch.pl switch and case should be at the same indent errors Signed-off-by: Greg Donald --- drivers/staging/rtl8192u/r8192U_core.c | 510 - 1 file changed, 252 insertions(+), 258 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b

[PATCH] drivers: staging: rtl8192u: Fix space required after that ',' errors

2014-08-24 Thread Greg Donald
Fix checkpatch.pl space required after that ',' errors Signed-off-by: Greg Donald --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 +- .../staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 20 ++--- .../stagin

[PATCH 6/9] drivers/staging/rtl8192u/r8192U_core.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
ends on !ok && unchanged@ position r.p2; expression x; @@ *kfree@p2(x); // Signed-off-by: Peter Senna Tschudin --- drivers/staging/rtl8192u/r8192U_core.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_co