Re: [Intel-gfx] [PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 08:55:59AM +0800, weiyj...@163.com wrote: > From: Wei Yongjun > > Add the missing unlock before return from function i915_gem_init_hw() > in the error handling case. > > Signed-off-by: Wei Yongjun Applied, thanks for the patch. Two minor comments: - Please mention the

Re: drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Jeremiah Mahler wrote: > There are other places in i915_gem_init_hw() where it returns without > unlocking the mutex. Why is it only necessary here and not any of the > other places? There's probably some rebase/merge confusion going on. The following patch is against

Re: drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Jeremiah Mahler wrote: > There are other places in i915_gem_init_hw() where it returns without > unlocking the mutex. Why is it only necessary here and not any of the > other places? There's probably some rebase/merge confusion going on. The following patch is against

Re: drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Jeremiah Mahler jmmah...@gmail.com wrote: There are other places in i915_gem_init_hw() where it returns without unlocking the mutex. Why is it only necessary here and not any of the other places? There's probably some rebase/merge confusion going on. The following patch

Re: drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Jani Nikula
On Fri, 05 Dec 2014, Jeremiah Mahler jmmah...@gmail.com wrote: There are other places in i915_gem_init_hw() where it returns without unlocking the mutex. Why is it only necessary here and not any of the other places? There's probably some rebase/merge confusion going on. The following patch

Re: [Intel-gfx] [PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-05 Thread Daniel Vetter
On Fri, Dec 05, 2014 at 08:55:59AM +0800, weiyj...@163.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function i915_gem_init_hw() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Applied, thanks for

Re: [PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-04 Thread Jeremiah Mahler
Wei Yongjun, On Fri, Dec 05, 2014 at 08:55:59AM +0800, weiyj...@163.com wrote: > From: Wei Yongjun > > Add the missing unlock before return from function i915_gem_init_hw() > in the error handling case. > > Signed-off-by: Wei Yongjun > --- > drivers/gpu/drm/i915/i915_gem.c | 4 +++- > 1 file

[PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-04 Thread weiyj_lk
From: Wei Yongjun Add the missing unlock before return from function i915_gem_init_hw() in the error handling case. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/i915_gem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c

[PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-04 Thread weiyj_lk
From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function i915_gem_init_hw() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/gpu/drm/i915/i915_gem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH -next] drm/i915: Fix missing unlock on error in i915_gem_init_hw()

2014-12-04 Thread Jeremiah Mahler
Wei Yongjun, On Fri, Dec 05, 2014 at 08:55:59AM +0800, weiyj...@163.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function i915_gem_init_hw() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---