Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Rob Clark
On Thu, Apr 9, 2015 at 3:44 PM, Valentin Rothberg wrote: > On Thu, Apr 09, 2015 at 02:54:29PM -0400, Rob Clark wrote: >> On Thu, Apr 9, 2015 at 2:12 PM, Paul Bolle wrote: >> > On Thu, 2015-04-09 at 19:07 +0200, Greg KH wrote: >> >> I really don't understand. Why is this code in the kernel tree i

Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Valentin Rothberg
On Thu, Apr 09, 2015 at 02:54:29PM -0400, Rob Clark wrote: > On Thu, Apr 9, 2015 at 2:12 PM, Paul Bolle wrote: > > On Thu, 2015-04-09 at 19:07 +0200, Greg KH wrote: > >> I really don't understand. Why is this code in the kernel tree if it > >> can't be built? How does anyone use this? By taking

Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Paul Bolle
On Thu, 2015-04-09 at 14:54 -0400, Rob Clark wrote: > We are talking about a driver which does build and run on > upstream kernel, and which has a few small #ifdef blocks to simplify > backporting to downstream kernels (which we still do need to use for > some generations and some devices) This ha

Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Rob Clark
On Thu, Apr 9, 2015 at 2:12 PM, Paul Bolle wrote: > On Thu, 2015-04-09 at 19:07 +0200, Greg KH wrote: >> I really don't understand. Why is this code in the kernel tree if it >> can't be built? How does anyone use this? By taking it and copying it >> where? If it can't be built, and no one can

Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Paul Bolle
On Thu, 2015-04-09 at 19:07 +0200, Greg KH wrote: > I really don't understand. Why is this code in the kernel tree if it > can't be built? How does anyone use this? By taking it and copying it > where? If it can't be built, and no one can update it, and of course > not run it, why is it here?

Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Rob Clark
On Thu, Apr 9, 2015 at 1:07 PM, Greg KH wrote: > On Thu, Apr 09, 2015 at 10:50:58AM -0400, Rob Clark wrote: >> On Thu, Apr 9, 2015 at 10:20 AM, Greg KH wrote: >> > On Thu, Apr 09, 2015 at 09:49:58AM -0400, Rob Clark wrote: >> >> On Thu, Apr 9, 2015 at 7:22 AM, Valentin Rothberg >> >> wrote: >> >

Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Greg KH
On Thu, Apr 09, 2015 at 10:50:58AM -0400, Rob Clark wrote: > On Thu, Apr 9, 2015 at 10:20 AM, Greg KH wrote: > > On Thu, Apr 09, 2015 at 09:49:58AM -0400, Rob Clark wrote: > >> On Thu, Apr 9, 2015 at 7:22 AM, Valentin Rothberg > >> wrote: > >> > Hi Hai, > >> > > >> > your commit d5af49c92a8a ("dr

Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Rob Clark
On Thu, Apr 9, 2015 at 10:20 AM, Greg KH wrote: > On Thu, Apr 09, 2015 at 09:49:58AM -0400, Rob Clark wrote: >> On Thu, Apr 9, 2015 at 7:22 AM, Valentin Rothberg >> wrote: >> > Hi Hai, >> > >> > your commit d5af49c92a8a ("drm/msm/mdp5: Enable DSI connector in msm drm >> > driver") in today's Linu

Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Greg KH
On Thu, Apr 09, 2015 at 09:49:58AM -0400, Rob Clark wrote: > On Thu, Apr 9, 2015 at 7:22 AM, Valentin Rothberg > wrote: > > Hi Hai, > > > > your commit d5af49c92a8a ("drm/msm/mdp5: Enable DSI connector in msm drm > > driver") in today's Linux next tree adds an #ifdef with > > CONFIG_MSM_BUS_SCALI

Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Rob Clark
On Thu, Apr 9, 2015 at 7:22 AM, Valentin Rothberg wrote: > Hi Hai, > > your commit d5af49c92a8a ("drm/msm/mdp5: Enable DSI connector in msm drm > driver") in today's Linux next tree adds an #ifdef with CONFIG_MSM_BUS_SCALING > as condition. MSM_BUS_SCALING is not defined in Kconfig, so the code i

drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Valentin Rothberg
Hi Hai, your commit d5af49c92a8a ("drm/msm/mdp5: Enable DSI connector in msm drm driver") in today's Linux next tree adds an #ifdef with CONFIG_MSM_BUS_SCALING as condition. MSM_BUS_SCALING is not defined in Kconfig, so the code in this #ifdef block won't be compiled at its current state. I saw