Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Andrew Morton
Jesse Barnes <[EMAIL PROTECTED]> wrote: > > > We're hoping that davem's fix (committed yesterday) fixed that. > > > > > > ChangeSet 1.2181.1.2, 2005/03/14 21:16:17-08:00, [EMAIL PROTECTED] > > > > [MM]: Restore pgd_index() iteration to clear_page_range(). > > Yep, seems to have worked (at least

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Jesse Barnes
On Tuesday, March 15, 2005 11:25 am, Andrew Morton wrote: > Jesse Barnes <[EMAIL PROTECTED]> wrote: > > I'd be happy to test and fix things, but the page table walker patches > > broke ia64... Once that's cleared up I can go digging. > > We're hoping that davem's fix (committed yesterday) fixed

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Andrew Morton
Jesse Barnes <[EMAIL PROTECTED]> wrote: > > I'd be happy to test and fix things, but the page table walker patches broke > ia64... Once that's cleared up I can go digging. We're hoping that davem's fix (committed yesterday) fixed that. ChangeSet 1.2181.1.2, 2005/03/14 21:16:17-08:00, [EMAIL

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Jesse Barnes
On Tuesday, March 15, 2005 6:36 am, Dave Jones wrote: > I saw one report where the recent drm security hole fix broke dri > for one user. Whilst it seems an isolated incident, could this have > more impact than we first realised ? > > Worse case scenario we can drop out the multi-bridge support

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Andrew Clayton
On Tue, 2005-03-15 at 11:53 -0500, Dave Jones wrote: > On Tue, Mar 15, 2005 at 04:15:42PM +, Dave Airlie wrote: > > > > > > > > > > I might get time to do a code review, my main worry is that all the > > > > problems reported with those patches in -mm made it into the patchset > that

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Airlie
> > the multi-bridge stuff is definitely broken as I've seen radeon and r128 > > reports on it .. and it looks most like 2.6.11-bk2 broke things and I > > haven't merged anything until -bk7 ... > > Wait, -bk2 broke things ? The big agp changes went into -bk3, > so this seems odd. sorry

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Jones
On Tue, Mar 15, 2005 at 04:15:42PM +, Dave Airlie wrote: > > > > > > > I might get time to do a code review, my main worry is that all the > > > problems reported with those patches in -mm made it into the patchset > > that > > > went into Linus.. mainly things like forgetting to

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Jones
On Tue, Mar 15, 2005 at 04:15:42PM +, Dave Airlie wrote: > > I saw one report where the recent drm security hole fix broke dri > > for one user. Whilst it seems an isolated incident, could this have > > more impact than we first realised ? > > the radeon security changes? I've gotten

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Airlie
> > > > I might get time to do a code review, my main worry is that all the > > problems reported with those patches in -mm made it into the patchset that > > went into Linus.. mainly things like forgetting to memset certain > > structures to 0 and sillies like that... > > I saw one report

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Jones
On Tue, Mar 15, 2005 at 10:38:30AM +, Dave Airlie wrote: > > Hi all, > Andrew Clayton reported lockups on the dri list issues since -bk2 > and bug 4337 on bugzilla.kernel.org looks like it might be the same > thing.. > > This leads me to think the AGP multi-bridge patches are at

drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Airlie
Hi all, Andrew Clayton reported lockups on the dri list issues since -bk2 and bug 4337 on bugzilla.kernel.org looks like it might be the same thing.. This leads me to think the AGP multi-bridge patches are at fault... (for once my laziness in merging late instead of early gave a good gap

drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Airlie
Hi all, Andrew Clayton reported lockups on the dri list issues since -bk2 and bug 4337 on bugzilla.kernel.org looks like it might be the same thing.. This leads me to think the AGP multi-bridge patches are at fault... (for once my laziness in merging late instead of early gave a good gap

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Jones
On Tue, Mar 15, 2005 at 10:38:30AM +, Dave Airlie wrote: Hi all, Andrew Clayton reported lockups on the dri list issues since -bk2 and bug 4337 on bugzilla.kernel.org looks like it might be the same thing.. This leads me to think the AGP multi-bridge patches are at

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Airlie
I might get time to do a code review, my main worry is that all the problems reported with those patches in -mm made it into the patchset that went into Linus.. mainly things like forgetting to memset certain structures to 0 and sillies like that... I saw one report where the

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Jones
On Tue, Mar 15, 2005 at 04:15:42PM +, Dave Airlie wrote: I saw one report where the recent drm security hole fix broke dri for one user. Whilst it seems an isolated incident, could this have more impact than we first realised ? the radeon security changes? I've gotten no bad

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Jones
On Tue, Mar 15, 2005 at 04:15:42PM +, Dave Airlie wrote: I might get time to do a code review, my main worry is that all the problems reported with those patches in -mm made it into the patchset that went into Linus.. mainly things like forgetting to memset certain

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Dave Airlie
the multi-bridge stuff is definitely broken as I've seen radeon and r128 reports on it .. and it looks most like 2.6.11-bk2 broke things and I haven't merged anything until -bk7 ... Wait, -bk2 broke things ? The big agp changes went into -bk3, so this seems odd. sorry bk2-bk3 broke

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Andrew Clayton
On Tue, 2005-03-15 at 11:53 -0500, Dave Jones wrote: On Tue, Mar 15, 2005 at 04:15:42PM +, Dave Airlie wrote: I might get time to do a code review, my main worry is that all the problems reported with those patches in -mm made it into the patchset that went into

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Jesse Barnes
On Tuesday, March 15, 2005 6:36 am, Dave Jones wrote: I saw one report where the recent drm security hole fix broke dri for one user. Whilst it seems an isolated incident, could this have more impact than we first realised ? Worse case scenario we can drop out the multi-bridge support for

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Andrew Morton
Jesse Barnes [EMAIL PROTECTED] wrote: I'd be happy to test and fix things, but the page table walker patches broke ia64... Once that's cleared up I can go digging. We're hoping that davem's fix (committed yesterday) fixed that. ChangeSet 1.2181.1.2, 2005/03/14 21:16:17-08:00, [EMAIL

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Jesse Barnes
On Tuesday, March 15, 2005 11:25 am, Andrew Morton wrote: Jesse Barnes [EMAIL PROTECTED] wrote: I'd be happy to test and fix things, but the page table walker patches broke ia64... Once that's cleared up I can go digging. We're hoping that davem's fix (committed yesterday) fixed that.

Re: drm lockups since 2.6.11-bk2

2005-03-15 Thread Andrew Morton
Jesse Barnes [EMAIL PROTECTED] wrote: We're hoping that davem's fix (committed yesterday) fixed that. ChangeSet 1.2181.1.2, 2005/03/14 21:16:17-08:00, [EMAIL PROTECTED] [MM]: Restore pgd_index() iteration to clear_page_range(). Yep, seems to have worked (at least my system boots).