Re: easy-to-fix bug in /dev/null driver

2000-11-20 Thread Abramo Bagnara
Michal Jaegermann wrote: > > On Tue, Nov 21, 2000 at 12:53:04AM +1030, Alan Kennington wrote: > > > > I still think that write_null() should be rewritten as: > > > > === > > static ssize_t write_null(struct file * file, const char * buf, > >

Re: easy-to-fix bug in /dev/null driver

2000-11-20 Thread Michal Jaegermann
On Tue, Nov 21, 2000 at 12:53:04AM +1030, Alan Kennington wrote: > > I still think that write_null() should be rewritten as: > > === > static ssize_t write_null(struct file * file, const char * buf, > size_t count, loff_t

Re: easy-to-fix bug in /dev/null driver

2000-11-20 Thread Alan Kennington
Okay, okay, I didn't really make my point persuasively enough. The file linux/drivers/char/mem.c contains this: === static ssize_t write_null(struct file * file, const char * buf, size_t count, loff_t *ppos) {

Re: easy-to-fix bug in /dev/null driver

2000-11-20 Thread Michal Jaegermann
On Tue, Nov 21, 2000 at 12:53:04AM +1030, Alan Kennington wrote: I still think that write_null() should be rewritten as: === static ssize_t write_null(struct file * file, const char * buf, size_t count, loff_t

Re: easy-to-fix bug in /dev/null driver

2000-11-20 Thread Abramo Bagnara
Michal Jaegermann wrote: On Tue, Nov 21, 2000 at 12:53:04AM +1030, Alan Kennington wrote: I still think that write_null() should be rewritten as: === static ssize_t write_null(struct file * file, const char * buf,

Re: easy-to-fix bug in /dev/null driver

2000-11-20 Thread Alan Kennington
Okay, okay, I didn't really make my point persuasively enough. The file linux/drivers/char/mem.c contains this: === static ssize_t write_null(struct file * file, const char * buf, size_t count, loff_t *ppos) {

easy-to-fix bug in /dev/null driver

2000-11-19 Thread Alan Kennington
It seems to me that this code in linux/drivers/char/mem.c is a bug: === static ssize_t write_null(struct file * file, const char * buf, size_t count, loff_t *ppos) { return count; }

easy-to-fix bug in /dev/null driver

2000-11-19 Thread Alan Kennington
It seems to me that this code in linux/drivers/char/mem.c is a bug: === static ssize_t write_null(struct file * file, const char * buf, size_t count, loff_t *ppos) { return count; }