Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Julia Lawall
On Mon, 26 Jun 2017, Frans Klaver wrote: > On Fri, Jun 23, 2017 at 07:37:28PM -0400, Julia Lawall wrote: > > > > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > > > > > Hm. For some reason the great mail filtering scheme decided to push > > > this past my inbox :-/ > > > > > > On Sat, Jun 17,

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Julia Lawall
On Mon, 26 Jun 2017, Frans Klaver wrote: > On Fri, Jun 23, 2017 at 07:37:28PM -0400, Julia Lawall wrote: > > > > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > > > > > Hm. For some reason the great mail filtering scheme decided to push > > > this past my inbox :-/ > > > > > > On Sat, Jun 17,

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Frans Klaver
On Fri, Jun 23, 2017 at 07:37:28PM -0400, Julia Lawall wrote: > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > > > Hm. For some reason the great mail filtering scheme decided to push > > this past my inbox :-/ > > > > On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches wrote: > > >

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Frans Klaver
On Fri, Jun 23, 2017 at 07:37:28PM -0400, Julia Lawall wrote: > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > > > Hm. For some reason the great mail filtering scheme decided to push > > this past my inbox :-/ > > > > On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches wrote: > > > On Fri,

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Julia Lawall
On Mon, 26 Jun 2017, Frans Klaver wrote: > On Sat, Jun 24, 2017 at 1:37 AM, Julia Lawall wrote: > > > > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > > > >> Hm. For some reason the great mail filtering scheme decided to push > >> this past my inbox :-/ > >> > >> On Sat,

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Julia Lawall
On Mon, 26 Jun 2017, Frans Klaver wrote: > On Sat, Jun 24, 2017 at 1:37 AM, Julia Lawall wrote: > > > > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > > > >> Hm. For some reason the great mail filtering scheme decided to push > >> this past my inbox :-/ > >> > >> On Sat, Jun 17, 2017 at 12:44

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Frans Klaver
On Sat, Jun 24, 2017 at 1:37 AM, Julia Lawall wrote: > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > >> Hm. For some reason the great mail filtering scheme decided to push >> this past my inbox :-/ >> >> On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-26 Thread Frans Klaver
On Sat, Jun 24, 2017 at 1:37 AM, Julia Lawall wrote: > > > On Sat, 24 Jun 2017, Frans Klaver wrote: > >> Hm. For some reason the great mail filtering scheme decided to push >> this past my inbox :-/ >> >> On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches wrote: >> > On Fri, 2017-06-16 at 19:45

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-23 Thread Julia Lawall
On Sat, 24 Jun 2017, Frans Klaver wrote: > Hm. For some reason the great mail filtering scheme decided to push > this past my inbox :-/ > > On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches wrote: > > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > >> The header field in

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-23 Thread Julia Lawall
On Sat, 24 Jun 2017, Frans Klaver wrote: > Hm. For some reason the great mail filtering scheme decided to push > this past my inbox :-/ > > On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches wrote: > > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > >> The header field in struct pd_message

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-23 Thread Frans Klaver
Hm. For some reason the great mail filtering scheme decided to push this past my inbox :-/ On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches wrote: > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: >> The header field in struct pd_message is declared as an __le16 type. The

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-23 Thread Frans Klaver
Hm. For some reason the great mail filtering scheme decided to push this past my inbox :-/ On Sat, Jun 17, 2017 at 12:44 AM, Joe Perches wrote: > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: >> The header field in struct pd_message is declared as an __le16 type. The >> data in the

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-17 Thread Julia Lawall
On Fri, 16 Jun 2017, Joe Perches wrote: > On Sat, 2017-06-17 at 08:00 +0200, Julia Lawall wrote: > > On Fri, 16 Jun 2017, Joe Perches wrote: > > > On Sat, 2017-06-17 at 07:23 +0200, Julia Lawall wrote: > > > > On Fri, 16 Jun 2017, Joe Perches wrote: > > > > > On Fri, 2017-06-16 at 19:45 +0200,

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-17 Thread Julia Lawall
On Fri, 16 Jun 2017, Joe Perches wrote: > On Sat, 2017-06-17 at 08:00 +0200, Julia Lawall wrote: > > On Fri, 16 Jun 2017, Joe Perches wrote: > > > On Sat, 2017-06-17 at 07:23 +0200, Julia Lawall wrote: > > > > On Fri, 16 Jun 2017, Joe Perches wrote: > > > > > On Fri, 2017-06-16 at 19:45 +0200,

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-17 Thread Joe Perches
On Sat, 2017-06-17 at 08:00 +0200, Julia Lawall wrote: > On Fri, 16 Jun 2017, Joe Perches wrote: > > On Sat, 2017-06-17 at 07:23 +0200, Julia Lawall wrote: > > > On Fri, 16 Jun 2017, Joe Perches wrote: > > > > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > > > > > The header field in

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-17 Thread Joe Perches
On Sat, 2017-06-17 at 08:00 +0200, Julia Lawall wrote: > On Fri, 16 Jun 2017, Joe Perches wrote: > > On Sat, 2017-06-17 at 07:23 +0200, Julia Lawall wrote: > > > On Fri, 16 Jun 2017, Joe Perches wrote: > > > > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > > > > > The header field in

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-17 Thread Julia Lawall
On Fri, 16 Jun 2017, Joe Perches wrote: > On Sat, 2017-06-17 at 07:23 +0200, Julia Lawall wrote: > > On Fri, 16 Jun 2017, Joe Perches wrote: > > > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > > > > The header field in struct pd_message is declared as an __le16 type. The > > > > data

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-17 Thread Julia Lawall
On Fri, 16 Jun 2017, Joe Perches wrote: > On Sat, 2017-06-17 at 07:23 +0200, Julia Lawall wrote: > > On Fri, 16 Jun 2017, Joe Perches wrote: > > > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > > > > The header field in struct pd_message is declared as an __le16 type. The > > > > data

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-16 Thread Joe Perches
On Sat, 2017-06-17 at 07:23 +0200, Julia Lawall wrote: > On Fri, 16 Jun 2017, Joe Perches wrote: > > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > > > The header field in struct pd_message is declared as an __le16 type. The > > > data in the message is supposed to be little endian. This

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-16 Thread Joe Perches
On Sat, 2017-06-17 at 07:23 +0200, Julia Lawall wrote: > On Fri, 16 Jun 2017, Joe Perches wrote: > > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > > > The header field in struct pd_message is declared as an __le16 type. The > > > data in the message is supposed to be little endian. This

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-16 Thread Julia Lawall
On Fri, 16 Jun 2017, Joe Perches wrote: > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > > The header field in struct pd_message is declared as an __le16 type. The > > data in the message is supposed to be little endian. This means we don't > > have to go and shift the individual

Re: endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-16 Thread Julia Lawall
On Fri, 16 Jun 2017, Joe Perches wrote: > On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > > The header field in struct pd_message is declared as an __le16 type. The > > data in the message is supposed to be little endian. This means we don't > > have to go and shift the individual

endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-16 Thread Joe Perches
On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > The header field in struct pd_message is declared as an __le16 type. The > data in the message is supposed to be little endian. This means we don't > have to go and shift the individual bytes into position when we're > filling the buffer, we

endian bitshift defects [ was: staging: fusb302: don't bitshift __le16 type ]

2017-06-16 Thread Joe Perches
On Fri, 2017-06-16 at 19:45 +0200, Frans Klaver wrote: > The header field in struct pd_message is declared as an __le16 type. The > data in the message is supposed to be little endian. This means we don't > have to go and shift the individual bytes into position when we're > filling the buffer, we