Re: [PATCH] um,ethertap: refactor deprecated strncpy

2023-09-14 Thread Kees Cook
On Tue, Sep 12, 2023 at 01:12:35PM -0700, Justin Stitt wrote: > On Tue, Sep 12, 2023 at 12:36 AM Geert Uytterhoeven > wrote: > > > > Hi Justin, > > > > Thanks for your patch! > > > > On Mon, Sep 11, 2023 at 7:53 PM Justin Stitt wrote: > > > `strncpy` is deprecated for use on NUL-terminated

Re: [PATCH] um,ethertap: refactor deprecated strncpy

2023-09-12 Thread Justin Stitt
o this, let's use `strscpy` as it guarantees > > NUL-terminated on the destination buffer preventing potential buffer > > overreads [2]. > > > > This exact invocation was changed from `strcpy` to `strncpy` in commit > > 7879b1d94badb ("um,ethertap: use strncpy") back in 20

Re: [PATCH] um,ethertap: refactor deprecated strncpy

2023-09-12 Thread Geert Uytterhoeven
on the destination buffer preventing potential buffer > overreads [2]. > > This exact invocation was changed from `strcpy` to `strncpy` in commit > 7879b1d94badb ("um,ethertap: use strncpy") back in 2015. Let's continue > hardening our `str*cpy` apis and use the newer and safer

[PATCH] um,ethertap: refactor deprecated strncpy

2023-09-11 Thread Justin Stitt
on the destination buffer preventing potential buffer overreads [2]. This exact invocation was changed from `strcpy` to `strncpy` in commit 7879b1d94badb ("um,ethertap: use strncpy") back in 2015. Let's continue hardening our `str*cpy` apis and use the newer and safer `strscpy`! Link: www.kern

Re: [PATCH RESEND] um,ethertap: use strncpy

2015-01-20 Thread Geert Uytterhoeven
On Tue, Jan 20, 2015 at 1:11 PM, Alan wrote: > I can't prove the case pointed out in > https://bugzilla.kernel.org/show_bug.cgi?id=82341 > is correct so let us play safe. > > Signed-off-by: Alan Cox > --- > arch/um/os-Linux/drivers/ethertap_user.c |2 +- > 1 file changed, 1 insertion(+), 1

[PATCH RESEND] um,ethertap: use strncpy

2015-01-20 Thread Alan
I can't prove the case pointed out in https://bugzilla.kernel.org/show_bug.cgi?id=82341 is correct so let us play safe. Signed-off-by: Alan Cox --- arch/um/os-Linux/drivers/ethertap_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH RESEND] um,ethertap: use strncpy

2015-01-20 Thread Alan
I can't prove the case pointed out in https://bugzilla.kernel.org/show_bug.cgi?id=82341 is correct so let us play safe. Signed-off-by: Alan Cox a...@linux.intel.com --- arch/um/os-Linux/drivers/ethertap_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH RESEND] um,ethertap: use strncpy

2015-01-20 Thread Geert Uytterhoeven
On Tue, Jan 20, 2015 at 1:11 PM, Alan gno...@lxorguk.ukuu.org.uk wrote: I can't prove the case pointed out in https://bugzilla.kernel.org/show_bug.cgi?id=82341 is correct so let us play safe. Signed-off-by: Alan Cox a...@linux.intel.com --- arch/um/os-Linux/drivers/ethertap_user.c |2

ethertap

2001-06-05 Thread Gábor Lénárt
Hi! According /usr/src/linux/Documentation/networking/ethertap.txt I've tried to use ethertap for my experimental user space TCP/IP implementation testing. I'm using kernel 2.2.19 (UP). I load ethertap kernel module and configure it with ifconfig. Nice, ping works, ifconfig show tap0. /dev

ethertap

2001-06-05 Thread Gbor Lnrt
Hi! According /usr/src/linux/Documentation/networking/ethertap.txt I've tried to use ethertap for my experimental user space TCP/IP implementation testing. I'm using kernel 2.2.19 (UP). I load ethertap kernel module and configure it with ifconfig. Nice, ping works, ifconfig show tap0. /dev

Re: question regarding routing/ethertap

2001-02-18 Thread Jones Olatunji
Hi, I am sorry the might be of the list's normal content. My colleague will be on leave in may this year in states and wish to attend any I.T related conference during that period. Can you please send any info. if you are aware of any for that period. Thanks, Jones Find the best deals on

Re: question regarding routing/ethertap

2001-02-18 Thread Jones Olatunji
Hi, I am sorry the might be of the list's normal content. My colleague will be on leave in may this year in states and wish to attend any I.T related conference during that period. Can you please send any info. if you are aware of any for that period. Thanks, Jones Find the best deals on

question regarding routing/ethertap

2001-02-02 Thread Christopher Friesen
I have a quick question regarding the ethertap device and routing. We're seeing the contents of the packet coming up through the ethertap device just fine, but the originating address seems to be overwritten with the ethertap device's address. Am I missing something obvious here? I'm positive

question regarding routing/ethertap

2001-02-02 Thread Christopher Friesen
I have a quick question regarding the ethertap device and routing. We're seeing the contents of the packet coming up through the ethertap device just fine, but the originating address seems to be overwritten with the ethertap device's address. Am I missing something obvious here? I'm positive