Re: ext4: fix memory leak in xattr code.

2013-09-22 Thread Theodore Ts'o
Thanks, applied with a minor bug fix... - Ted commit 8484764f97a840df851f4586079f28715f13318e Author: Dave Jones Date: Sun Sep 22 15:31:00 2013 -0400 ext4: fix memory leak in xattr If we take the 2nd retry path in ext4_expand_extra_

Re: ext4: fix memory leak in xattr code.

2013-09-20 Thread Eric Sandeen
On 9/20/13 9:29 AM, Dave Jones wrote: > If we take the 2nd retry path in ext4_expand_extra_isize_ea, we potentionally > return from the function without having freed these allocations. > If we don't do the return, we over-write the previous allocation pointers, > so we leak either way. > > Spotte

ext4: fix memory leak in xattr code.

2013-09-20 Thread Dave Jones
If we take the 2nd retry path in ext4_expand_extra_isize_ea, we potentionally return from the function without having freed these allocations. If we don't do the return, we over-write the previous allocation pointers, so we leak either way. Spotted with Coverity. Signed-off-by: Dave Jones diff