Re: f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-17 Thread Gu Zheng
Hi Alexey, Kim, On 04/18/2014 02:04 PM, Alexey Khoroshilov wrote: > On 17.04.2014 00:45, Jaegeuk Kim wrote: >> Hi, >> >> 2014-04-16 (수), 18:11 -0700, Alexey Khoroshilov: >>> Hi, >>> >>> But would not ability to trigger BUG_ON by mounting a crafted image >>> considered as an issue having security i

Re: f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-17 Thread Jaegeuk Kim
Thank you for the explanation. The following patch will resolve the issue. Thanks, >From 2048e7458c982f4297da9d3366ab29224ae2e8b0 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Fri, 18 Apr 2014 15:21:04 +0900 Subject: [PATCH] f2fs: avoid BUG_ON when mouting corrupted image having garbage block

Re: f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-17 Thread Alexey Khoroshilov
On 17.04.2014 00:45, Jaegeuk Kim wrote: > Hi, > > 2014-04-16 (수), 18:11 -0700, Alexey Khoroshilov: >> Hi, >> >> But would not ability to trigger BUG_ON by mounting a crafted image >> considered as an issue having security implications? > Sorry, I can't come up with you. > Could you please explain w

Re: f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-17 Thread Jaegeuk Kim
Hi, 2014-04-16 (수), 18:11 -0700, Alexey Khoroshilov: > Hi, > > But would not ability to trigger BUG_ON by mounting a crafted image > considered as an issue having security implications? Sorry, I can't come up with you. Could you please explain why this can be related to the security hole? Did yo

Re: f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-16 Thread Alexey Khoroshilov
Hi, But would not ability to trigger BUG_ON by mounting a crafted image considered as an issue having security implications? Regards, Alexey On 16.04.2014 16:35, Jaegeuk Kim wrote: > Hi, > > 2014-04-16 (수), 13:11 +0400, Andrey Tsyvarev: >> Hi, >> >> With this patch mounting of the image continu

Re: f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-16 Thread Jaegeuk Kim
Hi, 2014-04-16 (수), 13:11 +0400, Andrey Tsyvarev: > Hi, > > With this patch mounting of the image continues to fail (with similar > BUG_ON). > But when image is formatted again (and steps mentioned in the previous > message are performed), > mounting of it is now succeed. > > Is this is a true

Re: f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-16 Thread Andrey Tsyvarev
Hi, With this patch mounting of the image continues to fail (with similar BUG_ON). But when image is formatted again (and steps mentioned in the previous message are performed), mounting of it is now succeed. Is this is a true purpose of the patch? 15.04.2014 15:04, Jaegeuk Kim пишет: Hi,

Re: f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-15 Thread Jaegeuk Kim
Hi, Thank you for the report. I retrieved the fault image and found out that previous garbage data wreak such the wrong behaviors. So, I wrote the following patch that fills one zero-block at the checkpoint procedure. If the underlying device supports discard, I expect that it mostly doesn't incur

f2fs: BUG_ON() is triggered when mount valid f2fs filesystem

2014-04-14 Thread Andrey Tsyvarev
Hello, When mount this f2fs image: http://linuxtesting.org/downloads/f2fs_fault_image.zip BUG_ON is triggered in f2fs driver (messages below are generated on kernel 3.13.2; for other kernels output is similar): [ 2416.364463] kernel BUG at fs/f2fs/node.c:215! [ 2416.364464] invalid opcode: 00