Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Jaegeuk Kim
Hi, 2014-02-13 (목), 17:48 +0800, Gu Zheng: > Hi, > On 02/13/2014 05:40 PM, Andrey Tsyvarev wrote: > > > Hi, > > > >> BTW, have you tested the case that added remove_dirty_dir_inode() into the > >> fail path > >> of init_inode_metadata? > >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c > >> index

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Jaegeuk Kim
Hi, Sorry for the late response. I suffered from flu during last a couple of days. :( 2014-02-11 (화), 12:29 +0400, Andrey Tsyvarev: > Hi, > > > It turns out that make_bad_inode prior to iput sets i_mode to a regular > > file, so that f2fs_evict_inode -> truncate_inode_pages -> > >

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Gu Zheng
Hi, On 02/13/2014 05:40 PM, Andrey Tsyvarev wrote: > Hi, > >> BTW, have you tested the case that added remove_dirty_dir_inode() into the >> fail path >> of init_inode_metadata? >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c >> index e095a4f..d5a2c9e 100644 >> --- a/fs/f2fs/dir.c >> +++

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Andrey Tsyvarev
Hi, BTW, have you tested the case that added remove_dirty_dir_inode() into the fail path of init_inode_metadata? diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index e095a4f..d5a2c9e 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -375,6 +375,7 @@ put_error: /* once the failed inode

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Gu Zheng
Hi Andrey, On 02/11/2014 04:29 PM, Andrey Tsyvarev wrote: > Hi, > >> It turns out that make_bad_inode prior to iput sets i_mode to a regular >> file, so that f2fs_evict_inode -> truncate_inode_pages -> >> f2fs_invalidate_data_page doesn't decrement dirty_dents. >> > It seems that

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Gu Zheng
Hi Andrey, On 02/11/2014 04:29 PM, Andrey Tsyvarev wrote: Hi, It turns out that make_bad_inode prior to iput sets i_mode to a regular file, so that f2fs_evict_inode - truncate_inode_pages - f2fs_invalidate_data_page doesn't decrement dirty_dents. It seems that remove_dirty_dir_inode()

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Andrey Tsyvarev
Hi, BTW, have you tested the case that added remove_dirty_dir_inode() into the fail path of init_inode_metadata? diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index e095a4f..d5a2c9e 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -375,6 +375,7 @@ put_error: /* once the failed inode

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Gu Zheng
Hi, On 02/13/2014 05:40 PM, Andrey Tsyvarev wrote: Hi, BTW, have you tested the case that added remove_dirty_dir_inode() into the fail path of init_inode_metadata? diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index e095a4f..d5a2c9e 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Jaegeuk Kim
Hi, Sorry for the late response. I suffered from flu during last a couple of days. :( 2014-02-11 (화), 12:29 +0400, Andrey Tsyvarev: Hi, It turns out that make_bad_inode prior to iput sets i_mode to a regular file, so that f2fs_evict_inode - truncate_inode_pages -

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-13 Thread Jaegeuk Kim
Hi, 2014-02-13 (목), 17:48 +0800, Gu Zheng: Hi, On 02/13/2014 05:40 PM, Andrey Tsyvarev wrote: Hi, BTW, have you tested the case that added remove_dirty_dir_inode() into the fail path of init_inode_metadata? diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index e095a4f..d5a2c9e

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-11 Thread Andrey Tsyvarev
Hi, It turns out that make_bad_inode prior to iput sets i_mode to a regular file, so that f2fs_evict_inode -> truncate_inode_pages -> f2fs_invalidate_data_page doesn't decrement dirty_dents. It seems that remove_dirty_dir_inode() call should also be added to the error-path of

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-11 Thread Andrey Tsyvarev
Hi, It turns out that make_bad_inode prior to iput sets i_mode to a regular file, so that f2fs_evict_inode - truncate_inode_pages - f2fs_invalidate_data_page doesn't decrement dirty_dents. It seems that remove_dirty_dir_inode() call should also be added to the error-path of

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-06 Thread Jaegeuk Kim
Hi, It turns out that make_bad_inode prior to iput sets i_mode to a regular file, so that f2fs_evict_inode -> truncate_inode_pages -> f2fs_invalidate_data_page doesn't decrement dirty_dents. This patch should resolve the bug. Thank you :) When a new directory is allocated, if an error is

Re: f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-06 Thread Jaegeuk Kim
Hi, 2014-02-06 (목), 16:17 +0400, Andrey Tsyvarev: > Hi, > > 06.02.2014 10:02, Jaegeuk Kim пишет: > > Hi, > > > > Thank you for the test and valuable report. > > > > This bug was fixed recently by: > > > > commit 03dea3129d558bf5293a6e9f12777176619ac876 > > Author: Jaegeuk Kim > > Date: Wed

Re: f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-06 Thread Andrey Tsyvarev
Hi, 06.02.2014 10:02, Jaegeuk Kim пишет: Hi, Thank you for the test and valuable report. This bug was fixed recently by: commit 03dea3129d558bf5293a6e9f12777176619ac876 Author: Jaegeuk Kim Date: Wed Feb 5 11:16:39 2014 +0900 f2fs: fix to truncate dentry pages in the error case Now

Re: f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-06 Thread Andrey Tsyvarev
Hi, 06.02.2014 10:02, Jaegeuk Kim пишет: Hi, Thank you for the test and valuable report. This bug was fixed recently by: commit 03dea3129d558bf5293a6e9f12777176619ac876 Author: Jaegeuk Kim jaegeuk@samsung.com Date: Wed Feb 5 11:16:39 2014 +0900 f2fs: fix to truncate dentry pages

Re: f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-06 Thread Jaegeuk Kim
Hi, 2014-02-06 (목), 16:17 +0400, Andrey Tsyvarev: Hi, 06.02.2014 10:02, Jaegeuk Kim пишет: Hi, Thank you for the test and valuable report. This bug was fixed recently by: commit 03dea3129d558bf5293a6e9f12777176619ac876 Author: Jaegeuk Kim jaegeuk@samsung.com Date: Wed

Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-06 Thread Jaegeuk Kim
Hi, It turns out that make_bad_inode prior to iput sets i_mode to a regular file, so that f2fs_evict_inode - truncate_inode_pages - f2fs_invalidate_data_page doesn't decrement dirty_dents. This patch should resolve the bug. Thank you :) When a new directory is allocated, if an error is

Re: f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-05 Thread Jaegeuk Kim
Hi, Thank you for the test and valuable report. This bug was fixed recently by: commit 03dea3129d558bf5293a6e9f12777176619ac876 Author: Jaegeuk Kim Date: Wed Feb 5 11:16:39 2014 +0900 f2fs: fix to truncate dentry pages in the error case You can find that from the tree:

f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-05 Thread Andrey Tsyvarev
Hello, Testing f2fs (of linux-3.13) under fault simulation, we detected umount() hangs up after mkdir()-> f2fs_add_link()-> init_inode_metadata()-> f2fs_init_acl()-> f2fs_get_acl()-> f2fs_getxattr()-> read_all_xattrs() fails. Also there was a BUG_ON

f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-05 Thread Andrey Tsyvarev
Hello, Testing f2fs (of linux-3.13) under fault simulation, we detected umount() hangs up after mkdir()- f2fs_add_link()- init_inode_metadata()- f2fs_init_acl()- f2fs_get_acl()- f2fs_getxattr()- read_all_xattrs() fails. Also there was a BUG_ON

Re: f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

2014-02-05 Thread Jaegeuk Kim
Hi, Thank you for the test and valuable report. This bug was fixed recently by: commit 03dea3129d558bf5293a6e9f12777176619ac876 Author: Jaegeuk Kim jaegeuk@samsung.com Date: Wed Feb 5 11:16:39 2014 +0900 f2fs: fix to truncate dentry pages in the error case You can find that from the