Re: f2fs get_dnode_of_data oops

2014-09-10 Thread Jaegeuk Kim
Hi, On Tue, Sep 09, 2014 at 09:24:18PM +0300, Tommi Rantala wrote: > 2014-09-09 7:41 GMT+03:00 Jaegeuk Kim : > > Hi Tommi, > > > > This patch should resolve this bug. > > Thanks a lot. :) > > > > From ee24677b9917583f50f16b6f59771439f91b890c Mon Sep 17 00:00:00 2001 > > From: Jaegeuk Kim > > Date

Re: [f2fs-dev] f2fs get_dnode_of_data oops

2014-09-10 Thread Jaegeuk Kim
On Tue, Sep 09, 2014 at 04:10:00PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > Looks good to me! > > One nitpick, how about judging this condition before we lock ->i_mutex to > avoid unneeded lock contention and invoking of i_size_read()? Agreed. >From 0b4c5afde9b57c08b55d26725d228d5314cfc57a Mon S

Re: f2fs get_dnode_of_data oops

2014-09-09 Thread Tommi Rantala
2014-09-09 7:41 GMT+03:00 Jaegeuk Kim : > Hi Tommi, > > This patch should resolve this bug. > Thanks a lot. :) > > From ee24677b9917583f50f16b6f59771439f91b890c Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Mon, 8 Sep 2014 10:59:43 -0700 > Subject: [PATCH] f2fs: fix negative value for lseek

RE: [f2fs-dev] f2fs get_dnode_of_data oops

2014-09-09 Thread Chao Yu
09, 2014 12:42 PM > To: Tommi Rantala > Cc: Dave Jones; trin...@vger.kernel.org; LKML; > linux-f2fs-de...@lists.sourceforge.net > Subject: Re: [f2fs-dev] f2fs get_dnode_of_data oops > > Hi Tommi, > > This patch should resolve this bug. > Thanks a lot. :) > > >F

Re: f2fs get_dnode_of_data oops

2014-09-08 Thread Jaegeuk Kim
Hi Tommi, This patch should resolve this bug. Thanks a lot. :) >From ee24677b9917583f50f16b6f59771439f91b890c Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Mon, 8 Sep 2014 10:59:43 -0700 Subject: [PATCH] f2fs: fix negative value for lseek offset If application throws negative value of lseek

Re: f2fs get_dnode_of_data oops

2014-09-08 Thread Tommi Rantala
2014-09-08 7:20 GMT+03:00 Jaegeuk Kim : > Hi, > > Thank you for the report. > Could you share a little bit more information about the file accessing > f2fs_llseek? > E.g., file size, file offset, file allocation information, or dump of that > file. Hi, I can reproduce the bug with the following.

Re: f2fs get_dnode_of_data oops

2014-09-07 Thread Jaegeuk Kim
Hi, Thank you for the report. Could you share a little bit more information about the file accessing f2fs_llseek? E.g., file size, file offset, file allocation information, or dump of that file. Thanks, On Sun, Sep 07, 2014 at 10:20:44PM +0300, Tommi Rantala wrote: > 2014-09-07 22:14 GMT+03:00 T

Re: f2fs get_dnode_of_data oops

2014-09-07 Thread Tommi Rantala
2014-09-07 22:14 GMT+03:00 Tommi Rantala : > Hello, > > Hit this oops while fuzzing v3.17-rc3-176-g2b12164 with Trinity. > > Tommi > > > BUG: unable to handle kernel paging request at 8804338717a8 > IP: [] get_dnode_of_data+0x3a9/0x440 > PGD 4594067 PUD 0 > Oops: [#1] SMP DEBUG_PAGEALLOC >

f2fs get_dnode_of_data oops

2014-09-07 Thread Tommi Rantala
Hello, Hit this oops while fuzzing v3.17-rc3-176-g2b12164 with Trinity. Tommi BUG: unable to handle kernel paging request at 8804338717a8 IP: [] get_dnode_of_data+0x3a9/0x440 PGD 4594067 PUD 0 Oops: [#1] SMP DEBUG_PAGEALLOC CPU: 0 PID: 4719 Comm: trinity-c3 Not tainted 3.17.0-rc3+ #33