Re: f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

2021-03-03 Thread Jaegeuk Kim
On 03/03, Colin Ian King wrote: > On 03/03/2021 19:44, Jaegeuk Kim wrote: > > On 03/02, Colin Ian King wrote: > >> Hi, > >> > >> Static analysis on linux-next detected a potential uninitialized > >> variable dn.node_changed that does not get set when a call to > >> f2fs_get_node_page() fails.

Re: f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

2021-03-03 Thread Colin Ian King
On 03/03/2021 19:44, Jaegeuk Kim wrote: > On 03/02, Colin Ian King wrote: >> Hi, >> >> Static analysis on linux-next detected a potential uninitialized >> variable dn.node_changed that does not get set when a call to >> f2fs_get_node_page() fails. This uninitialized value gets used in the >> call

Re: f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

2021-03-03 Thread Jaegeuk Kim
On 03/02, Colin Ian King wrote: > Hi, > > Static analysis on linux-next detected a potential uninitialized > variable dn.node_changed that does not get set when a call to > f2fs_get_node_page() fails. This uninitialized value gets used in the > call to f2fs_balance_fs() that may or not may not

f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

2021-03-02 Thread Colin Ian King
Hi, Static analysis on linux-next detected a potential uninitialized variable dn.node_changed that does not get set when a call to f2fs_get_node_page() fails. This uninitialized value gets used in the call to f2fs_balance_fs() that may or not may not balances dirty node and dentry pages