On 8/24/07, Josef Sipek <[EMAIL PROTECTED]> wrote:
> On Fri, Aug 24, 2007 at 09:24:17AM -0400, Mike Frysinger wrote:
> ...
> > $ grep AUREON_DEVICE_DESC ./sound/pci/ice1712/aureon.h -A 5
> > #define AUREON_DEVICE_DESC"{Terratec,Aureon 5.1 Sky},"\
> >
On Fri, Aug 24, 2007 at 05:43:47AM -0700, SL Baur wrote:
> Who uses code like this, by the way?
People who think Posix is an example to follow maybe? Not sure if it
would go past the maintainers though :-)
# define PTHREAD_MUTEX_INITIALIZER \
{ { 0, 0, 0, 0, 0, { 0 } } }
# ifdef __USE_GNU
#
On Fri, Aug 24, 2007 at 09:24:17AM -0400, Mike Frysinger wrote:
...
> $ grep AUREON_DEVICE_DESC ./sound/pci/ice1712/aureon.h -A 5
> #define AUREON_DEVICE_DESC"{Terratec,Aureon 5.1 Sky},"\
>"{Terratec,Aureon 7.1 Space},"\
>
On 8/24/07, SL Baur <[EMAIL PROTECTED]> wrote:
> On 8/24/07, Andy Whitcroft <[EMAIL PROTECTED]> wrote:
> > Mike Frysinger wrote:
> > > in some code that does like:
> > > #define foo { a, b, c, \
> > > d, e, f, g }
> > > ...
> > > int boo[] = foo;
> > > ...
> > >
> > > checkpatch.pl throws a
On 8/24/07, SL Baur <[EMAIL PROTECTED]> wrote:
> I think the
> error message is wrong.
I mean the error message is badly worded. That's bad C and the
macro needs deletion a lot more than it needs an extra set of parens.
Been chasing a heisen bug too long. Need sleep. Sorry.
-sb
-
To
On 8/24/07, Andy Whitcroft <[EMAIL PROTECTED]> wrote:
> Mike Frysinger wrote:
> > in some code that does like:
> > #define foo { a, b, c, \
> > d, e, f, g }
> > ...
> > int boo[] = foo;
> > ...
> >
> > checkpatch.pl throws a fit:
> > ERROR: Macros with complex values should be enclosed in
Mike Frysinger wrote:
> in some code that does like:
> #define foo { a, b, c, \
> d, e, f, g }
> ...
> int boo[] = foo;
> ...
>
> checkpatch.pl throws a fit:
> ERROR: Macros with complex values should be enclosed in parenthesis
> #10: FILE: ...
> +#define foo {a, b, c, d}
>
> perhaps the
in some code that does like:
#define foo { a, b, c, \
d, e, f, g }
...
int boo[] = foo;
...
checkpatch.pl throws a fit:
ERROR: Macros with complex values should be enclosed in parenthesis
#10: FILE: ...
+#define foo {a, b, c, d}
perhaps the check should also allow {...} ? or ignore lists
in some code that does like:
#define foo { a, b, c, \
d, e, f, g }
...
int boo[] = foo;
...
checkpatch.pl throws a fit:
ERROR: Macros with complex values should be enclosed in parenthesis
#10: FILE: ...
+#define foo {a, b, c, d}
perhaps the check should also allow {...} ? or ignore lists
Mike Frysinger wrote:
in some code that does like:
#define foo { a, b, c, \
d, e, f, g }
...
int boo[] = foo;
...
checkpatch.pl throws a fit:
ERROR: Macros with complex values should be enclosed in parenthesis
#10: FILE: ...
+#define foo {a, b, c, d}
perhaps the check should
On 8/24/07, Andy Whitcroft [EMAIL PROTECTED] wrote:
Mike Frysinger wrote:
in some code that does like:
#define foo { a, b, c, \
d, e, f, g }
...
int boo[] = foo;
...
checkpatch.pl throws a fit:
ERROR: Macros with complex values should be enclosed in parenthesis
#10: FILE:
On 8/24/07, SL Baur [EMAIL PROTECTED] wrote:
I think the
error message is wrong.
I mean the error message is badly worded. That's bad C and the
macro needs deletion a lot more than it needs an extra set of parens.
Been chasing a heisen bug too long. Need sleep. Sorry.
-sb
-
To unsubscribe
On 8/24/07, SL Baur [EMAIL PROTECTED] wrote:
On 8/24/07, Andy Whitcroft [EMAIL PROTECTED] wrote:
Mike Frysinger wrote:
in some code that does like:
#define foo { a, b, c, \
d, e, f, g }
...
int boo[] = foo;
...
checkpatch.pl throws a fit:
ERROR: Macros with
On Fri, Aug 24, 2007 at 09:24:17AM -0400, Mike Frysinger wrote:
...
$ grep AUREON_DEVICE_DESC ./sound/pci/ice1712/aureon.h -A 5
#define AUREON_DEVICE_DESC{Terratec,Aureon 5.1 Sky},\
{Terratec,Aureon 7.1 Space},\
On Fri, Aug 24, 2007 at 05:43:47AM -0700, SL Baur wrote:
Who uses code like this, by the way?
People who think Posix is an example to follow maybe? Not sure if it
would go past the maintainers though :-)
# define PTHREAD_MUTEX_INITIALIZER \
{ { 0, 0, 0, 0, 0, { 0 } } }
# ifdef __USE_GNU
#
On 8/24/07, Josef Sipek [EMAIL PROTECTED] wrote:
On Fri, Aug 24, 2007 at 09:24:17AM -0400, Mike Frysinger wrote:
...
$ grep AUREON_DEVICE_DESC ./sound/pci/ice1712/aureon.h -A 5
#define AUREON_DEVICE_DESC{Terratec,Aureon 5.1 Sky},\
16 matches
Mail list logo
