Re: [V3] firmware: vpd: use memunmap instead of iounmap

2017-08-10 Thread Dmitry Torokhov
On Fri, Aug 11, 2017 at 07:13:13AM +0800, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() should be > used. > > Signed-off-by: Pan Bian Reviewed-by: Dmitry Torokhov

Re: [V3] firmware: vpd: use memunmap instead of iounmap

2017-08-10 Thread Dmitry Torokhov
On Fri, Aug 11, 2017 at 07:13:13AM +0800, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() should be > used. > > Signed-off-by: Pan Bian Reviewed-by: Dmitry Torokhov > --- > V2: change error

[V3] firmware: vpd: use memunmap instead of iounmap

2017-08-10 Thread Pan Bian
In functions vpd_sections_init() and vpd_section_init(), iounmap() is used to unmap memory. However, in these cases, memunmap() should be used. Signed-off-by: Pan Bian --- V2: change error label err_iounmap to err_memunmap V3: add changes from V1 to V2 ---

[V3] firmware: vpd: use memunmap instead of iounmap

2017-08-10 Thread Pan Bian
In functions vpd_sections_init() and vpd_section_init(), iounmap() is used to unmap memory. However, in these cases, memunmap() should be used. Signed-off-by: Pan Bian --- V2: change error label err_iounmap to err_memunmap V3: add changes from V1 to V2 --- drivers/firmware/google/vpd.c | 10

Re: [V2] firmware: vpd: use memunmap instead of iounmap

2017-08-10 Thread Greg Kroah-Hartman
On Wed, Aug 09, 2017 at 07:01:47PM +0800, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() should be > used. > > Signed-off-by: Pan Bian > --- > drivers/firmware/google/vpd.c

Re: [V2] firmware: vpd: use memunmap instead of iounmap

2017-08-10 Thread Greg Kroah-Hartman
On Wed, Aug 09, 2017 at 07:01:47PM +0800, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() should be > used. > > Signed-off-by: Pan Bian > --- > drivers/firmware/google/vpd.c | 10 +- > 1

[V2] firmware: vpd: use memunmap instead of iounmap

2017-08-09 Thread Pan Bian
In functions vpd_sections_init() and vpd_section_init(), iounmap() is used to unmap memory. However, in these cases, memunmap() should be used. Signed-off-by: Pan Bian --- drivers/firmware/google/vpd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[V2] firmware: vpd: use memunmap instead of iounmap

2017-08-09 Thread Pan Bian
In functions vpd_sections_init() and vpd_section_init(), iounmap() is used to unmap memory. However, in these cases, memunmap() should be used. Signed-off-by: Pan Bian --- drivers/firmware/google/vpd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: firmware: vpd: use memunmap instead of iounmap

2017-08-08 Thread Dmitry Torokhov
Hi Pan, On Tue, Aug 8, 2017 at 5:45 AM, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() is better. > > Signed-off-by: Pan Bian > --- >

Re: firmware: vpd: use memunmap instead of iounmap

2017-08-08 Thread Dmitry Torokhov
Hi Pan, On Tue, Aug 8, 2017 at 5:45 AM, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() is better. > > Signed-off-by: Pan Bian > --- > drivers/firmware/google/vpd.c | 6 +++--- > 1 file changed,

Re: firmware: vpd: use memunmap instead of iounmap

2017-08-08 Thread Guenter Roeck
On Tue, Aug 8, 2017 at 5:45 AM, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() is better. > > Signed-off-by: Pan Bian The code uses memremap(), so that

Re: firmware: vpd: use memunmap instead of iounmap

2017-08-08 Thread Guenter Roeck
On Tue, Aug 8, 2017 at 5:45 AM, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() is better. > > Signed-off-by: Pan Bian The code uses memremap(), so that seems reasonable. Reviewed-by: Guenter

firmware: vpd: use memunmap instead of iounmap

2017-08-08 Thread Pan Bian
In functions vpd_sections_init() and vpd_section_init(), iounmap() is used to unmap memory. However, in these cases, memunmap() is better. Signed-off-by: Pan Bian --- drivers/firmware/google/vpd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

firmware: vpd: use memunmap instead of iounmap

2017-08-08 Thread Pan Bian
In functions vpd_sections_init() and vpd_section_init(), iounmap() is used to unmap memory. However, in these cases, memunmap() is better. Signed-off-by: Pan Bian --- drivers/firmware/google/vpd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git