Hi. I'm late.
I'll to resend the patch against 2.6.19.
original code doesn't write back to CCR4 register. this patch reflects a
value of a register.
diff -Narup linux-2.6.19.orig/arch/i386/kernel/cpu/cyrix.c
linux-2.6.19/arch/i386/kernel/cpu/cyrix.c
--- linux-2.6.19.orig/arch/i386/kernel/cpu/cy
On Fri, 2 Feb 2007 10:12:36 -0500
[EMAIL PROTECTED] (Lennart Sorensen) wrote:
> On Fri, Feb 02, 2007 at 12:05:43AM -0800, Andrew Morton wrote:
> > On Fri, 2 Feb 2007 07:29:41 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote:
> >
> > > Linus, please revert commit e4f0ae0ea63caceff37a13f281a72652b7ea71b
On Fri, Feb 02, 2007 at 12:05:43AM -0800, Andrew Morton wrote:
> On Fri, 2 Feb 2007 07:29:41 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > Linus, please revert commit e4f0ae0ea63caceff37a13f281a72652b7ea71ba
> >
>
> Yup.
>
> That discussion seems to have died. The 2.6.19 code looks rather
On Fri, Feb 02, 2007 at 07:29:41AM +0100, Adrian Bunk wrote:
> Linus, please revert commit e4f0ae0ea63caceff37a13f281a72652b7ea71ba
>
> Rationale:
>
> The thread starting with http://lkml.org/lkml/2007/1/9/63 contains
> a discussion about what might be a correct patch.
>
> Somehow the first pat
On Friday 02 February 2007 07:29, Adrian Bunk wrote:
> Since there is AFAIK no actually observed problem fixed by this, it
> should be safe to simply revert the patch for 2.6.20.
The most important fix was:
Index: linux-2.6.19/arch/i386/kernel/cpu/cyrix.c
=
On Fri, 2 Feb 2007 07:29:41 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote:
> Linus, please revert commit e4f0ae0ea63caceff37a13f281a72652b7ea71ba
>
Yup.
That discussion seems to have died. The 2.6.19 code looks rather silly, but
presumably it passed someone's testing at some stage.
-
To unsubscr
Linus, please revert commit e4f0ae0ea63caceff37a13f281a72652b7ea71ba
Rationale:
The thread starting with http://lkml.org/lkml/2007/1/9/63 contains
a discussion about what might be a correct patch.
Somehow the first patch of this discussion made it into 2.6.20-rc, but
the ones considered more c
On Wed, 17 Jan 2007 02:12:42 +0900 (JST)
takada <[EMAIL PROTECTED]> wrote:
> From: [EMAIL PROTECTED] (Lennart Sorensen)
> Subject: Re: fix typo in geode_configre()@cyrix.c
> Date: Tue, 16 Jan 2007 11:50:07 -0500
>
> > On Wed, Jan 17, 2007 at 01:38:35AM +0900, takada wrote
Hi. Thanks Sorensen and Juergen.
I overlooked the restored to CCR3.
The bit4(0x10, MAPEN) of CCR3 is necessary to access advanced configuration
registers.
I'll repost patch.
- restore CCR3
- fix use 0x30 instead of 0x38.
--- linux-2.6.19.orig/arch/i386/kernel/cpu/cyrix.c 2006-11-30
06
On Tuesday 09 January 2007 18:33, Lennart Sorensen wrote:
> Then for the next one it does:
> ccr3 = GetCx86(CX86_CCR3);
> setCx86(CX86_CCR3, (ccr3 & 0x0f) | 0x10);
>
> Couldn't that have been:
> setCx86(CX86_CCR3, (getCx86(CX86_CCR3) & 0x0f) | 0x10);
>
> No temp variable, and again it clearly does
On Tuesday 09 January 2007 16:43, Lennart Sorensen wrote:
> On Tue, Jan 09, 2007 at 06:41:56PM +0900, takada wrote:
> > In kernel 2.6, write back wrong register when configure Geode processor.
> > Instead of storing to CCR4, it stores to CCR3.
> >
> > --- linux-2.6.19/arch/i386/kernel/cpu/cyrix.c.o
On Wed, Jan 17, 2007 at 01:38:35AM +0900, takada wrote:
> You are right. I agree to your comment. These variables are needless.
> I made a patch again.
>
> diff -Narup linux-2.6.19.orig/arch/i386/kernel/cpu/cyrix.c
> linux-2.6.19/arch/i386/kernel/cpu/cyrix.c
> --- linux-2.6.19.orig/arch/i386/kern
From: [EMAIL PROTECTED] (Lennart Sorensen)
Subject: Re: fix typo in geode_configre()@cyrix.c
Date: Tue, 16 Jan 2007 11:50:07 -0500
> On Wed, Jan 17, 2007 at 01:38:35AM +0900, takada wrote:
> > You are right. I agree to your comment. These variables are needless.
> > I made a patch
On Wed, Jan 17, 2007 at 01:38:35AM +0900, takada wrote:
> You are right. I agree to your comment. These variables are needless.
> I made a patch again.
Of course there are also lots of "magic numbers" around, but I must
admit I don't personally really feel like going through the data sheet
and nam
From: [EMAIL PROTECTED] (Lennart Sorensen)
Subject: Re: fix typo in geode_configre()@cyrix.c
Date: Tue, 9 Jan 2007 12:33:48 -0500
Thank you for comments.
> On Tue, Jan 09, 2007 at 06:41:56PM +0900, takada wrote:
> > In kernel 2.6, write back wrong register when configure Geode
On Tue, Jan 09, 2007 at 06:41:56PM +0900, takada wrote:
> In kernel 2.6, write back wrong register when configure Geode processor.
> Instead of storing to CCR4, it stores to CCR3.
>
> --- linux-2.6.19/arch/i386/kernel/cpu/cyrix.c.orig2007-01-09
> 16:45:21.0 +0900
> +++ linux-2.6.19/ar
On Tue, Jan 09, 2007 at 06:41:56PM +0900, takada wrote:
> In kernel 2.6, write back wrong register when configure Geode processor.
> Instead of storing to CCR4, it stores to CCR3.
>
> --- linux-2.6.19/arch/i386/kernel/cpu/cyrix.c.orig2007-01-09
> 16:45:21.0 +0900
> +++ linux-2.6.19/ar
In kernel 2.6, write back wrong register when configure Geode processor.
Instead of storing to CCR4, it stores to CCR3.
--- linux-2.6.19/arch/i386/kernel/cpu/cyrix.c.orig 2007-01-09
16:45:21.0 +0900
+++ linux-2.6.19/arch/i386/kernel/cpu/cyrix.c 2007-01-09 17:10:13.0
+0900
18 matches
Mail list logo
