Re: fs/attr.c:notify_change locking warning.

2013-10-16 Thread Christoph Hellwig
On Wed, Oct 16, 2013 at 09:26:51PM +1100, Dave Chinner wrote: > The killpriv calls? I couldn't find anything that implemented those > security hooks nor any documentation about it, so I'm pretty much > clueless about it. FWIW, ocfs2 doesn't implement them, either The killpriv code ends up

Re: fs/attr.c:notify_change locking warning.

2013-10-16 Thread Dave Chinner
On Wed, Oct 16, 2013 at 12:05:28AM -0700, Christoph Hellwig wrote: > On Wed, Oct 16, 2013 at 08:36:18AM +1100, Dave Chinner wrote: > > Sure, but file_remove_suid() doesn't actually modify any VFS inode > > structures until we process the flags and the modifications within > > ->setattr, which in

Re: fs/attr.c:notify_change locking warning.

2013-10-16 Thread Christoph Hellwig
On Wed, Oct 16, 2013 at 08:36:18AM +1100, Dave Chinner wrote: > Sure, but file_remove_suid() doesn't actually modify any VFS inode > structures until we process the flags and the modifications within > ->setattr, which in XFS are all done under the XFS_ILOCK_EXCL via > xfs_setattr_mode(). i.e.

Re: fs/attr.c:notify_change locking warning.

2013-10-16 Thread Christoph Hellwig
On Wed, Oct 16, 2013 at 08:36:18AM +1100, Dave Chinner wrote: Sure, but file_remove_suid() doesn't actually modify any VFS inode structures until we process the flags and the modifications within -setattr, which in XFS are all done under the XFS_ILOCK_EXCL via xfs_setattr_mode(). i.e. both the

Re: fs/attr.c:notify_change locking warning.

2013-10-16 Thread Dave Chinner
On Wed, Oct 16, 2013 at 12:05:28AM -0700, Christoph Hellwig wrote: On Wed, Oct 16, 2013 at 08:36:18AM +1100, Dave Chinner wrote: Sure, but file_remove_suid() doesn't actually modify any VFS inode structures until we process the flags and the modifications within -setattr, which in XFS are

Re: fs/attr.c:notify_change locking warning.

2013-10-16 Thread Christoph Hellwig
On Wed, Oct 16, 2013 at 09:26:51PM +1100, Dave Chinner wrote: The killpriv calls? I couldn't find anything that implemented those security hooks nor any documentation about it, so I'm pretty much clueless about it. FWIW, ocfs2 doesn't implement them, either The killpriv code ends up doing

Re: fs/attr.c:notify_change locking warning.

2013-10-15 Thread Dave Chinner
On Tue, Oct 15, 2013 at 01:19:05PM -0700, Christoph Hellwig wrote: > On Sat, Oct 05, 2013 at 01:19:18PM +1000, Dave Chinner wrote: > > Yup, we don't hold the i_mutex *at all* through the fast path for > > direct IO writes. Having to grab the i_mutex on every IO just for > > the extremely unlikely

Re: fs/attr.c:notify_change locking warning.

2013-10-15 Thread Christoph Hellwig
On Sat, Oct 05, 2013 at 01:19:18PM +1000, Dave Chinner wrote: > Yup, we don't hold the i_mutex *at all* through the fast path for > direct IO writes. Having to grab the i_mutex on every IO just for > the extremely unlikely case we need to remove a suid bit on the file > would add a significant

Re: fs/attr.c:notify_change locking warning.

2013-10-15 Thread Christoph Hellwig
On Sat, Oct 05, 2013 at 01:19:18PM +1000, Dave Chinner wrote: Yup, we don't hold the i_mutex *at all* through the fast path for direct IO writes. Having to grab the i_mutex on every IO just for the extremely unlikely case we need to remove a suid bit on the file would add a significant

Re: fs/attr.c:notify_change locking warning.

2013-10-15 Thread Dave Chinner
On Tue, Oct 15, 2013 at 01:19:05PM -0700, Christoph Hellwig wrote: On Sat, Oct 05, 2013 at 01:19:18PM +1000, Dave Chinner wrote: Yup, we don't hold the i_mutex *at all* through the fast path for direct IO writes. Having to grab the i_mutex on every IO just for the extremely unlikely case we

Re: fs/attr.c:notify_change locking warning.

2013-10-04 Thread Dave Chinner
On Fri, Oct 04, 2013 at 08:52:10PM -0400, Dave Jones wrote: > WARNING: CPU: 3 PID: 26128 at fs/attr.c:178 notify_change+0x34d/0x360() > Modules linked in: dlci 8021q garp sctp snd_seq_dummy bridge stp tun fuse > rfcomm hidp ipt_ULOG nfc caif_socket caif af_802154 phonet af_rxrpc bnep > bluetooth

fs/attr.c:notify_change locking warning.

2013-10-04 Thread Dave Jones
WARNING: CPU: 3 PID: 26128 at fs/attr.c:178 notify_change+0x34d/0x360() Modules linked in: dlci 8021q garp sctp snd_seq_dummy bridge stp tun fuse rfcomm hidp ipt_ULOG nfc caif_socket caif af_802154 phonet af_rxrpc bnep bluetooth rfkill can_bcm can_raw can llc2 pppoe pppox ppp_generic slhc irda

fs/attr.c:notify_change locking warning.

2013-10-04 Thread Dave Jones
WARNING: CPU: 3 PID: 26128 at fs/attr.c:178 notify_change+0x34d/0x360() Modules linked in: dlci 8021q garp sctp snd_seq_dummy bridge stp tun fuse rfcomm hidp ipt_ULOG nfc caif_socket caif af_802154 phonet af_rxrpc bnep bluetooth rfkill can_bcm can_raw can llc2 pppoe pppox ppp_generic slhc irda

Re: fs/attr.c:notify_change locking warning.

2013-10-04 Thread Dave Chinner
On Fri, Oct 04, 2013 at 08:52:10PM -0400, Dave Jones wrote: WARNING: CPU: 3 PID: 26128 at fs/attr.c:178 notify_change+0x34d/0x360() Modules linked in: dlci 8021q garp sctp snd_seq_dummy bridge stp tun fuse rfcomm hidp ipt_ULOG nfc caif_socket caif af_802154 phonet af_rxrpc bnep bluetooth