Re: ftrace function-graph and interprocessor interrupts

2014-09-25 Thread Steven Rostedt
On Thu, 25 Sep 2014 23:10:31 + "Elliott, Robert (Server Storage)" wrote: > > > > -Original Message- > > From: Steven Rostedt [mailto:rost...@goodmis.org] > ... > > Does, this patch fix it for you? > > > > -- Steve > ... > > > - if (type == TRACE_GRAPH_ENT) > > - ret =

RE: ftrace function-graph and interprocessor interrupts

2014-09-25 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: Steven Rostedt [mailto:rost...@goodmis.org] ... > Does, this patch fix it for you? > > -- Steve ... > - if (type == TRACE_GRAPH_ENT) > - ret = trace_seq_puts(s, "==>"); > - else > + if (trace_flags & TRACE_ITER_LATENCY_FMT) {

Re: ftrace function-graph and interprocessor interrupts

2014-09-25 Thread Steven Rostedt
On Wed, 24 Sep 2014 14:49:41 -0700 Andi Kleen wrote: > "Elliott, Robert (Server Storage)" writes: > > > The function-graph tracer marks some interrupt handler functions > > with ==> and <== labels. > > I'm not sure the marking is really that useful. Isn't it always obvious > f

RE: ftrace function-graph and interprocessor interrupts

2014-09-24 Thread Elliott, Robert (Server Storage)
: Re: ftrace function-graph and interprocessor interrupts > > "Elliott, Robert (Server Storage)" writes: > > > The function-graph tracer marks some interrupt handler functions > > with ==> and <== labels. > > I'm not sure the marki

Re: ftrace function-graph and interprocessor interrupts

2014-09-24 Thread Andi Kleen
"Elliott, Robert (Server Storage)" writes: > The function-graph tracer marks some interrupt handler functions > with ==> and <== labels. I'm not sure the marking is really that useful. Isn't it always obvious from the function names where an interrupt starts/end? -Andi -- a..

ftrace function-graph and interprocessor interrupts

2014-09-24 Thread Elliott, Robert (Server Storage)
The function-graph tracer marks some interrupt handler functions with ==> and <== labels. 10) | sd_setup_read_write_cmnd [sd_mod]() { 10) | scsi_init_io() { 10) |