Re: gadgetfs broken since 7f7f25e8

2015-03-11 Thread Alexander Holler
Am 11.03.2015 um 11:29 schrieb Alexander Holler: Am 07.03.2015 um 12:23 schrieb Alexander Holler: In detail it's only usable once (3.19). When unmounting it throws one or two warnings because of too much puts (kernel/module.c:963, see below). The result is that a subsequent mount afterwards fai

Re: gadgetfs broken since 7f7f25e8

2015-03-11 Thread Alexander Holler
Am 07.03.2015 um 12:23 schrieb Alexander Holler: In detail it's only usable once (3.19). When unmounting it throws one or two warnings because of too much puts (kernel/module.c:963, see below). The result is that a subsequent mount afterwards fails because the old instance is still busy (Resourc

Re: gadgetfs broken since 7f7f25e8

2015-03-10 Thread Felipe Balbi
On Sun, Mar 08, 2015 at 02:35:25PM -0400, Alan Stern wrote: > On Sun, 8 Mar 2015, Al Viro wrote: > > > On Sat, Mar 07, 2015 at 04:08:49PM -0500, Alan Stern wrote: > > > On Sat, 7 Mar 2015, Alexander Holler wrote: > > > > > > > Am 07.03.2015 um 12:23 schrieb Alexander Holler: > > > > > Am 04.03.20

Re: gadgetfs broken since 7f7f25e8

2015-03-08 Thread Al Viro
On Sun, Mar 08, 2015 at 02:35:25PM -0400, Alan Stern wrote: > > FWIW, I've pushed those two fixes in vfs.git#gadget; could I have your > > s-o-b on the ep0 part? See 2b13438 in vfs.git... > > Certainly. > > Signed-off-by: Alan Stern Amended and pushed... -- To unsubscribe from this list: send

Re: gadgetfs broken since 7f7f25e8

2015-03-08 Thread Alan Stern
On Sun, 8 Mar 2015, Al Viro wrote: > On Sat, Mar 07, 2015 at 04:08:49PM -0500, Alan Stern wrote: > > On Sat, 7 Mar 2015, Alexander Holler wrote: > > > > > Am 07.03.2015 um 12:23 schrieb Alexander Holler: > > > > Am 04.03.2015 um 16:31 schrieb Alan Stern: > > > > > > > >> check to see what those

Re: gadgetfs broken since 7f7f25e8

2015-03-08 Thread Al Viro
On Sat, Mar 07, 2015 at 04:08:49PM -0500, Alan Stern wrote: > On Sat, 7 Mar 2015, Alexander Holler wrote: > > > Am 07.03.2015 um 12:23 schrieb Alexander Holler: > > > Am 04.03.2015 um 16:31 schrieb Alan Stern: > > > > > >> check to see what those values actually were. It's easy enough to fix > >

Re: gadgetfs broken since 7f7f25e8

2015-03-07 Thread Alan Stern
On Sat, 7 Mar 2015, Alexander Holler wrote: > Am 07.03.2015 um 12:23 schrieb Alexander Holler: > > Am 04.03.2015 um 16:31 schrieb Alan Stern: > > > >> check to see what those values actually were. It's easy enough to fix > >> up, though; revised patch below. > > > > Thanks, in contrast to the p

Re: gadgetfs broken since 7f7f25e8

2015-03-07 Thread Alexander Holler
Am 07.03.2015 um 21:51 schrieb Al Viro: > On Sat, Mar 07, 2015 at 09:03:51PM +0100, Alexander Holler wrote: >> Am 07.03.2015 um 12:23 schrieb Alexander Holler: >>> Am 04.03.2015 um 16:31 schrieb Alan Stern: >>> check to see what those values actually were. It's easy enough to fix up, tho

Re: gadgetfs broken since 7f7f25e8

2015-03-07 Thread Al Viro
On Sat, Mar 07, 2015 at 09:03:51PM +0100, Alexander Holler wrote: > Am 07.03.2015 um 12:23 schrieb Alexander Holler: > > Am 04.03.2015 um 16:31 schrieb Alan Stern: > > > >> check to see what those values actually were. It's easy enough to fix > >> up, though; revised patch below. > > > > Thanks,

Re: gadgetfs broken since 7f7f25e8

2015-03-07 Thread Alexander Holler
Am 07.03.2015 um 12:23 schrieb Alexander Holler: > Am 04.03.2015 um 16:31 schrieb Alan Stern: > >> check to see what those values actually were. It's easy enough to fix >> up, though; revised patch below. > > Thanks, in contrast to the patch from Al Viro that one applies. And as I've just teste

Re: gadgetfs broken since 7f7f25e8

2015-03-07 Thread Alexander Holler
Am 04.03.2015 um 16:31 schrieb Alan Stern: check to see what those values actually were. It's easy enough to fix up, though; revised patch below. Thanks, in contrast to the patch from Al Viro that one applies. I wonder if the patches in the (vfs-)tree he has used as base might fix some more

Re: gadgetfs broken since 7f7f25e8

2015-03-04 Thread Alan Stern
On Tue, 3 Mar 2015, Al Viro wrote: > On Tue, Mar 03, 2015 at 10:47:14AM -0500, Alan Stern wrote: > > On Tue, 3 Mar 2015, Al Viro wrote: > > > > > Looking at that thing again... why do they need to be dummy? After all, > > > those methods start with get_ready_ep(), which will fail unless we have

Re: gadgetfs broken since 7f7f25e8

2015-03-03 Thread Al Viro
On Tue, Mar 03, 2015 at 10:47:14AM -0500, Alan Stern wrote: > @@ -1279,6 +1284,9 @@ ep0_poll (struct file *fd, poll_table *w > struct dev_data *dev = fd->private_data; > int mask = 0; > > + if (dev->state <= STATE_DEV_OPENED) > + return

Re: gadgetfs broken since 7f7f25e8

2015-03-03 Thread Al Viro
On Tue, Mar 03, 2015 at 10:47:14AM -0500, Alan Stern wrote: > On Tue, 3 Mar 2015, Al Viro wrote: > > > Looking at that thing again... why do they need to be dummy? After all, > > those methods start with get_ready_ep(), which will fail unless we have > > ->state == STATE_EP_ENABLED. So they'd b

Re: gadgetfs broken since 7f7f25e8

2015-03-03 Thread Alan Stern
On Tue, 3 Mar 2015, Al Viro wrote: > Looking at that thing again... why do they need to be dummy? After all, > those methods start with get_ready_ep(), which will fail unless we have > ->state == STATE_EP_ENABLED. So they'd be failing just fine until that > first write() anyway. Let's do the f

Re: gadgetfs broken since 7f7f25e8

2015-03-03 Thread Al Viro
On Mon, Mar 02, 2015 at 02:02:56PM +0100, Alexander Holler wrote: > >I exactly did what you've assumed, I've just fixed f_mode but not the > >already existing races which I haven't introduced. So I was right in not > >sending a patch as would have been blamed for not rewriting everything > >as so

Re: gadgetfs broken since 7f7f25e8

2015-03-02 Thread Alexander Holler
Am 02.03.2015 um 14:02 schrieb Alexander Holler: Am 02.03.2015 um 12:39 schrieb Alexander Holler: Am 02.03.2015 um 11:20 schrieb Al Viro: On Mon, Mar 02, 2015 at 10:13:27AM +0100, Richard Weinberger wrote: On Mon, Mar 2, 2015 at 9:28 AM, Alexander Holler wrote: Hello. Commit 7f7f25e82d54870

Re: gadgetfs broken since 7f7f25e8

2015-03-02 Thread Alexander Holler
Am 02.03.2015 um 12:39 schrieb Alexander Holler: Am 02.03.2015 um 11:20 schrieb Al Viro: On Mon, Mar 02, 2015 at 10:13:27AM +0100, Richard Weinberger wrote: On Mon, Mar 2, 2015 at 9:28 AM, Alexander Holler wrote: Hello. Commit 7f7f25e82d54870df24d415a7007fbd327da027b (introduced with 3.16) b

Re: gadgetfs broken since 7f7f25e8

2015-03-02 Thread Alexander Holler
Am 02.03.2015 um 11:20 schrieb Al Viro: On Mon, Mar 02, 2015 at 10:13:27AM +0100, Richard Weinberger wrote: On Mon, Mar 2, 2015 at 9:28 AM, Alexander Holler wrote: Hello. Commit 7f7f25e82d54870df24d415a7007fbd327da027b (introduced with 3.16) broke dynamic changing of file_operations->[read|wr

Re: gadgetfs broken since 7f7f25e8

2015-03-02 Thread Al Viro
On Mon, Mar 02, 2015 at 10:13:27AM +0100, Richard Weinberger wrote: > On Mon, Mar 2, 2015 at 9:28 AM, Alexander Holler wrote: > > Hello. > > > > Commit 7f7f25e82d54870df24d415a7007fbd327da027b (introduced with 3.16) broke > > dynamic changing of file_operations->[read|write]. > > > > At least gadg

Re: gadgetfs broken since 7f7f25e8

2015-03-02 Thread Richard Weinberger
On Mon, Mar 2, 2015 at 9:28 AM, Alexander Holler wrote: > Hello. > > Commit 7f7f25e82d54870df24d415a7007fbd327da027b (introduced with 3.16) broke > dynamic changing of file_operations->[read|write]. > > At least gadgetfs is a victim. > > Feel free to ask me off-list for a patch as I don't want to

gadgetfs broken since 7f7f25e8

2015-03-02 Thread Alexander Holler
Hello. Commit 7f7f25e82d54870df24d415a7007fbd327da027b (introduced with 3.16) broke dynamic changing of file_operations->[read|write]. At least gadgetfs is a victim. Feel free to ask me off-list for a patch as I don't want to end up in annoying discussions on Linux kernel lists anymore. Al