Re: general protection fault in debugfs_create_files

2019-02-01 Thread Kees Cook
On Thu, Jan 31, 2019 at 7:53 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:02495e76ded5 Add linux-next specific files for 20190130 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=172ed528c0 > kernel config:

Re: general protection fault in debugfs_create_files

2019-01-30 Thread Greg Kroah-Hartman
On Thu, Jan 31, 2019 at 02:34:56PM +0900, Tetsuo Handa wrote: > Hello, again. > > syzbot is hitting a similar crash due to debugfs_create_dir() returning > -EEXIST. > Should debugfs_create_dir() return NULL as well? Or should the caller use > IS_ERR_OR_NULL() ? > > --- a/block/blk-mq-debugfs.c

Re: general protection fault in debugfs_create_files

2019-01-30 Thread Tetsuo Handa
Hello, again. syzbot is hitting a similar crash due to debugfs_create_dir() returning -EEXIST. Should debugfs_create_dir() return NULL as well? Or should the caller use IS_ERR_OR_NULL() ? --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -861,6 +861,8 @@ int

general protection fault in debugfs_create_files

2019-01-30 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:02495e76ded5 Add linux-next specific files for 20190130 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=172ed528c0 kernel config: https://syzkaller.appspot.com/x/.config?x=a2b2e9c0bc43c14d