Re: generic_file_write change in 2.4.0-ac8

2001-01-12 Thread Chris Mason
On Friday, January 12, 2001 04:30:44 PM -0500 Alexander Viro <[EMAIL PROTECTED]> wrote: > > > On Fri, 12 Jan 2001, Chris Mason wrote: > >> >> Hi guys, >> >> This code for generic_file_write calls vmtruncate without i_sem held. Is >> that intentional? It should cause problems for reiserfs

Re: generic_file_write change in 2.4.0-ac8

2001-01-12 Thread Alexander Viro
On Fri, 12 Jan 2001, Chris Mason wrote: > > Hi guys, > > This code for generic_file_write calls vmtruncate without i_sem held. Is > that intentional? It should cause problems for reiserfs at least... Erm... generic_file_write() grabs i_sem upon entry and drops it on exit. This call of vmtr

generic_file_write change in 2.4.0-ac8

2001-01-12 Thread Chris Mason
Hi guys, This code for generic_file_write calls vmtruncate without i_sem held. Is that intentional? It should cause problems for reiserfs at least... -chris diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.4.0/mm/filemap.c linux.ac/mm/filemap.c --- linux-2.4.0/mm/filema