Re: get_unmapped_area && in_ia32_syscall (Was: [PATCH] uprobes/x86: fix detection of 32-bit user mode)

2019-08-28 Thread Oleg Nesterov
On 08/28, Dmitry Safonov wrote: > > > On 8/27/19 3:00 PM, Oleg Nesterov wrote: > > [..] > >> But to remind, there is another problem with in_ia32_syscall() && uprobes. > >> > >> get_unmapped_area() paths use in_ia32_syscall() and this is wrong in case > >> when the caller is xol_add_vma(), in this

Re: get_unmapped_area && in_ia32_syscall (Was: [PATCH] uprobes/x86: fix detection of 32-bit user mode)

2019-08-27 Thread Dmitry Safonov
-Cc my old @virtuozzo email. Previously it just ignored emails and now sends those ugly html replies. Sorry about that - I've updated .mailmap now. On 8/27/19 6:03 PM, Dmitry Safonov wrote: > Hi Oleg, > > On 8/27/19 3:00 PM, Oleg Nesterov wrote: > [..] >> But to remind, there is another problem

Re: get_unmapped_area && in_ia32_syscall (Was: [PATCH] uprobes/x86: fix detection of 32-bit user mode)

2019-08-27 Thread Dmitry Safonov
Hi Oleg, On 8/27/19 3:00 PM, Oleg Nesterov wrote: [..] > But to remind, there is another problem with in_ia32_syscall() && uprobes. > > get_unmapped_area() paths use in_ia32_syscall() and this is wrong in case > when the caller is xol_add_vma(), in this case TS_COMPAT won't be set.> > Usually

get_unmapped_area && in_ia32_syscall (Was: [PATCH] uprobes/x86: fix detection of 32-bit user mode)

2019-08-27 Thread Oleg Nesterov
Sorry for delay, vacation. On 08/24, Thomas Gleixner wrote: > > And sadly this was already mentioned here: > >8faaed1b9f50 ("uprobes/x86: Introduce sizeof_long(), cleanup > adjust_ret_addr() and arch_uretprobe_hijack_return_addr()") Yes, and I even posted a similar fix but forgot to send it