Re: gfs2_fh_to_parent() array overflow

2008-02-14 Thread Steven Whitehouse
Hi, On Wed, 2008-02-13 at 23:31 +0200, Adrian Bunk wrote: > On Mon, Oct 29, 2007 at 09:11:21AM +, Steven Whitehouse wrote: > > Hi, > > > > On Sat, 2007-10-27 at 23:00 +0200, Christoph Hellwig wrote: > > > On Wed, Oct 24, 2007 at 06:26:26PM +0200, Adrian Bunk wrote: > > > > The Coverity checke

Re: gfs2_fh_to_parent() array overflow

2008-02-13 Thread Adrian Bunk
On Mon, Oct 29, 2007 at 09:11:21AM +, Steven Whitehouse wrote: > Hi, > > On Sat, 2007-10-27 at 23:00 +0200, Christoph Hellwig wrote: > > On Wed, Oct 24, 2007 at 06:26:26PM +0200, Adrian Bunk wrote: > > > The Coverity checker spotted the following array overflow caused by > > > commit 34c0d1542

Re: gfs2_fh_to_parent() array overflow

2007-10-29 Thread Steven Whitehouse
Hi, On Sat, 2007-10-27 at 23:00 +0200, Christoph Hellwig wrote: > On Wed, Oct 24, 2007 at 06:26:26PM +0200, Adrian Bunk wrote: > > The Coverity checker spotted the following array overflow caused by > > commit 34c0d154243dd913c5690ae6ceb9557017429b9c: > > The line is a left-over from times when g

Re: gfs2_fh_to_parent() array overflow

2007-10-27 Thread Christoph Hellwig
On Wed, Oct 24, 2007 at 06:26:26PM +0200, Adrian Bunk wrote: > The Coverity checker spotted the following array overflow caused by > commit 34c0d154243dd913c5690ae6ceb9557017429b9c: The line is a left-over from times when gfs stored the mode of the inode in the file handle. It can simply be delet

gfs2_fh_to_parent() array overflow

2007-10-24 Thread Adrian Bunk
The Coverity checker spotted the following array overflow caused by commit 34c0d154243dd913c5690ae6ceb9557017429b9c: include/linux/exportfs.h contains: <-- snip --> ... struct fid { ... __u32 raw[6]; }; }; <-- snip --> fs/gfs2/ops_export.c contains: <-- snip --