Re: gpio-pxa: getting GPIOs by devicetree phandle broken

2015-02-09 Thread Alexandre Courbot
On Tue, Feb 10, 2015 at 2:38 AM, Robert Jarzmik wrote: > Tyler Hall writes: > >>> The issue with multiple gpiochips per of-node could be worked around as >>> followed I believe, comments? >>> >>> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c >>> index 08261f2..43984ab 100644

Re: gpio-pxa: getting GPIOs by devicetree phandle broken

2015-02-09 Thread Robert Jarzmik
Tyler Hall writes: >> The issue with multiple gpiochips per of-node could be worked around as >> followed I believe, comments? >> >> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c >> index 08261f2..43984ab 100644 >> --- a/drivers/gpio/gpiolib-of.c >> +++ b/drivers/gpio/gpioli

Re: gpio-pxa: getting GPIOs by devicetree phandle broken

2015-02-09 Thread Tyler Hall
> The issue with multiple gpiochips per of-node could be worked around as > followed I believe, comments? > > diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c > index 08261f2..43984ab 100644 > --- a/drivers/gpio/gpiolib-of.c > +++ b/drivers/gpio/gpiolib-of.c > @@ -47,11 +47,12 @@

RE: gpio-pxa: getting GPIOs by devicetree phandle broken

2015-02-09 Thread Holmberg, Hans
> > 1. Require child nodes in DT for each bank > > This would break DT compatibility. > > > 2. Refactor gpio-pxa to only register one gpiochip > > Sounds better, especially since this would reflect the hardware more > accurately. One DT node should translate into one GPIO chip. The problem is >

Re: gpio-pxa: getting GPIOs by devicetree phandle broken

2015-02-09 Thread Robert Jarzmik
Alexandre Courbot writes: > Adding Robert who reported the same thing. > > On Sat, Feb 7, 2015 at 6:28 AM, Tyler Hall wrote: >> 1. Require child nodes in DT for each bank > > This would break DT compatibility. Agreed. > >> 2. Refactor gpio-pxa to only register one gpiochip > > Sounds better, es

Re: gpio-pxa: getting GPIOs by devicetree phandle broken

2015-02-08 Thread Alexandre Courbot
Adding Robert who reported the same thing. On Sat, Feb 7, 2015 at 6:28 AM, Tyler Hall wrote: > Hi, > > Commit 7b8792b ("gpiolib: of: Correct error handling in > of_get_named_gpiod_flags") seems to break the ability to use DT > bindings to reference this driver's GPIOs by phandle for banks above >

gpio-pxa: getting GPIOs by devicetree phandle broken

2015-02-06 Thread Tyler Hall
Hi, Commit 7b8792b ("gpiolib: of: Correct error handling in of_get_named_gpiod_flags") seems to break the ability to use DT bindings to reference this driver's GPIOs by phandle for banks above the first. The issue is that gpio-pxa registers multiple gpio chips - one for each bank - but they're al