Re: hashed spinlocks

2005-07-31 Thread Daniel Walker
On Sun, 2005-07-31 at 12:11 -0700, David S. Miller wrote: > From: Daniel Walker <[EMAIL PROTECTED]> > Date: Sun, 31 Jul 2005 12:06:47 -0700 > > > The ifdef that switched between the two rt_hash_lock_addr() switched on > > for CONFIG_SMP or CONFIG_DEBUG_SPINLOCK . I was compiling UP , so I > > didn

Re: hashed spinlocks

2005-07-31 Thread David S. Miller
From: Daniel Walker <[EMAIL PROTECTED]> Date: Sun, 31 Jul 2005 12:06:47 -0700 > The ifdef that switched between the two rt_hash_lock_addr() switched on > for CONFIG_SMP or CONFIG_DEBUG_SPINLOCK . I was compiling UP , so I > didn't get either. > > Seems like you'll need to have an rt_hash_lock(slo

Re: hashed spinlocks

2005-07-31 Thread Daniel Walker
On Sun, 2005-07-31 at 11:46 -0700, David S. Miller wrote: > From: Daniel Walker <[EMAIL PROTECTED]> > Date: Sun, 31 Jul 2005 09:27:55 -0700 > > > >From 2.6.13-rc4 this hunk > > > > +#else > > +# define rt_hash_lock_addr(slot) NULL > > +# define rt_hash_lock_init() > > +#endif > > > > Doesn't wor

Re: hashed spinlocks

2005-07-31 Thread David S. Miller
From: Daniel Walker <[EMAIL PROTECTED]> Date: Sun, 31 Jul 2005 09:27:55 -0700 > >From 2.6.13-rc4 this hunk > > +#else > +# define rt_hash_lock_addr(slot) NULL > +# define rt_hash_lock_init() > +#endif > > Doesn't work with the following, > > + spin_unlock(rt_hash_lock_addr(i)); >

hashed spinlocks

2005-07-31 Thread Daniel Walker
>From 2.6.13-rc4 this hunk +#else +# define rt_hash_lock_addr(slot) NULL +# define rt_hash_lock_init() +#endif Doesn't work with the following, + spin_unlock(rt_hash_lock_addr(i)); Cause your spin locking a NULL .. I would give a patch, but I'm not sure what should be done in t