Re: i2c: xiic: Strange clk_prepare_enable() in xiic_i2c_remove()

2016-12-16 Thread Shubhrajyoti Datta
On Sat, Dec 17, 2016 at 3:24 AM, Alexey Khoroshilov wrote: > Dear Shubhrajyoti, > > Looking at 36ecbcab84d0 ("i2c: xiic: Implement power management") > it is not clear why clk_prepare_enable(i2c->clk) is required in > xiic_i2c_remove()? 834 ret = clk_prepare_enable(i2c->clk); 835

i2c: xiic: Strange clk_prepare_enable() in xiic_i2c_remove()

2016-12-16 Thread Alexey Khoroshilov
Dear Shubhrajyoti, Looking at 36ecbcab84d0 ("i2c: xiic: Implement power management") it is not clear why clk_prepare_enable(i2c->clk) is required in xiic_i2c_remove()? It is enabled in xiic_i2c_probe() and disabled/enabled in cdns_i2c_runtime_suspend()/cdns_i2c_runtime_resume(). Could you please