Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-09-08 Thread Jean Delvare
Hi Alexander, Sorry for the late reply again. On Thu, 30 Aug 2012 09:49:52 +0200, Alexander Stein wrote: > On Wednesday 29 August 2012 20:40:31, Jean Delvare wrote: > > Note that there was an assumption at the time the code was written, > > that there was no need or reason to reserve a static I2C

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-30 Thread Feng Tang
Hi Alexander, On Thu, 30 Aug 2012 13:08:09 +0200 Alexander Stein wrote: > On Thursday 30 August 2012 17:19:15, Feng Tang wrote: > > > IMO the i2c_register_board_info only works in quite static setups. > > > Especially with I2C-Busses attached to hotplugable PCI devices this way > > > doesn't w

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-30 Thread Alexander Stein
On Thursday 30 August 2012 17:19:15, Feng Tang wrote: > > IMO the i2c_register_board_info only works in quite static setups. > > Especially with I2C-Busses attached to hotplugable PCI devices this way > > doesn't work reliable any more. > > The device come and go dynamically so you can't assume f

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-30 Thread Feng Tang
Hi Alexander, On Thu, 30 Aug 2012 09:49:52 +0200 Alexander Stein wrote: > > > > Whenever you call i2c_register_board_info(), every I2C bus number > > referenced in the I2C device list passed as a parameter is reserved for > > static I2C bus numbers, dynamic I2C bus numbers will never overlap. >

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-30 Thread Feng Tang
Hi Jean, Thanks for the explanation and bring up some history background of those i2c core APIs! It was several month ago that I maintained a Tizen kernel for Intel EG20T based platforms when I cooked the patch, so loop in current maintainer Artem. On Wed, 29 Aug 2012 20:40:31 +0200 Jean Delva

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-30 Thread Alexander Stein
Hello Jean, On Wednesday 29 August 2012 20:40:31, Jean Delvare wrote: > Looks like what media and sound drivers are/were doing to assign fixed > numbers to their devices. But my understanding is that this is a legacy > thing and nobody should need to use that any longer. Adding this to all > or ev

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-29 Thread Jean Delvare
Hi guys, Sorry for joining the discussion a little late, I was on vacation. On Thu, 23 Aug 2012 16:28:52 +0800, Feng Tang wrote: > On Wed, 22 Aug 2012 11:17:51 +0200 > Alexander Stein wrote: > > Am Mittwoch, 22. August 2012, 16:04:39 schrieb Feng Tang: > > > > Why use a fixed one? Give the drive

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-23 Thread Feng Tang
Hi, On Wed, 22 Aug 2012 11:17:51 +0200 Alexander Stein wrote: > Hello, > > Am Mittwoch, 22. August 2012, 16:04:39 schrieb Feng Tang: > > > Why use a fixed one? Give the driver (and maybe every i2c bus driver) a > > > parameter which sets the base bus number it should use. > > > E.g. i2c-eg20t.

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-22 Thread Alexander Stein
Hello, Am Mittwoch, 22. August 2012, 16:04:39 schrieb Feng Tang: > > Why use a fixed one? Give the driver (and maybe every i2c bus driver) a > > parameter which sets the base bus number it should use. > > E.g. i2c-eg20t.base-bus-num=2 so it will register the bus numbers starting > > from 2. If t

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-22 Thread Feng Tang
Hi Alexander, On Wed, 22 Aug 2012 09:57:07 +0200 Alexander Stein wrote: > Hello, > > On Wednesday 22 August 2012 15:29:18, Feng Tang wrote: > > On Wed, 22 Aug 2012 08:30:35 +0200 > > Alexander Stein wrote: > > > > > Hello, > > > > > > I just noticed the 3.4 linux kernel fails to sucessfully

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-22 Thread Alexander Stein
Hello, On Wednesday 22 August 2012 15:29:18, Feng Tang wrote: > On Wed, 22 Aug 2012 08:30:35 +0200 > Alexander Stein wrote: > > > Hello, > > > > I just noticed the 3.4 linux kernel fails to sucessfully probe the > > i2c-eg20t > > driver. I returns with EBUSY error. It worked on the 3.0 kernel

Re: i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-22 Thread Feng Tang
On Wed, 22 Aug 2012 08:30:35 +0200 Alexander Stein wrote: > Hello, > > I just noticed the 3.4 linux kernel fails to sucessfully probe the i2c-eg20t > driver. I returns with EBUSY error. It worked on the 3.0 kernel. To my view > it > is caused the commit 07e8a51ff68353e01d795cceafbac9f54c49132

i2c-eg20t: regression since i2c_add_numbered_adapter change

2012-08-21 Thread Alexander Stein
Hello, I just noticed the 3.4 linux kernel fails to sucessfully probe the i2c-eg20t driver. I returns with EBUSY error. It worked on the 3.0 kernel. To my view it is caused the commit 07e8a51ff68353e01d795cceafbac9f54c49132b ( i2c-eg20t: use i2c_add_numbered_adapter to get a fixed bus number).