Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-25 Thread zhuyj
On 04/24/2014 01:24 PM, Willy Tarreau wrote: On Thu, Apr 24, 2014 at 10:10:08AM +0800, zhuyj wrote: On 04/23/2014 07:41 PM, Ben Hutchings wrote: On Wed, 2014-04-23 at 15:48 +0800, zhuyj wrote: On 04/23/2014 01:53 AM, Ben Hutchings wrote: [...] For what it's worth, I would recommend against a

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-23 Thread Willy Tarreau
On Thu, Apr 24, 2014 at 10:10:08AM +0800, zhuyj wrote: > On 04/23/2014 07:41 PM, Ben Hutchings wrote: > >On Wed, 2014-04-23 at 15:48 +0800, zhuyj wrote: > >>On 04/23/2014 01:53 AM, Ben Hutchings wrote: > >[...] > >>>For what it's worth, I would recommend against applying this. I don't > >>>think e

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-23 Thread zhuyj
On 04/23/2014 07:41 PM, Ben Hutchings wrote: On Wed, 2014-04-23 at 15:48 +0800, zhuyj wrote: On 04/23/2014 01:53 AM, Ben Hutchings wrote: [...] For what it's worth, I would recommend against applying this. I don't think even Red Hat has backported the VLAN changes, and they have been quite ag

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-23 Thread Ben Hutchings
On Wed, 2014-04-23 at 15:48 +0800, zhuyj wrote: > On 04/23/2014 01:53 AM, Ben Hutchings wrote: [...] > > For what it's worth, I would recommend against applying this. I don't > > think even Red Hat has backported the VLAN changes, and they have been > > quite aggressive about backporting features

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-23 Thread zhuyj
On 04/23/2014 01:53 AM, Ben Hutchings wrote: On Thu, 2014-04-17 at 07:02 +0200, Willy Tarreau wrote: Hi Zhu, On Thu, Apr 17, 2014 at 11:35:58AM +0800, zhuyj wrote: Hi, all In kernel 2.6.x, linux depends on nic vlan hardware acceleration to insert/extract vlan tag. Hi, Ben Thanks for your re

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-22 Thread Ben Hutchings
On Thu, 2014-04-17 at 07:02 +0200, Willy Tarreau wrote: > Hi Zhu, > > On Thu, Apr 17, 2014 at 11:35:58AM +0800, zhuyj wrote: > > Hi, all > > > > In kernel 2.6.x, linux depends on nic vlan hardware acceleration to > > insert/extract > > vlan tag. This is a gross overstatement. The problem I kno

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-19 Thread zhuyj
On 04/17/2014 01:02 PM, Willy Tarreau wrote: Hi Zhu, On Thu, Apr 17, 2014 at 11:35:58AM +0800, zhuyj wrote: Hi, all In kernel 2.6.x, linux depends on nic vlan hardware acceleration to insert/extract vlan tag. In this scene, in kernel 2.6.x _ A

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-17 Thread Willy Tarreau
On Thu, Apr 17, 2014 at 09:52:41PM +0800, zhuyj wrote: > Although the maintainer will not merge these 2 patches, I still fix the > mistakes in these 2 patches. Now the latest patches are in attachment. Just for the record, I didn't say I "will not" merge them but that I will not "without an Acke

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-17 Thread zhuyj
Although the maintainer will not merge these 2 patches, I still fix the mistakes in these 2 patches. Now the latest patches are in attachment. Maybe these patches can help others. The latest patches fix mistakes in rx stats. Best Regards! Zhu Yanjun On 04/17/2014 11:35 AM, zhuyj wrote: Hi, al

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-16 Thread zhuyj
Hi, Jaso Would you like to code review these 2 patches? Thanks a lot. Zhu Yanjun On 04/17/2014 11:35 AM, zhuyj wrote: Hi, all In kernel 2.6.x, linux depends on nic vlan hardware acceleration to insert/extract vlan tag. In this scene, in kernel 2.6.x _

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-16 Thread zhuyj
On 04/17/2014 01:02 PM, Willy Tarreau wrote: Hi Zhu, On Thu, Apr 17, 2014 at 11:35:58AM +0800, zhuyj wrote: Hi, all In kernel 2.6.x, linux depends on nic vlan hardware acceleration to insert/extract vlan tag. In this scene, in kernel 2.6.x _ A

Re: in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-16 Thread Willy Tarreau
Hi Zhu, On Thu, Apr 17, 2014 at 11:35:58AM +0800, zhuyj wrote: > Hi, all > > In kernel 2.6.x, linux depends on nic vlan hardware acceleration to > insert/extract > vlan tag. In this scene, in kernel 2.6.x > > _ > A | | B|| C >

in kernel 2.6.x, tun/tap nic supports vlan packets

2014-04-16 Thread zhuyj
Hi, all In kernel 2.6.x, linux depends on nic vlan hardware acceleration to insert/extract vlan tag. In this scene, in kernel 2.6.x _ A | | B|| C vlan packets-->| tap |->|vlan nic|---> |_| |___