Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Paul E. McKenney
On Sat, Jun 08, 2019 at 10:50:51AM -0700, Linus Torvalds wrote: > On Sat, Jun 8, 2019 at 10:42 AM Linus Torvalds > wrote: > > > > There are no atomic rmw sequences that have reasonable performance for > > the bitfield updates themselves. > > Note that this is purely about the writing side. Reads

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Paul E. McKenney
On Sat, Jun 08, 2019 at 10:42:41AM -0700, Linus Torvalds wrote: > On Sat, Jun 8, 2019 at 8:32 AM Paul E. McKenney wrote: > > > > On Fri, Jun 07, 2019 at 09:19:42AM -0700, Linus Torvalds wrote: > > > > > > - bitfields obviously do need locks. 'char' does not. > > > > > > If there's somebody who

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Linus Torvalds
On Sat, Jun 8, 2019 at 10:42 AM Linus Torvalds wrote: > > There are no atomic rmw sequences that have reasonable performance for > the bitfield updates themselves. Note that this is purely about the writing side. Reads of bitfield values can be (and generally _should_ be) atomic, and hopefully

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Linus Torvalds
On Sat, Jun 8, 2019 at 8:32 AM Paul E. McKenney wrote: > > On Fri, Jun 07, 2019 at 09:19:42AM -0700, Linus Torvalds wrote: > > > > - bitfields obviously do need locks. 'char' does not. > > > > If there's somebody who really notices the alpha issue in PRACTICE, we > > can then bother to fix it.

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-08 Thread Paul E. McKenney
On Fri, Jun 07, 2019 at 09:19:42AM -0700, Linus Torvalds wrote: > On Fri, Jun 7, 2019 at 8:26 AM Eric Dumazet wrote: > > > > There is common knowledge among us programmers that bit fields > > (or bool) sharing a common 'word' need to be protected > > with a common lock. > > > > Converting all bit

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-07 Thread Linus Torvalds
On Fri, Jun 7, 2019 at 8:26 AM Eric Dumazet wrote: > > There is common knowledge among us programmers that bit fields > (or bool) sharing a common 'word' need to be protected > with a common lock. > > Converting all bit fields to plain int/long would be quite a waste of memory. Yeah, and we

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-07 Thread Eric Dumazet
On 6/7/19 8:32 AM, Herbert Xu wrote: > On Fri, Jun 07, 2019 at 08:26:12AM -0700, Eric Dumazet wrote: >> >> There is common knowledge among us programmers that bit fields >> (or bool) sharing a common 'word' need to be protected >> with a common lock. >> >> Converting all bit fields to plain

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-07 Thread Herbert Xu
On Fri, Jun 07, 2019 at 08:26:12AM -0700, Eric Dumazet wrote: > > There is common knowledge among us programmers that bit fields > (or bool) sharing a common 'word' need to be protected > with a common lock. > > Converting all bit fields to plain int/long would be quite a waste of memory. > > In

Re: inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-07 Thread Eric Dumazet
On 6/7/19 7:09 AM, Herbert Xu wrote: > On Tue, Jun 04, 2019 at 09:04:55AM -0700, Linus Torvalds wrote: >> >> In fact, the alpha port was always subtly buggy exactly because of the >> "byte write turns into a read-and-masked-write", even if I don't think >> anybody ever noticed (we did fix cases

inet: frags: Turn fqdir->dead into an int for old Alphas

2019-06-07 Thread Herbert Xu
On Tue, Jun 04, 2019 at 09:04:55AM -0700, Linus Torvalds wrote: > > In fact, the alpha port was always subtly buggy exactly because of the > "byte write turns into a read-and-masked-write", even if I don't think > anybody ever noticed (we did fix cases where people _did_ notice, > though, and we