Re: input.c: start on release

2007-02-24 Thread Pete Zaitcev
On Sat, 24 Feb 2007 11:57:07 -0500, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > To tell you the truth, all I really want is to hold a static mutex > > across a call to input_close_device(). Can I do that? > > Are you trying to fix locking in mousedev? Yes. -- Pete - To unsubscribe from this

Re: input.c: start on release

2007-02-24 Thread Dmitry Torokhov
On Friday 23 February 2007 19:44, Pete Zaitcev wrote: > On Fri, 23 Feb 2007 10:06:14 -0500, "Dmitry Torokhov" <[EMAIL PROTECTED]> > wrote: > > On 2/23/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > > > void input_release_device(struct input_handle *handle) > > > { > > > > > >if

Re: input.c: start on release

2007-02-24 Thread Dmitry Torokhov
On Friday 23 February 2007 19:44, Pete Zaitcev wrote: On Fri, 23 Feb 2007 10:06:14 -0500, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 2/23/07, Pete Zaitcev [EMAIL PROTECTED] wrote: void input_release_device(struct input_handle *handle) { if (handle-handler-start)

Re: input.c: start on release

2007-02-24 Thread Pete Zaitcev
On Sat, 24 Feb 2007 11:57:07 -0500, Dmitry Torokhov [EMAIL PROTECTED] wrote: To tell you the truth, all I really want is to hold a static mutex across a call to input_close_device(). Can I do that? Are you trying to fix locking in mousedev? Yes. -- Pete - To unsubscribe from this list:

Re: input.c: start on release

2007-02-23 Thread Pete Zaitcev
On Fri, 23 Feb 2007 10:06:14 -0500, "Dmitry Torokhov" <[EMAIL PROTECTED]> wrote: > On 2/23/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > void input_release_device(struct input_handle *handle) > > { > > > >if (handle->handler->start) > >

Re: input.c: start on release

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Pete Zaitcev <[EMAIL PROTECTED]> wrote: Here's a curious code I found in drivers/input/input.c (2.6.21-rc1): void input_release_device(struct input_handle *handle) { if (handle->handler->start) handle->handler->start(handle); } Is the above supposed to be

Re: input.c: start on release

2007-02-23 Thread Dmitry Torokhov
On 2/23/07, Pete Zaitcev [EMAIL PROTECTED] wrote: Here's a curious code I found in drivers/input/input.c (2.6.21-rc1): void input_release_device(struct input_handle *handle) { if (handle-handler-start) handle-handler-start(handle); } Is the above supposed to be this

Re: input.c: start on release

2007-02-23 Thread Pete Zaitcev
On Fri, 23 Feb 2007 10:06:14 -0500, Dmitry Torokhov [EMAIL PROTECTED] wrote: On 2/23/07, Pete Zaitcev [EMAIL PROTECTED] wrote: void input_release_device(struct input_handle *handle) { if (handle-handler-start) handle-handler-start(handle); It should be

input.c: start on release

2007-02-22 Thread Pete Zaitcev
Here's a curious code I found in drivers/input/input.c (2.6.21-rc1): void input_release_device(struct input_handle *handle) { if (handle->handler->start) handle->handler->start(handle); } Is the above supposed to be this way, or you meant ->stop here? The commit

input.c: start on release

2007-02-22 Thread Pete Zaitcev
Here's a curious code I found in drivers/input/input.c (2.6.21-rc1): void input_release_device(struct input_handle *handle) { if (handle-handler-start) handle-handler-start(handle); } Is the above supposed to be this way, or you meant -stop here? The commit comment