Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-07 Thread Gleb Natapov
On Mon, Jan 06, 2014 at 09:18:44AM -0800, Dirk Brandewie wrote: > On 01/03/2014 02:06 PM, Paolo Bonzini wrote: > >Il 03/01/2014 21:00, Dirk Brandewie ha scritto: > >>+case MSR_IA32_MPERF: > >>+case MSR_IA32_APERF: > > > OK I will spin the patch to only add MSR_PLATFORM_INFO. > > >These sho

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-06 Thread Dirk Brandewie
On 01/06/2014 03:37 AM, Rafael J. Wysocki wrote: On Monday, January 06, 2014 12:20:32 PM Paolo Bonzini wrote: Il 04/01/2014 22:38, Rafael J. Wysocki ha scritto: On Saturday, January 04, 2014 07:48:13 PM Gleb Natapov wrote: On Sat, Jan 04, 2014 at 06:38:59PM +0100, Paolo Bonzini wrote: Il 04/0

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-06 Thread Dirk Brandewie
On 01/03/2014 02:06 PM, Paolo Bonzini wrote: Il 03/01/2014 21:00, Dirk Brandewie ha scritto: +case MSR_IA32_MPERF: +case MSR_IA32_APERF: OK I will spin the patch to only add MSR_PLATFORM_INFO. These should never be accessed. A KVM VM will always have CPUID[06H].ECX = 0, and the Int

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-06 Thread Rafael J. Wysocki
On Monday, January 06, 2014 12:20:32 PM Paolo Bonzini wrote: > Il 04/01/2014 22:38, Rafael J. Wysocki ha scritto: > > On Saturday, January 04, 2014 07:48:13 PM Gleb Natapov wrote: > >> On Sat, Jan 04, 2014 at 06:38:59PM +0100, Paolo Bonzini wrote: > >>> Il 04/01/2014 15:38, Rafael J. Wysocki ha scr

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-06 Thread Paolo Bonzini
Il 04/01/2014 22:38, Rafael J. Wysocki ha scritto: > On Saturday, January 04, 2014 07:48:13 PM Gleb Natapov wrote: >> On Sat, Jan 04, 2014 at 06:38:59PM +0100, Paolo Bonzini wrote: >>> Il 04/01/2014 15:38, Rafael J. Wysocki ha scritto: Well, it's just a sanity check and it makes the problem go

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-04 Thread Rafael J. Wysocki
On Saturday, January 04, 2014 07:48:13 PM Gleb Natapov wrote: > On Sat, Jan 04, 2014 at 06:38:59PM +0100, Paolo Bonzini wrote: > > Il 04/01/2014 15:38, Rafael J. Wysocki ha scritto: > > > Well, it's just a sanity check and it makes the problem go away for the > > > reporter. > > > > > >> > Your p

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-04 Thread Gleb Natapov
On Sat, Jan 04, 2014 at 06:38:59PM +0100, Paolo Bonzini wrote: > Il 04/01/2014 15:38, Rafael J. Wysocki ha scritto: > > Well, it's just a sanity check and it makes the problem go away for the > > reporter. > > > >> > Your patch is welcome but perhaps it should have a WARN_ON too. > > It has been

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-04 Thread Paolo Bonzini
Il 04/01/2014 15:38, Rafael J. Wysocki ha scritto: > Well, it's just a sanity check and it makes the problem go away for the > reporter. > >> > Your patch is welcome but perhaps it should have a WARN_ON too. > It has been pulled in already, so the WARN_ON() can only be added via a > separate > p

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-04 Thread Rafael J. Wysocki
On Saturday, January 04, 2014 09:35:58 AM Paolo Bonzini wrote: > Il 03/01/2014 23:46, Rafael J. Wysocki ha scritto: > > Well, fixing the KVM bug is surely welcome. > > > > That said, adding checks to ensure that your assumptions are valid is rarely > > wrong, especially if they are done once per k

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-04 Thread Paolo Bonzini
Il 03/01/2014 23:46, Rafael J. Wysocki ha scritto: > Well, fixing the KVM bug is surely welcome. > > That said, adding checks to ensure that your assumptions are valid is rarely > wrong, especially if they are done once per kernel boot. And the kernel only > should panic if it cannot continue to

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-03 Thread Rafael J. Wysocki
On Friday, January 03, 2014 08:04:36 PM Gleb Natapov wrote: > On Fri, Jan 03, 2014 at 09:30:28AM -0800, Dirk Brandewie wrote: > > Hi All, > > > > Sorry for being late to the party but I just got back from vacation. > > > > There is something deeply wrong here. We should have never gotten to > >

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-03 Thread Paolo Bonzini
Il 03/01/2014 21:00, Dirk Brandewie ha scritto: > +case MSR_IA32_MPERF: > +case MSR_IA32_APERF: These should never be accessed. A KVM VM will always have CPUID[06H].ECX = 0, and the Intel manual says that the MSRs are only present if CPUID returns that value with bit 0 set. I think the a

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-03 Thread Dirk Brandewie
On 01/03/2014 10:04 AM, Gleb Natapov wrote: On Fri, Jan 03, 2014 at 09:30:28AM -0800, Dirk Brandewie wrote: Hi All, Sorry for being late to the party but I just got back from vacation. There is something deeply wrong here. We should have never gotten to intel_pstate_init_cpu(). The VM had to

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-03 Thread Gleb Natapov
On Fri, Jan 03, 2014 at 09:30:28AM -0800, Dirk Brandewie wrote: > Hi All, > > Sorry for being late to the party but I just got back from vacation. > > There is something deeply wrong here. We should have never gotten to > intel_pstate_init_cpu(). The VM had to have returned value from the read

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2014-01-03 Thread Dirk Brandewie
Hi All, Sorry for being late to the party but I just got back from vacation. There is something deeply wrong here. We should have never gotten to intel_pstate_init_cpu(). The VM had to have returned value from the read of the max pstate at driver init time and 0 when the CPU was being brought

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-30 Thread Rafael J. Wysocki
On Monday, December 30, 2013 03:58:43 PM Kashyap Chamarthy wrote: > On 12/29/2013 04:04 PM, Rafael J. Wysocki wrote: > > On Sunday, December 29, 2013 01:12:18 PM Kashyap Chamarthy wrote: > >> [. . .] > >> > Here's host dmesg: https://bugzilla.kernel.org/attachment.cgi?id=119751 > > >>

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-30 Thread Kashyap Chamarthy
On 12/29/2013 04:04 PM, Rafael J. Wysocki wrote: > On Sunday, December 29, 2013 01:12:18 PM Kashyap Chamarthy wrote: >> [. . .] >> Here's host dmesg: https://bugzilla.kernel.org/attachment.cgi?id=119751 >> Can you ftrace the failure? Can try, need some time (rest of the day

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-29 Thread Rafael J. Wysocki
On Sunday, December 29, 2013 01:12:18 PM Kashyap Chamarthy wrote: > [. . .] > > >> Here's host dmesg: https://bugzilla.kernel.org/attachment.cgi?id=119751 > >> > Can you ftrace the failure? > >> > >> Can try, need some time (rest of the day I'll be away travelling, > >> will try to do it over

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-29 Thread Kashyap Chamarthy
[. . .] >> Here's host dmesg: https://bugzilla.kernel.org/attachment.cgi?id=119751 >> Can you ftrace the failure? >> >> Can try, need some time (rest of the day I'll be away travelling, >> will try to do it over the weekend, and update the Kernel >> bugzilla with observations). >> >>> Ug

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread Rafael J. Wysocki
On Friday, December 27, 2013 06:17:47 PM Kashyap Chamarthy wrote: > On 12/27/2013 06:01 PM, Gleb Natapov wrote: > > On Fri, Dec 27, 2013 at 06:52:48PM +0200, Gleb Natapov wrote: > >> On Fri, Dec 27, 2013 at 03:15:39PM +0100, Kashyap Chamarthy wrote: > >>> [. . .] > >>> > > KVM does not emulate

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread Kashyap Chamarthy
On 12/27/2013 06:01 PM, Gleb Natapov wrote: > On Fri, Dec 27, 2013 at 06:52:48PM +0200, Gleb Natapov wrote: >> On Fri, Dec 27, 2013 at 03:15:39PM +0100, Kashyap Chamarthy wrote: >>> [. . .] >>> > KVM does not emulate P-states at all. intel_pstate_init() calls > intel_pstate_msrs_not_valid()

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread Richard W.M. Jones
On Fri, Dec 27, 2013 at 07:01:48PM +0200, Gleb Natapov wrote: > On Fri, Dec 27, 2013 at 06:52:48PM +0200, Gleb Natapov wrote: > > On Fri, Dec 27, 2013 at 03:15:39PM +0100, Kashyap Chamarthy wrote: > > > [. . .] > > > > > > >> KVM does not emulate P-states at all. intel_pstate_init() calls > > > >>

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread Gleb Natapov
On Fri, Dec 27, 2013 at 06:52:48PM +0200, Gleb Natapov wrote: > On Fri, Dec 27, 2013 at 03:15:39PM +0100, Kashyap Chamarthy wrote: > > [. . .] > > > > >> KVM does not emulate P-states at all. intel_pstate_init() calls > > >> intel_pstate_msrs_not_valid() before printing "Intel P-state driver > > >

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread Gleb Natapov
On Fri, Dec 27, 2013 at 03:15:39PM +0100, Kashyap Chamarthy wrote: > [. . .] > > >> KVM does not emulate P-states at all. intel_pstate_init() calls > >> intel_pstate_msrs_not_valid() before printing "Intel P-state driver > >> initializing." which suppose to fail since it checks that two reads of

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread Richard W.M. Jones
Probably the qemu command line is more interesting, which is in this comment and reproduced below. https://bugzilla.redhat.com/show_bug.cgi?id=1046317#c1 /usr/bin/qemu-kvm \ -global virtio-blk-pci.scsi=off \ -nodefconfig \ -enable-fips \ -nodefaults \ -display none \ -mach

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread Rafael J. Wysocki
On Tuesday, December 24, 2013 09:36:01 PM Viresh Kumar wrote: > Adding Dirk.. > > On 24 December 2013 20:06, Josh Boyer wrote: > > Hi All, > > > > We've had a report [1] that the pstate driver causes KVM guests to > > fail to boot because of a divide error. See the backtrace below. > > > > 4

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread Kashyap Chamarthy
[. . .] >> KVM does not emulate P-states at all. intel_pstate_init() calls >> intel_pstate_msrs_not_valid() before printing "Intel P-state driver >> initializing." which suppose to fail since it checks that two reads of >> MSR_IA32_APERF return different values, but KVM does not emulate this msr

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread Josh Boyer
On Fri, Dec 27, 2013 at 7:47 AM, Gleb Natapov wrote: > On Fri, Dec 27, 2013 at 12:24:22PM +, One Thousand Gnomes wrote: >> On Tue, 24 Dec 2013 21:36:01 +0530 >> Viresh Kumar wrote: >> >> > Adding Dirk.. >> > >> > On 24 December 2013 20:06, Josh Boyer wrote: >> > > Hi All, >> > > >> > > We've

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread Gleb Natapov
On Fri, Dec 27, 2013 at 12:24:22PM +, One Thousand Gnomes wrote: > On Tue, 24 Dec 2013 21:36:01 +0530 > Viresh Kumar wrote: > > > Adding Dirk.. > > > > On 24 December 2013 20:06, Josh Boyer wrote: > > > Hi All, > > > > > > We've had a report [1] that the pstate driver causes KVM guests to >

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-27 Thread One Thousand Gnomes
On Tue, 24 Dec 2013 21:36:01 +0530 Viresh Kumar wrote: > Adding Dirk.. > > On 24 December 2013 20:06, Josh Boyer wrote: > > Hi All, > > > > We've had a report [1] that the pstate driver causes KVM guests to > > fail to boot because of a divide error. See the backtrace below. > > > > 4.8397

Re: intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-24 Thread Viresh Kumar
Adding Dirk.. On 24 December 2013 20:06, Josh Boyer wrote: > Hi All, > > We've had a report [1] that the pstate driver causes KVM guests to > fail to boot because of a divide error. See the backtrace below. > > 4.839784] Intel P-state driver initializing. > [4.859972] Intel pstate contro

intel_pstate divide error with v3.13-rc4-256-gb7000ad

2013-12-24 Thread Josh Boyer
Hi All, We've had a report [1] that the pstate driver causes KVM guests to fail to boot because of a divide error. See the backtrace below. 4.839784] Intel P-state driver initializing. [4.859972] Intel pstate controlling: cpu 0 [4.867653] cpufreq: __cpufreq_add_dev: ->get() failed [