Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-06-12 Thread Dmitry Vyukov
On Mon, May 14, 2018 at 11:12 AM, Dmitry Vyukov wrote: > On Sun, May 6, 2018 at 10:30 PM, Theodore Y. Ts'o wrote: >> On Sun, May 06, 2018 at 11:40:10PM +0900, Tetsuo Handa wrote: >>> > We could add a full kernel-mode fsck which gets run before mount --- >>> > the question is how much complexity

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-06-12 Thread Dmitry Vyukov
On Mon, May 14, 2018 at 11:12 AM, Dmitry Vyukov wrote: > On Sun, May 6, 2018 at 10:30 PM, Theodore Y. Ts'o wrote: >> On Sun, May 06, 2018 at 11:40:10PM +0900, Tetsuo Handa wrote: >>> > We could add a full kernel-mode fsck which gets run before mount --- >>> > the question is how much complexity

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-14 Thread Dmitry Vyukov
On Sun, May 6, 2018 at 10:30 PM, Theodore Y. Ts'o wrote: > On Sun, May 06, 2018 at 11:40:10PM +0900, Tetsuo Handa wrote: >> > We could add a full kernel-mode fsck which gets run before mount --- >> > the question is how much complexity we want to add. If SELinux is >> > enabled,

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-14 Thread Dmitry Vyukov
On Sun, May 6, 2018 at 10:30 PM, Theodore Y. Ts'o wrote: > On Sun, May 06, 2018 at 11:40:10PM +0900, Tetsuo Handa wrote: >> > We could add a full kernel-mode fsck which gets run before mount --- >> > the question is how much complexity we want to add. If SELinux is >> > enabled, then we have to

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-06 Thread Theodore Y. Ts'o
On Sun, May 06, 2018 at 11:40:10PM +0900, Tetsuo Handa wrote: > > We could add a full kernel-mode fsck which gets run before mount --- > > the question is how much complexity we want to add. If SELinux is > > enabled, then we have to check xattr consinsistency, etc., etc. > > You are thinking

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-06 Thread Theodore Y. Ts'o
On Sun, May 06, 2018 at 11:40:10PM +0900, Tetsuo Handa wrote: > > We could add a full kernel-mode fsck which gets run before mount --- > > the question is how much complexity we want to add. If SELinux is > > enabled, then we have to check xattr consinsistency, etc., etc. > > You are thinking

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-06 Thread Tetsuo Handa
Theodore Y. Ts'o wrote: > On Sun, May 06, 2018 at 02:03:57PM +0900, Tetsuo Handa wrote: > > > > Since syzbot is hitting this error path inside mount() request, calling > > panic() when something went wrong inside mount() request might be > > overkill. We can recover without shutting down the

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-06 Thread Tetsuo Handa
Theodore Y. Ts'o wrote: > On Sun, May 06, 2018 at 02:03:57PM +0900, Tetsuo Handa wrote: > > > > Since syzbot is hitting this error path inside mount() request, calling > > panic() when something went wrong inside mount() request might be > > overkill. We can recover without shutting down the

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-06 Thread Theodore Y. Ts'o
On Sun, May 06, 2018 at 11:15:45AM +0200, Dmitry Vyukov wrote: > >> I don't get why syzbot considers this a bug. It created a corrupted > >> file system, mounted it as root, and said file system had the flag > >> which says, "panic if you find a file system corruption". > > In what world is this

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-06 Thread Theodore Y. Ts'o
On Sun, May 06, 2018 at 11:15:45AM +0200, Dmitry Vyukov wrote: > >> I don't get why syzbot considers this a bug. It created a corrupted > >> file system, mounted it as root, and said file system had the flag > >> which says, "panic if you find a file system corruption". > > In what world is this

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-06 Thread Theodore Y. Ts'o
On Sun, May 06, 2018 at 02:03:57PM +0900, Tetsuo Handa wrote: > > Since syzbot is hitting this error path inside mount() request, calling > panic() when something went wrong inside mount() request might be > overkill. We can recover without shutting down the system, can't we? We could add a full

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-06 Thread Theodore Y. Ts'o
On Sun, May 06, 2018 at 02:03:57PM +0900, Tetsuo Handa wrote: > > Since syzbot is hitting this error path inside mount() request, calling > panic() when something went wrong inside mount() request might be > overkill. We can recover without shutting down the system, can't we? We could add a full

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-06 Thread Dmitry Vyukov
On Sun, May 6, 2018 at 7:03 AM, Tetsuo Handa wrote: > On 2018/05/06 11:24, Theodore Y. Ts'o wrote: >> On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: >>> Hello, >>> >>> syzbot found the following crash on: >>> >>> EXT4-fs error (device loop0):

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-06 Thread Dmitry Vyukov
On Sun, May 6, 2018 at 7:03 AM, Tetsuo Handa wrote: > On 2018/05/06 11:24, Theodore Y. Ts'o wrote: >> On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: >>> Hello, >>> >>> syzbot found the following crash on: >>> >>> EXT4-fs error (device loop0): ext4_iget:4756: inode #2: comm >>>

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-05 Thread Tetsuo Handa
On 2018/05/06 11:24, Theodore Y. Ts'o wrote: > On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> EXT4-fs error (device loop0): ext4_iget:4756: inode #2: comm >> syz-executor909: root inode unallocated >> Kernel panic - not syncing:

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-05 Thread Tetsuo Handa
On 2018/05/06 11:24, Theodore Y. Ts'o wrote: > On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> EXT4-fs error (device loop0): ext4_iget:4756: inode #2: comm >> syz-executor909: root inode unallocated >> Kernel panic - not syncing:

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-05 Thread Theodore Y. Ts'o
On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > EXT4-fs error (device loop0): ext4_iget:4756: inode #2: comm > syz-executor909: root inode unallocated > Kernel panic - not syncing: EXT4-fs (device loop0): panic forced after error I

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-05 Thread Theodore Y. Ts'o
On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > EXT4-fs error (device loop0): ext4_iget:4756: inode #2: comm > syz-executor909: root inode unallocated > Kernel panic - not syncing: EXT4-fs (device loop0): panic forced after error I

kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-05 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11a8a07b80 kernel config: https://syzkaller.appspot.com/x/.config?x=5a1dc06635c10d27

kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-05 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11a8a07b80 kernel config: https://syzkaller.appspot.com/x/.config?x=5a1dc06635c10d27