Re: kernel panic: corrupted stack end in dput

2019-07-03 Thread John Fastabend
Eric Biggers wrote: > [+bpf and tls maintainers] > > On Wed, Jul 03, 2019 at 04:23:34PM +0100, Al Viro wrote: > > On Wed, Jul 03, 2019 at 03:40:00PM +0100, Al Viro wrote: > > > On Wed, Jul 03, 2019 at 02:43:07PM +0800, Hillf Danton wrote: > > > > > > > > This is very much *NOT* fine. > > > > >

Re: kernel panic: corrupted stack end in dput

2019-07-03 Thread Eric Biggers
[+bpf and tls maintainers] On Wed, Jul 03, 2019 at 04:23:34PM +0100, Al Viro wrote: > On Wed, Jul 03, 2019 at 03:40:00PM +0100, Al Viro wrote: > > On Wed, Jul 03, 2019 at 02:43:07PM +0800, Hillf Danton wrote: > > > > > > This is very much *NOT* fine. > > > > 1) trylock can fail from any n

Re: kernel panic: corrupted stack end in dput

2019-07-03 Thread Al Viro
On Wed, Jul 03, 2019 at 03:40:00PM +0100, Al Viro wrote: > On Wed, Jul 03, 2019 at 02:43:07PM +0800, Hillf Danton wrote: > > > > This is very much *NOT* fine. > > > 1) trylock can fail from any number of reasons, starting > > > with "somebody is going through the hash chain doing a lookup on > >

Re: kernel panic: corrupted stack end in dput

2019-07-03 Thread Al Viro
On Wed, Jul 03, 2019 at 02:43:07PM +0800, Hillf Danton wrote: > > This is very much *NOT* fine. > > 1) trylock can fail from any number of reasons, starting > > with "somebody is going through the hash chain doing a lookup on > > something completely unrelated" > > They are also a red light t

Re: kernel panic: corrupted stack end in dput

2019-07-02 Thread Al Viro
On Tue, Jul 02, 2019 at 05:21:26PM +0800, Hillf Danton wrote: > Hello, > --- a/fs/dcache.c > +++ b/fs/dcache.c > @@ -673,14 +673,11 @@ static struct dentry *dentry_kill(struct dentry *dentry) > if (!IS_ROOT(dentry)) { > parent = dentry->d_parent; > if (unlikely(!

Re: kernel panic: corrupted stack end in dput

2019-07-01 Thread syzbot
syzbot has bisected this bug to: commit e9db4ef6bf4ca9894bb324c76e01b8f1a16b2650 Author: John Fastabend Date: Sat Jun 30 13:17:47 2018 + bpf: sockhash fix omitted bucket lock in sock_close bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17f7f4d5a0 start commit: 7b7

kernel panic: corrupted stack end in dput

2019-07-01 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7b75e49d net: dsa: mv88e6xxx: wait after reset deactivation git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=10f51b13a0 kernel config: https://syzkaller.appspot.com/x/.config?x=e7c31a94f66cc0aa dashboar