[PATCH v9 4/7] arm64: hyperv: Add kexec and panic handlers

2021-03-08 Thread Michael Kelley
Add function to inform Hyper-V about a guest panic. Also add functions to set up and remove kexec and panic handlers, which are currently unused on ARM64 but are called from architecture independent code in the VMbus driver. This code is built only when CONFIG_HYPERV is enabled. Signed-off

RE: [PATCH v8 3/6] arm64: hyperv: Add kexec and panic handlers

2021-03-03 Thread Sunil Muthuswamy
> +EXPORT_SYMBOL_GPL(hv_setup_crash_handler); > + > +void hv_remove_crash_handler(void) > +{ > +} > +EXPORT_SYMBOL_GPL(hv_remove_crash_handler); > -- > 1.8.3.1 Reviewed-by: Sunil Muthuswamy

[PATCH v8 3/6] arm64: hyperv: Add kexec and panic handlers

2021-02-18 Thread Michael Kelley
Add function to inform Hyper-V about a guest panic. Also add functions to set up and remove kexec and panic handlers, which are currently unused on ARM64 but are called from architecture independent code in the VMbus driver. This code is built only when CONFIG_HYPERV is enabled. Signed-off

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-05 Thread Giancarlo Ferrari
On Fri, Feb 05, 2021 at 09:44:59AM +, Russell King - ARM Linux admin wrote: > On Fri, Feb 05, 2021 at 12:40:54AM +, Giancarlo Ferrari wrote: > > Russell, > > > > On Fri, Feb 05, 2021 at 12:18:33AM +, Russell King - ARM Linux admin > > wrote: > > > On Thu, Feb 04, 2021 at 11:48:42PM

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-05 Thread Russell King - ARM Linux admin
On Fri, Feb 05, 2021 at 12:40:54AM +, Giancarlo Ferrari wrote: > Russell, > > On Fri, Feb 05, 2021 at 12:18:33AM +, Russell King - ARM Linux admin > wrote: > > On Thu, Feb 04, 2021 at 11:48:42PM +, Giancarlo Ferrari wrote: > > > Can I ask about having it integrated ? > > > > Thanks

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-04 Thread Giancarlo Ferrari
Sorry for polluting, On Fri, Feb 05, 2021 at 12:40:54AM +, Giancarlo Ferrari wrote: > Russell, > > On Fri, Feb 05, 2021 at 12:18:33AM +, Russell King - ARM Linux admin > wrote: > > On Thu, Feb 04, 2021 at 11:48:42PM +, Giancarlo Ferrari wrote: > > > Can I ask about having it

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-04 Thread Giancarlo Ferrari
Russell, On Fri, Feb 05, 2021 at 12:18:33AM +, Russell King - ARM Linux admin wrote: > On Thu, Feb 04, 2021 at 11:48:42PM +, Giancarlo Ferrari wrote: > > Can I ask about having it integrated ? > > Thanks for testing. Are you willing for me to add: > > Tested-by: Giancarlo Ferrari > >

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-04 Thread Russell King - ARM Linux admin
On Thu, Feb 04, 2021 at 11:48:42PM +, Giancarlo Ferrari wrote: > Can I ask about having it integrated ? Thanks for testing. Are you willing for me to add: Tested-by: Giancarlo Ferrari to the commit log? I can move it into the fixes branch which I want to send to Linus by Saturday at the

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-04 Thread Giancarlo Ferrari
Hi all, On Mon, Feb 01, 2021 at 10:18:26PM +, Giancarlo Ferrari wrote: > Russell, > > On Mon, Feb 01, 2021 at 08:16:33PM +, Russell King - ARM Linux admin > wrote: > > On Mon, Feb 01, 2021 at 08:07:37PM +, Giancarlo Ferrari wrote: > > > Hi, > > > > Hi, > > > > > Why we should

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Giancarlo Ferrari
Russell, On Mon, Feb 01, 2021 at 08:16:33PM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 01, 2021 at 08:07:37PM +, Giancarlo Ferrari wrote: > > Hi, > > Hi, > > > Why we should align 3 ? For the fncpy I suppose. > > Slightly arbitary really - it gives a nice 8-byte alignment

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Russell King - ARM Linux admin
On Mon, Feb 01, 2021 at 08:07:37PM +, Giancarlo Ferrari wrote: > Hi, Hi, > Why we should align 3 ? For the fncpy I suppose. Slightly arbitary really - it gives a nice 8-byte alignment to the data. .align 2 would also be sufficient. > I don't know now how to proceed now, as you (Mark and

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Giancarlo Ferrari
Hi, On Mon, Feb 01, 2021 at 04:08:38PM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 01, 2021 at 01:57:14PM +, Mark Rutland wrote: > > We could simplify this slightly if we moved the kexec_& variables into a > > struct (using asm-offset KEXEC_VAR_* offsets and a KEXEC_VAR_SIZE

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Giancarlo Ferrari
Hi, On Mon, Feb 01, 2021 at 03:30:12PM +, Mark Rutland wrote: > Hi, > > On Mon, Feb 01, 2021 at 02:39:46PM +, Giancarlo Ferrari wrote: > > On Mon, Feb 01, 2021 at 12:47:20PM +, Mark Rutland wrote: > > > On Mon, Feb 01, 2021 at 12:44:56AM +, Giancarlo Ferrari wrote: > > > >

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Russell King - ARM Linux admin
On Mon, Feb 01, 2021 at 04:32:40PM +, Mark Rutland wrote: > I reckon here we need: > > __cpuc_flush_dcache_area(reboot_code_buffer, >relocate_new_kernel_size + sizeof(*data)); > > ... to make sure both the instructions and data are visible with the MMU >

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Mark Rutland
On Mon, Feb 01, 2021 at 04:08:38PM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 01, 2021 at 01:57:14PM +, Mark Rutland wrote: > > We could simplify this slightly if we moved the kexec_& variables into a > > struct (using asm-offset KEXEC_VAR_* offsets and a KEXEC_VAR_SIZE region

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Russell King - ARM Linux admin
On Mon, Feb 01, 2021 at 01:57:14PM +, Mark Rutland wrote: > We could simplify this slightly if we moved the kexec_& variables into a > struct (using asm-offset KEXEC_VAR_* offsets and a KEXEC_VAR_SIZE region > reserved in the asm), then here we could do something like: > > static struct

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Mark Rutland
Hi, On Mon, Feb 01, 2021 at 02:39:46PM +, Giancarlo Ferrari wrote: > On Mon, Feb 01, 2021 at 12:47:20PM +, Mark Rutland wrote: > > On Mon, Feb 01, 2021 at 12:44:56AM +, Giancarlo Ferrari wrote: > > > machine_kexec() need to set rw permission in text and rodata sections > > > to assign

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Giancarlo Ferrari
Hi, On Mon, Feb 01, 2021 at 12:47:20PM +, Mark Rutland wrote: > On Mon, Feb 01, 2021 at 12:44:56AM +, Giancarlo Ferrari wrote: > > machine_kexec() need to set rw permission in text and rodata sections > > to assign some variables (e.g. kexec_start_address). To do that at > > the end

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Mark Rutland
On Mon, Feb 01, 2021 at 01:03:45PM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 01, 2021 at 12:47:20PM +, Mark Rutland wrote: > > 1. copy reloc code into buffer > > 2. alter variables in copy of reloc code > > 3. branch to buffer > > > > ... which would avoid this class of

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Russell King - ARM Linux admin
On Mon, Feb 01, 2021 at 12:47:20PM +, Mark Rutland wrote: > 1. copy reloc code into buffer > 2. alter variables in copy of reloc code > 3. branch to buffer > > ... which would avoid this class of problem too. Yep, slightly messy to do though: diff --git a/arch/arm/kernel/machine_kexec.c

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Mark Rutland
On Mon, Feb 01, 2021 at 12:44:56AM +, Giancarlo Ferrari wrote: > machine_kexec() need to set rw permission in text and rodata sections > to assign some variables (e.g. kexec_start_address). To do that at > the end (after flushing pdm in memory, etc.) it needs to invalidate > TLB [section]

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Russell King - ARM Linux admin
I wish others who know this code would get involved, and such stuff wasn't left to me to research and work out whether a patch is correct or not. On Mon, Feb 01, 2021 at 12:44:56AM +, Giancarlo Ferrari wrote: > machine_kexec() need to set rw permission in text and rodata sections > to assign

Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-02-01 Thread Giancarlo Ferrari
Hi all, On Tue, Jan 12, 2021 at 04:49:06PM +, Giancarlo Ferrari wrote: > machine_kexec() need to set rw permission in text and rodata sections > to assign some variables (e.g. kexec_start_address). To do that at > the end (after flushing pdm in memory, inv D-Cache, etc.) it needs to >

[PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-01-31 Thread Giancarlo Ferrari
machine_kexec() need to set rw permission in text and rodata sections to assign some variables (e.g. kexec_start_address). To do that at the end (after flushing pdm in memory, etc.) it needs to invalidate TLB [section] entries. If during the TLB invalidation an interrupt occours, which might

[PATCH] ARM: kexec: Fix panic after TLB are invalidated

2021-01-12 Thread Giancarlo Ferrari
machine_kexec() need to set rw permission in text and rodata sections to assign some variables (e.g. kexec_start_address). To do that at the end (after flushing pdm in memory, inv D-Cache, etc.) it needs to invalidate TLB [section] entries. If during the TLB invalidation an interrupt occours,

[PATCH v7 06/10] arm64: hyperv: Add kexec and panic handlers

2020-08-24 Thread Michael Kelley
Add functions to set up and remove kexec and panic handlers, and to inform Hyper-V about a guest panic. These functions are called from architecture independent code in the VMbus driver. This code is built only when CONFIG_HYPERV is enabled. Signed-off-by: Michael Kelley --- arch/arm64/hyperv

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-15 Thread Dave Young
On 05/15/17 at 02:23pm, Matt Fleming wrote: > (Pulling in Dave, Mr. Kexec on EFI) > > On Mon, 08 May, at 12:25:23PM, Sai Praneeth Prakhya wrote: > > From: Sai Praneeth > > > > Booting kexec kernel with "efi=old_map" in kernel command line hits > > kernel panic as

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-15 Thread Dave Young
On 05/15/17 at 02:23pm, Matt Fleming wrote: > (Pulling in Dave, Mr. Kexec on EFI) > > On Mon, 08 May, at 12:25:23PM, Sai Praneeth Prakhya wrote: > > From: Sai Praneeth > > > > Booting kexec kernel with "efi=old_map" in kernel command line hits > > kernel panic as shown below. > > > > [

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-15 Thread Matt Fleming
(Pulling in Dave, Mr. Kexec on EFI) On Mon, 08 May, at 12:25:23PM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Booting kexec kernel with "efi=old_map" in kernel command line hits > kernel panic as shown below. > > [0.001000] BUG: unable to handle

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-15 Thread Matt Fleming
(Pulling in Dave, Mr. Kexec on EFI) On Mon, 08 May, at 12:25:23PM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Booting kexec kernel with "efi=old_map" in kernel command line hits > kernel panic as shown below. > > [0.001000] BUG: unable to handle kernel paging request at

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-12 Thread Sai Praneeth Prakhya
On Fri, 2017-05-12 at 17:56 +0800, joeyli wrote: > On Mon, May 08, 2017 at 12:25:23PM -0700, Sai Praneeth Prakhya wrote: > > From: Sai Praneeth > > > > Booting kexec kernel with "efi=old_map" in kernel command line hits > > kernel panic as shown below. > > > > [

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-12 Thread Sai Praneeth Prakhya
On Fri, 2017-05-12 at 17:56 +0800, joeyli wrote: > On Mon, May 08, 2017 at 12:25:23PM -0700, Sai Praneeth Prakhya wrote: > > From: Sai Praneeth > > > > Booting kexec kernel with "efi=old_map" in kernel command line hits > > kernel panic as shown below. > > > > [0.001000] BUG: unable to

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-12 Thread joeyli
On Mon, May 08, 2017 at 12:25:23PM -0700, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Booting kexec kernel with "efi=old_map" in kernel command line hits > kernel panic as shown below. > > [0.001000] BUG: unable to handle kernel paging request at

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-12 Thread joeyli
On Mon, May 08, 2017 at 12:25:23PM -0700, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Booting kexec kernel with "efi=old_map" in kernel command line hits > kernel panic as shown below. > > [0.001000] BUG: unable to handle kernel paging request at 88007fe78070 > [0.001000]

[PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-08 Thread Sai Praneeth Prakhya
From: Sai Praneeth Booting kexec kernel with "efi=old_map" in kernel command line hits kernel panic as shown below. [0.001000] BUG: unable to handle kernel paging request at 88007fe78070 [0.001000] IP: virt_efi_set_variable.part.7+0x63/0x1b0 [

[PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-08 Thread Sai Praneeth Prakhya
From: Sai Praneeth Booting kexec kernel with "efi=old_map" in kernel command line hits kernel panic as shown below. [0.001000] BUG: unable to handle kernel paging request at 88007fe78070 [0.001000] IP: virt_efi_set_variable.part.7+0x63/0x1b0 [0.001000] PGD 7ea28067 [

Re: kexec on panic

2017-02-18 Thread Jon Masters
possible anyhow to execute regular (not special "panic" one to capture > crash data) kexec on panic to reduce reboot time? Generally, you don't want to do this, because various platform hardware might be in non-quiescent states (still doing DMA to random memory, etc.) and other nastine

Re: kexec on panic

2017-02-18 Thread Jon Masters
possible anyhow to execute regular (not special "panic" one to capture > crash data) kexec on panic to reduce reboot time? Generally, you don't want to do this, because various platform hardware might be in non-quiescent states (still doing DMA to random memory, etc.) and other nastine

Re: kexec on panic

2017-02-18 Thread Denys Fedoryshchenko
to me: Is it possible anyhow to execute regular (not special "panic" one to capture crash data) kexec on panic to reduce reboot time? Generally, you don't want to do this, because various platform hardware might be in non-quiescent states (still doing DMA to random memory, etc.)

Re: kexec on panic

2017-02-18 Thread Denys Fedoryshchenko
to me: Is it possible anyhow to execute regular (not special "panic" one to capture crash data) kexec on panic to reduce reboot time? Generally, you don't want to do this, because various platform hardware might be in non-quiescent states (still doing DMA to random memory, etc.)

kexec on panic

2017-02-10 Thread Denys Fedoryshchenko
crash data) kexec on panic to reduce reboot time? Thanks!

kexec on panic

2017-02-10 Thread Denys Fedoryshchenko
crash data) kexec on panic to reduce reboot time? Thanks!

[PATCH 2/3] kexec: Pass panic message to crash_kexec()

2015-07-10 Thread Hidehiro Kawai
Add an argument to crash_kexec() to pass the panic message. This patch is a preparation for the next patch, and it doesn't change the current behavior. Signed-off-by: Hidehiro Kawai Cc: Andrew Morton Cc: Eric Biederman Cc: Vivek Goyal --- arch/arm/kernel/traps.c |2 +-

[PATCH 2/3] kexec: Pass panic message to crash_kexec()

2015-07-10 Thread Hidehiro Kawai
Add an argument to crash_kexec() to pass the panic message. This patch is a preparation for the next patch, and it doesn't change the current behavior. Signed-off-by: Hidehiro Kawai hidehiro.kawai...@hitachi.com Cc: Andrew Morton a...@linux-foundation.org Cc: Eric Biederman ebied...@xmission.com

[PATCH 14/15] kexec: Support for kexec on panic using new system call

2014-06-26 Thread Vivek Goyal
This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. It prepares ELF headers for memory areas to be dumped and for saved cpu registers. Also prepares the memory map for second kernel and limits its boot to reserved areas only. Signed-off-by: Vivek Goyal

[PATCH 14/15] kexec: Support for kexec on panic using new system call

2014-06-26 Thread Vivek Goyal
This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. It prepares ELF headers for memory areas to be dumped and for saved cpu registers. Also prepares the memory map for second kernel and limits its boot to reserved areas only. Signed-off-by: Vivek Goyal vgo

Re: [PATCH 12/13] kexec: Support for Kexec on panic using new system call

2014-06-18 Thread Vivek Goyal
On Tue, Jun 17, 2014 at 11:43:10PM +0200, Borislav Petkov wrote: [..] > > diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h > > new file mode 100644 > > index 000..2dd2eb8 > > --- /dev/null > > +++ b/arch/x86/include/asm/crash.h > > @@ -0,0 +1,9 @@ > > +#ifndef

Re: [PATCH 12/13] kexec: Support for Kexec on panic using new system call

2014-06-18 Thread Vivek Goyal
On Tue, Jun 17, 2014 at 11:43:10PM +0200, Borislav Petkov wrote: [..] diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h new file mode 100644 index 000..2dd2eb8 --- /dev/null +++ b/arch/x86/include/asm/crash.h @@ -0,0 +1,9 @@ +#ifndef _ASM_X86_CRASH_H

Re: [PATCH 12/13] kexec: Support for Kexec on panic using new system call

2014-06-17 Thread Borislav Petkov
On Tue, Jun 03, 2014 at 09:07:01AM -0400, Vivek Goyal wrote: > This patch adds support for loading a kexec on panic (kdump) kernel usning > new system call. Right now this primarily works with bzImage loader only. > But changes to ELF loader should be minimal as all the core infr

Re: [PATCH 12/13] kexec: Support for Kexec on panic using new system call

2014-06-17 Thread Borislav Petkov
On Tue, Jun 03, 2014 at 09:07:01AM -0400, Vivek Goyal wrote: This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. Right now this primarily works with bzImage loader only. But changes to ELF loader should be minimal as all the core infrastrcture

[PATCH 12/13] kexec: Support for Kexec on panic using new system call

2014-06-03 Thread Vivek Goyal
This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. Right now this primarily works with bzImage loader only. But changes to ELF loader should be minimal as all the core infrastrcture is there. Only thing preventing making ELF load in crash reseved memory

[PATCH 12/13] kexec: Support for Kexec on panic using new system call

2014-06-03 Thread Vivek Goyal
This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. Right now this primarily works with bzImage loader only. But changes to ELF loader should be minimal as all the core infrastrcture is there. Only thing preventing making ELF load in crash reseved memory

Re: [PATCH 11/11] kexec: Support for Kexec on panic using new system call

2014-02-28 Thread Vivek Goyal
On Fri, Feb 28, 2014 at 06:28:57PM +0100, Borislav Petkov wrote: [..] > > +/* Memory to backup during crash kdump */ > > +#define KEXEC_BACKUP_SRC_START (0UL) > > +#define KEXEC_BACKUP_SRC_END (655360UL) /* 640K */ > > I guess > > #define KEXEC_BACKUP_SRC_END (640 * 1024UL) > >

Re: [PATCH 11/11] kexec: Support for Kexec on panic using new system call

2014-02-28 Thread Borislav Petkov
On Mon, Jan 27, 2014 at 01:57:51PM -0500, Vivek Goyal wrote: > This patch adds support for loading a kexec on panic (kdump) kernel usning > new system call. Right now this primarily works with bzImage loader only. > But changes to ELF loader should be minimal as all the core infr

Re: [PATCH 11/11] kexec: Support for Kexec on panic using new system call

2014-02-28 Thread Borislav Petkov
On Mon, Jan 27, 2014 at 01:57:51PM -0500, Vivek Goyal wrote: This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. Right now this primarily works with bzImage loader only. But changes to ELF loader should be minimal as all the core infrastrcture

Re: [PATCH 11/11] kexec: Support for Kexec on panic using new system call

2014-02-28 Thread Vivek Goyal
On Fri, Feb 28, 2014 at 06:28:57PM +0100, Borislav Petkov wrote: [..] +/* Memory to backup during crash kdump */ +#define KEXEC_BACKUP_SRC_START (0UL) +#define KEXEC_BACKUP_SRC_END (655360UL) /* 640K */ I guess #define KEXEC_BACKUP_SRC_END (640 * 1024UL) should be

[PATCH 11/11] kexec: Support for Kexec on panic using new system call

2014-01-27 Thread Vivek Goyal
This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. Right now this primarily works with bzImage loader only. But changes to ELF loader should be minimal as all the core infrastrcture is there. Only thing preventing making ELF load in crash reseved memory

[PATCH 11/11] kexec: Support for Kexec on panic using new system call

2014-01-27 Thread Vivek Goyal
This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. Right now this primarily works with bzImage loader only. But changes to ELF loader should be minimal as all the core infrastrcture is there. Only thing preventing making ELF load in crash reseved memory

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-04 Thread Vivek Goyal
On Wed, Dec 04, 2013 at 09:51:27AM +0800, Baoquan He wrote: > On 12/02/13 at 10:30am, Vivek Goyal wrote: > > On Thu, Nov 28, 2013 at 07:28:16PM +0800, Baoquan He wrote: > > > > [..] > > > > +int crash_copy_backup_region(struct kimage *image) > > > > +{ > > > > > > Why need this func be called,

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-04 Thread Vivek Goyal
On Wed, Dec 04, 2013 at 09:41:05AM +0800, Baoquan He wrote: > On 11/20/13 at 12:50pm, Vivek Goyal wrote: > > This patch adds support for loading a kexec on panic (kdump) kernel usning > > new system call. > > +int load_crashdump_segments(struct kimage *image) > > +{ >

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-04 Thread Vivek Goyal
On Wed, Dec 04, 2013 at 09:41:05AM +0800, Baoquan He wrote: On 11/20/13 at 12:50pm, Vivek Goyal wrote: This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. +int load_crashdump_segments(struct kimage *image) +{ + unsigned long src_start, src_sz

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-04 Thread Vivek Goyal
On Wed, Dec 04, 2013 at 09:51:27AM +0800, Baoquan He wrote: On 12/02/13 at 10:30am, Vivek Goyal wrote: On Thu, Nov 28, 2013 at 07:28:16PM +0800, Baoquan He wrote: [..] +int crash_copy_backup_region(struct kimage *image) +{ Why need this func be called, backup region has been

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-03 Thread Baoquan He
On 12/02/13 at 10:30am, Vivek Goyal wrote: > On Thu, Nov 28, 2013 at 07:28:16PM +0800, Baoquan He wrote: > > [..] > > > +int crash_copy_backup_region(struct kimage *image) > > > +{ > > > > Why need this func be called, backup region has been added into crash > > segment by kexec_add_buffer, and

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-03 Thread Baoquan He
On 11/20/13 at 12:50pm, Vivek Goyal wrote: > This patch adds support for loading a kexec on panic (kdump) kernel usning > new system call. > +int load_crashdump_segments(struct kimage *image) > +{ > + unsigned long src_start, src_sz; > + unsigned long elf_addr, elf_s

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-03 Thread Baoquan He
On 11/20/13 at 12:50pm, Vivek Goyal wrote: This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. +int load_crashdump_segments(struct kimage *image) +{ + unsigned long src_start, src_sz; + unsigned long elf_addr, elf_sz; + int ret

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-03 Thread Baoquan He
On 12/02/13 at 10:30am, Vivek Goyal wrote: On Thu, Nov 28, 2013 at 07:28:16PM +0800, Baoquan He wrote: [..] +int crash_copy_backup_region(struct kimage *image) +{ Why need this func be called, backup region has been added into crash segment by kexec_add_buffer, and then buffer

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-02 Thread Vivek Goyal
On Thu, Nov 28, 2013 at 07:28:16PM +0800, Baoquan He wrote: [..] > > +int crash_copy_backup_region(struct kimage *image) > > +{ > > Why need this func be called, backup region has been added into crash > segment by kexec_add_buffer, and then buffer copy is done in > kimage_load_crash_segment. I

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-02 Thread Vivek Goyal
On Thu, Nov 28, 2013 at 07:28:16PM +0800, Baoquan He wrote: [..] +int crash_copy_backup_region(struct kimage *image) +{ Why need this func be called, backup region has been added into crash segment by kexec_add_buffer, and then buffer copy is done in kimage_load_crash_segment. I think

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-11-28 Thread Baoquan He
On 11/20/13 at 12:50pm, Vivek Goyal wrote: > This patch adds support for loading a kexec on panic (kdump) kernel usning > new system call. > > Signed-off-by: Vivek Goyal > --- > arch/x86/include/asm/crash.h |9 + > arch/x86/include/asm/kexec.h | 17 + >

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-11-28 Thread Baoquan He
On 11/20/13 at 12:50pm, Vivek Goyal wrote: This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. Signed-off-by: Vivek Goyal vgo...@redhat.com --- arch/x86/include/asm/crash.h |9 + arch/x86/include/asm/kexec.h | 17 + arch/x86

[PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-11-20 Thread Vivek Goyal
This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. Signed-off-by: Vivek Goyal --- arch/x86/include/asm/crash.h |9 + arch/x86/include/asm/kexec.h | 17 + arch/x86/kernel/crash.c| 585

[PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-11-20 Thread Vivek Goyal
This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. Signed-off-by: Vivek Goyal vgo...@redhat.com --- arch/x86/include/asm/crash.h |9 + arch/x86/include/asm/kexec.h | 17 + arch/x86/kernel/crash.c| 585

Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Dave Hansen
On Thu, 2005-02-24 at 14:43 +0530, Vivek Goyal wrote: > Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of > re-organization of boot memory allocator initialization code. Primary > kernel does not boot if kexec is enabled and [EMAIL PROTECTED] command > line parameter is p

Re: [Fastboot] Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Maneesh Soni
On Thu, Feb 24, 2005 at 06:05:45AM -0700, Eric W. Biederman wrote: > Maneesh Soni <[EMAIL PROTECTED]> writes: > > > On Thu, Feb 24, 2005 at 01:13:12AM -0800, Andrew Morton wrote: > > > Vivek Goyal <[EMAIL PROTECTED]> wrote: > > > > > > >

Re: [Fastboot] Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Eric W. Biederman
Maneesh Soni <[EMAIL PROTECTED]> writes: > On Thu, Feb 24, 2005 at 01:13:12AM -0800, Andrew Morton wrote: > > Vivek Goyal <[EMAIL PROTECTED]> wrote: > > > > > > Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of > > > re-organizat

Re: [Fastboot] Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: > Vivek Goyal <[EMAIL PROTECTED]> wrote: > > > > Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of > > re-organization of boot memory allocator initialization code. > > OK... > > Where are we u

Re: [Fastboot] Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Maneesh Soni
On Thu, Feb 24, 2005 at 01:13:12AM -0800, Andrew Morton wrote: > Vivek Goyal <[EMAIL PROTECTED]> wrote: > > > > Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of > > re-organization of boot memory allocator initialization code. > > OK... > >

Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Andrew Morton
Vivek Goyal <[EMAIL PROTECTED]> wrote: > > Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of > re-organization of boot memory allocator initialization code. OK... Where are we up to with these patches, btw? Do you consider them close-to-complete? Do you have

[PATCH] Fix for broken kexec on panic

2005-02-24 Thread Vivek Goyal
Hi, Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of re-organization of boot memory allocator initialization code. Primary kernel does not boot if kexec is enabled and [EMAIL PROTECTED] command line parameter is passed. After re-organization, kexec is trying to call reserve_bootmem

[PATCH] Fix for broken kexec on panic

2005-02-24 Thread Vivek Goyal
Hi, Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of re-organization of boot memory allocator initialization code. Primary kernel does not boot if kexec is enabled and [EMAIL PROTECTED] command line parameter is passed. After re-organization, kexec is trying to call reserve_bootmem

Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Andrew Morton
Vivek Goyal [EMAIL PROTECTED] wrote: Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of re-organization of boot memory allocator initialization code. OK... Where are we up to with these patches, btw? Do you consider them close-to-complete? Do you have a feel for what proportion

Re: [Fastboot] Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Maneesh Soni
On Thu, Feb 24, 2005 at 01:13:12AM -0800, Andrew Morton wrote: Vivek Goyal [EMAIL PROTECTED] wrote: Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of re-organization of boot memory allocator initialization code. OK... Where are we up to with these patches, btw? Do you

Re: [Fastboot] Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Eric W. Biederman
Andrew Morton [EMAIL PROTECTED] writes: Vivek Goyal [EMAIL PROTECTED] wrote: Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of re-organization of boot memory allocator initialization code. OK... Where are we up to with these patches, btw? Currently we

Re: [Fastboot] Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Eric W. Biederman
Maneesh Soni [EMAIL PROTECTED] writes: On Thu, Feb 24, 2005 at 01:13:12AM -0800, Andrew Morton wrote: Vivek Goyal [EMAIL PROTECTED] wrote: Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of re-organization of boot memory allocator initialization code. OK... Where

Re: [Fastboot] Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Maneesh Soni
On Thu, Feb 24, 2005 at 06:05:45AM -0700, Eric W. Biederman wrote: Maneesh Soni [EMAIL PROTECTED] writes: On Thu, Feb 24, 2005 at 01:13:12AM -0800, Andrew Morton wrote: Vivek Goyal [EMAIL PROTECTED] wrote: Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of re

Re: [PATCH] Fix for broken kexec on panic

2005-02-24 Thread Dave Hansen
On Thu, 2005-02-24 at 14:43 +0530, Vivek Goyal wrote: Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of re-organization of boot memory allocator initialization code. Primary kernel does not boot if kexec is enabled and [EMAIL PROTECTED] command line parameter is passed. After re