Re: kref refcnt and false positives

2007-01-01 Thread Benjamin Herrenschmidt
> This makes my Maple board very unhappy -- it triggers a WARN_ON() in > kref_get() lots of times... Maybe the refounting in prom.c is broken ? I'll have a look. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More maj

Re: kref refcnt and false positives

2006-12-31 Thread David Woodhouse
> Parent: f238085415c56618e042252894f2fcc971add645 > Author: Venkatesh Pallipadi <[EMAIL PROTECTED]> > AuthorDate: Tue Dec 19 13:01:29 2006 -0800 > Committer: Greg Kroah-Hartman <[EMAIL PROTECTED]> > CommitDate: Wed Dec 20 10:56:43 2006 -0800 > > kref refcnt and false posit

[PATCH 1/3] kref refcnt and false positives

2006-12-20 Thread Greg KH
From: Venkatesh Pallipadi <[EMAIL PROTECTED]> With WARN_ON addition to kobject_init() [ http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/dont-use/broken-out/gregkh-driver-kobject-warn.patch ] I started seeing following WARNING on CPU offline followed by online on my

Re: kref refcnt and false positives

2006-12-14 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: > Guys, we have about 100 reports of weirdo > crashes, smashes, bashes and splats in the kref code. The last thing we > need is some obscure, tricksy little optimisation which leads legitimate > uses of the API to mysteriously

Re: kref refcnt and false positives

2006-12-14 Thread Andrew Morton
On Thu, 14 Dec 2006 17:19:55 -0700 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > "Pallipadi, Venkatesh" <[EMAIL PROTECTED]> writes: > > >>But I believe Venkatesh problem comes from its release() > >>function : It is > >>supposed to free the object. > >>If not, it should properly setup it so th

Re: kref refcnt and false positives

2006-12-14 Thread Eric W. Biederman
"Pallipadi, Venkatesh" <[EMAIL PROTECTED]> writes: >>But I believe Venkatesh problem comes from its release() >>function : It is >>supposed to free the object. >>If not, it should properly setup it so that further uses are OK. >> >>ie doing in release(kref) >>atomic_set(&kref->count, 0); >> > >

RE: kref refcnt and false positives

2006-12-14 Thread Pallipadi, Venkatesh
>-Original Message- >From: Eric Dumazet [mailto:[EMAIL PROTECTED] >Sent: Wednesday, December 13, 2006 11:57 PM >To: Andrew Morton >Cc: Greg KH; Pallipadi, Venkatesh; Arjan; linux-kernel; Eric >W. Biederman >Subject: Re: kref refcnt and false positives > >

Re: kref refcnt and false positives

2006-12-14 Thread Eric Dumazet
Andrew Morton a écrit : On Wed, 13 Dec 2006 16:12:46 -0800 Greg KH <[EMAIL PROTECTED]> wrote: Original comment seemed to indicate that this conditional thing was performance related. Is it really? If not, we should consider the below patch. Yes, it's a performance gain and I don't see how this

Re: kref refcnt and false positives

2006-12-13 Thread Venkatesh Pallipadi
On Wed, Dec 13, 2006 at 04:12:46PM -0800, Greg KH wrote: > On Wed, Dec 13, 2006 at 03:34:08PM -0800, Venkatesh Pallipadi wrote: > > > > With WARN_ON addition to kobject_init() > > [ > > http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/dont-use/broken-out/gregkh-driver-

Re: kref refcnt and false positives

2006-12-13 Thread Andrew Morton
On Wed, 13 Dec 2006 16:12:46 -0800 Greg KH <[EMAIL PROTECTED]> wrote: > > Original comment seemed to indicate that this conditional thing was > > performance related. Is it really? If not, we should consider the below > > patch. > > Yes, it's a performance gain and I don't see how this patch wou

kref refcnt and false positives

2006-12-13 Thread Venkatesh Pallipadi
With WARN_ON addition to kobject_init() [ http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/dont-use/broken-out/gregkh-driver-kobject-warn.patch ] I started seeing following WARNING on CPU offline followed by online on my x86_64 system. WARNING at lib/kobject.c:172 k

Re: kref refcnt and false positives

2006-12-13 Thread Greg KH
On Wed, Dec 13, 2006 at 03:34:08PM -0800, Venkatesh Pallipadi wrote: > > With WARN_ON addition to kobject_init() > [ > http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/dont-use/broken-out/gregkh-driver-kobject-warn.patch > ] > > I started seeing following WARNING on