Re: ledtrig-cpu: Limit to 4 CPUs

2020-10-08 Thread Pavel Machek
Hi! > > I believe probability someone uses that with more than 4 CPUs is < > > 5%. > > So you even didn't bother to check: > > $ git grep "default-trigger = \"cpu[4-9]" > arch/arm/boot/dts/vexpress-v2m-rs1.dtsi: linux,default-trigger = "cpu4"; > arch/arm/boot/dts/vexpress-v2m-rs1.dtsi:

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-26 Thread Jacek Anaszewski
On 9/25/20 11:40 AM, Pavel Machek wrote: Hi! So.. no, it is not causing kernel crashes or something. But it is example of bad interface, and _that_ is causing problems. (And yes, if I realized it is simply possible to limit it, maybe the BIN_ATTR conversion would not be neccessary...) The

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-25 Thread Pavel Machek
Hi! > >>So.. no, it is not causing kernel crashes or something. But it is > >>example of bad interface, and _that_ is causing problems. (And yes, if > >>I realized it is simply possible to limit it, maybe the BIN_ATTR > >>conversion would not be neccessary...) > > > >The limitation you proposed

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-25 Thread Jacek Anaszewski
On 9/22/20 10:41 PM, Jacek Anaszewski wrote: Hi Pavel, On 9/22/20 12:42 AM, Pavel Machek wrote: Hi! Can I get details of your setup? I don't use this trigger, but I can imagine that someone does. Well, if someone exists, we can increase the limit, or convince them to change their setup.

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-22 Thread Jacek Anaszewski
Hi Pavel, On 9/22/20 12:42 AM, Pavel Machek wrote: Hi! Can I get details of your setup? I don't use this trigger, but I can imagine that someone does. Well, if someone exists, we can increase the limit, or convince them to change their setup. Linux is used in many commercial projects

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-21 Thread Pavel Machek
Hi! > >Can I get details of your setup? > > I don't use this trigger, but I can imagine that someone does. Well, if someone exists, we can increase the limit, or convince them to change their setup. > >What CPU type that is, and how are you mapping CPU activity to LEDs? > > The type of CPU is

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-21 Thread Jacek Anaszewski
On 9/20/20 8:34 PM, Pavel Machek wrote: Hi! * * It can be bound to any LED just like other triggers using either a * board file or via sysfs interface. * * An API named ledtrig_cpu is exported for any user, who want to add CPU - * activity indication in their code + *

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-20 Thread Pavel Machek
Hi! > >* > >* It can be bound to any LED just like other triggers using either a > >* board file or via sysfs interface. > >* > >* An API named ledtrig_cpu is exported for any user, who want to add CPU > > - * activity indication in their code > > + * activity indication in

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-20 Thread Jacek Anaszewski
318681d3e019e39354cc6c2155a7fd1bb8e8084d Author: Pavel Machek Date: Sat Sep 19 11:34:58 2020 +0200 ledtrig-cpu: Limit to 4 CPUs Some machines have thousands of CPUs... and trigger mechanisms was not really meant for thousands of triggers. I doubt anyone uses this trigger on many-CPU

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-20 Thread Marek Behun
>>> commit 318681d3e019e39354cc6c2155a7fd1bb8e8084d > >>> Author: Pavel Machek > >>> Date: Sat Sep 19 11:34:58 2020 +0200 > >>> > >>> ledtrig-cpu: Limit to 4 CPUs > >>> > >>> Some machines hav

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-20 Thread Jacek Anaszewski
On 9/20/20 5:39 PM, Marek Behun wrote: On Sun, 20 Sep 2020 16:15:09 +0200 Jacek Anaszewski wrote: Hi Pavel, On 9/19/20 11:38 AM, Pavel Machek wrote: commit 318681d3e019e39354cc6c2155a7fd1bb8e8084d Author: Pavel Machek Date: Sat Sep 19 11:34:58 2020 +0200 ledtrig-cpu: Limit to 4

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-20 Thread Marek Behun
On Sun, 20 Sep 2020 16:15:09 +0200 Jacek Anaszewski wrote: > Hi Pavel, > > On 9/19/20 11:38 AM, Pavel Machek wrote: > > commit 318681d3e019e39354cc6c2155a7fd1bb8e8084d > > Author: Pavel Machek > > Date: Sat Sep 19 11:34:58 2020 +0200 > > >

Re: ledtrig-cpu: Limit to 4 CPUs

2020-09-20 Thread Jacek Anaszewski
Hi Pavel, On 9/19/20 11:38 AM, Pavel Machek wrote: commit 318681d3e019e39354cc6c2155a7fd1bb8e8084d Author: Pavel Machek Date: Sat Sep 19 11:34:58 2020 +0200 ledtrig-cpu: Limit to 4 CPUs Some machines have thousands of CPUs... and trigger mechanisms was not really meant