Re: lguest rebroken in 2.6.22-rc3-mm1

2007-06-05 Thread Andi Kleen
> But TSC is a "required feature", so "cpu_has_tsc" is always true. Hmm? It isn't. What makes you think so? cpufeature.h: #define cpu_has_tsc boot_cpu_has(X86_FEATURE_TSC) % grep -i tsc include/asm-i386/required-features.h % > How about this patch: > === > Don't try to disable the

Re: lguest rebroken in 2.6.22-rc3-mm1

2007-06-04 Thread Rusty Russell
On Mon, 2007-06-04 at 20:12 +0200, Andi Kleen wrote: > > > > > > Looks like this one got lost in rc3-mm1. > > > > Andi said that he fixed the zero-divide by other means? > > I determined it cannot happen in my source tree. When notsc > is passed TSC CPUID is cleared and sched-clock works. > > I s

Re: lguest rebroken in 2.6.22-rc3-mm1

2007-06-04 Thread Andi Kleen
> > > > Looks like this one got lost in rc3-mm1. > > Andi said that he fixed the zero-divide by other means? I determined it cannot happen in my source tree. When notsc is passed TSC CPUID is cleared and sched-clock works. I suspect what happens is that lguest forgets to clear the TSC cpuid bit

Re: lguest rebroken in 2.6.22-rc3-mm1

2007-06-04 Thread Matt Mackall
On Mon, Jun 04, 2007 at 10:28:20AM -0700, Andrew Morton wrote: > On Mon, 4 Jun 2007 12:19:33 -0500 Matt Mackall <[EMAIL PROTECTED]> wrote: > > > On Wed, May 23, 2007 at 09:27:40AM +1000, Rusty Russell wrote: > > > On Tue, 2007-05-22 at 17:38 -0500, Matt Mackall wrote: > > > > [0.120007] EIP is

Re: lguest rebroken in 2.6.22-rc3-mm1

2007-06-04 Thread Andrew Morton
On Mon, 4 Jun 2007 12:19:33 -0500 Matt Mackall <[EMAIL PROTECTED]> wrote: > On Wed, May 23, 2007 at 09:27:40AM +1000, Rusty Russell wrote: > > On Tue, 2007-05-22 at 17:38 -0500, Matt Mackall wrote: > > > [0.120007] EIP is at resync_sc_freq+0x4b/0x56 > > > > Hi Matt, > > > > Thanks for th

lguest rebroken in 2.6.22-rc3-mm1

2007-06-04 Thread Matt Mackall
On Wed, May 23, 2007 at 09:27:40AM +1000, Rusty Russell wrote: > On Tue, 2007-05-22 at 17:38 -0500, Matt Mackall wrote: > > [0.120007] EIP is at resync_sc_freq+0x4b/0x56 > > Hi Matt, > > Thanks for the report! Andrew should have these two patches queued, > but here they are again: > >