Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Valdis . Kletnieks
On Tue, 05 Jun 2007 18:16:25 EDT, Jeff Garzik said: > On Tue, Jun 05, 2007 at 11:03:45PM +0100, Russell King wrote: > > And rather than configuring your MUA to ignore the header... > > > You're using mutt, mutt can be configured so. > > So, you are seriously proposing that EVERYONE reconfigure

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 11:03:45PM +0100, Russell King wrote: > On Tue, Jun 05, 2007 at 05:48:30PM -0400, Jeff Garzik wrote: > > On Tue, Jun 05, 2007 at 10:38:15PM +0100, Russell King wrote: > > > There is one final point on this which I wish to make, in case anyone > > > has decided that this is

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 05:48:30PM -0400, Jeff Garzik wrote: > On Tue, Jun 05, 2007 at 10:38:15PM +0100, Russell King wrote: > > There is one final point on this which I wish to make, in case anyone > > has decided that this is caused by some recent change at my end. > > > > I've been adding this

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 10:38:15PM +0100, Russell King wrote: > There is one final point on this which I wish to make, in case anyone > has decided that this is caused by some recent change at my end. > > I've been adding this header to all my messages for about the last seven > years. It's only

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 10:25:23PM +0100, Russell King wrote: > On Tue, Jun 05, 2007 at 12:27:45PM -0700, David Miller wrote: > > From: Russell King <[EMAIL PROTECTED]> > > Date: Tue, 5 Jun 2007 16:21:33 +0100 > > > > > Oh sod it, I'm unsubscribing from LKML. Jeff, hope your happy. > > > > What

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 12:27:45PM -0700, David Miller wrote: > From: Russell King <[EMAIL PROTECTED]> > Date: Tue, 5 Jun 2007 16:21:33 +0100 > > > Oh sod it, I'm unsubscribing from LKML. Jeff, hope your happy. > > What an adult way for you to handle this. Indeed; it's obvious that you're not

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 12:23:35PM -0700, David Miller wrote: > From: Russell King <[EMAIL PROTECTED]> > Date: Tue, 5 Jun 2007 15:59:46 +0100 > > > It's the fact that I _am_ CC'd on replies, so I get one message from LKML > > one from the original poster, maybe one via another mailing list if

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Chuck Ebbert
On 06/05/2007 03:24 PM, David Miller wrote: > > I totally agree, Russel you are being totally unreasonable. > ^^ Uh-oh. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Russell King <[EMAIL PROTECTED]> Date: Tue, 5 Jun 2007 16:21:33 +0100 > Oh sod it, I'm unsubscribing from LKML. Jeff, hope your happy. What an adult way for you to handle this. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Russell King <[EMAIL PROTECTED]> Date: Tue, 5 Jun 2007 16:18:47 +0100 > On Tue, Jun 05, 2007 at 11:11:04AM -0400, Jeff Garzik wrote: > > You are NOT more important that everyone else. > > That's not the issue. Yes it is, you're imposing your lousy solution to your problems on other

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 5 Jun 2007 11:11:04 -0400 > On Tue, Jun 05, 2007 at 03:59:46PM +0100, Russell King wrote: > > Give me a way to stop people CC'ing me on replies and I'll happily remove > > the header. Unfortunately there isn't, so I can't. > > So by fiat, you

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Russell King <[EMAIL PROTECTED]> Date: Tue, 5 Jun 2007 15:59:46 +0100 > It's the fact that I _am_ CC'd on replies, so I get one message from LKML > one from the original poster, maybe one via another mailing list if it's > also copied there. Add that in to the mix of all the other mail

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 04:50:56PM +0100, Alan Cox wrote: > > If you don't have DMA capabilities, does libata still need ->pad and > > ->pad_dma set? > > It shouldn't - nor the prd. You don't need to use the default > ata_port_start in this case. I've just added ata_sff_port_start to my > tree

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 11:41:57AM -0400, Jeff Garzik wrote: > On Tue, Jun 05, 2007 at 04:18:47PM +0100, Russell King wrote: > > Meanwhile you decide that you have a right over _MY_ personal preferences. > > It's the same argument I'm afraid, just a different point of view. If > > _you_ do not

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Alan Cox
> If you don't have DMA capabilities, does libata still need ->pad and > ->pad_dma set? It shouldn't - nor the prd. You don't need to use the default ata_port_start in this case. I've just added ata_sff_port_start to my tree which figures out which to allocate for SFF devices. - To unsubscribe

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 04:18:47PM +0100, Russell King wrote: > Meanwhile you decide that you have a right over _MY_ personal preferences. > It's the same argument I'm afraid, just a different point of view. If > _you_ do not wish to abide by the header then turn off that feature in > your

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 04:18:47PM +0100, Russell King wrote: > > If you are unwilling to fix the problem and work within existing > > community email standards, I think it would be fair to ask vger > > postmaster to start excising Mail-Followup-To headers. > > Well, that will leave me with _no_

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 11:11:04AM -0400, Jeff Garzik wrote: > On Tue, Jun 05, 2007 at 03:59:46PM +0100, Russell King wrote: > > It's the fact that I _am_ CC'd on replies, so I get one message from LKML > > one from the original poster, maybe one via another mailing list if it's > > also copied

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 03:59:46PM +0100, Russell King wrote: > It's the fact that I _am_ CC'd on replies, so I get one message from LKML > one from the original poster, maybe one via another mailing list if it's > also copied there. Add that in to the mix of all the other mail hitting > my MTA

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 10:56:03AM -0400, Jeff Garzik wrote: > On Tue, Jun 05, 2007 at 03:51:49PM +0100, Russell King wrote: > > On Tue, Jun 05, 2007 at 10:35:23AM -0400, Jeff Garzik wrote: > > > > > > BTW, please fix your mailer. It emits Mail-Followup-To headers that > > > hijack everyone on

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 03:51:49PM +0100, Russell King wrote: > On Tue, Jun 05, 2007 at 10:35:23AM -0400, Jeff Garzik wrote: > > > > BTW, please fix your mailer. It emits Mail-Followup-To headers that > > hijack everyone on the thread into the To field, breaking the normal > > LKML To/CC

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 10:35:23AM -0400, Jeff Garzik wrote: > > BTW, please fix your mailer. It emits Mail-Followup-To headers that > hijack everyone on the thread into the To field, breaking the normal > LKML To/CC standard replying mechanism that has been working for a > decade. Sorry, I

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
BTW, please fix your mailer. It emits Mail-Followup-To headers that hijack everyone on the thread into the To field, breaking the normal LKML To/CC standard replying mechanism that has been working for a decade. Jeff - To unsubscribe from this list: send the line "unsubscribe

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 03:17:14PM +0100, Russell King wrote: > On Tue, Jun 05, 2007 at 09:56:08AM -0400, Jeff Garzik wrote: > > On Tue, Jun 05, 2007 at 12:22:18PM +0100, Alan Cox wrote: > > > > NAK > > > > > > > > We have generic devices and generic DMA mapping. libata already uses > > > > the

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 09:56:08AM -0400, Jeff Garzik wrote: > On Tue, Jun 05, 2007 at 12:22:18PM +0100, Alan Cox wrote: > > > NAK > > > > > > We have generic devices and generic DMA mapping. libata already uses > > > the generic stuff. Now fix the platform... > > > > Nice theory but your

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 12:22:18PM +0100, Alan Cox wrote: > > NAK > > > > We have generic devices and generic DMA mapping. libata already uses > > the generic stuff. Now fix the platform... > > Nice theory but your generic helpers rely on the map functions working > even for generic hardware

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Alan Cox
> NAK > > We have generic devices and generic DMA mapping. libata already uses > the generic stuff. Now fix the platform... Nice theory but your generic helpers rely on the map functions working even for generic hardware that doesn't need them, so at the very least there is some clean up

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-05 Thread Alan Cox
> > The 32-bit sparc port has some but those PCMCIA controllers aren't > > going to be supported in the foreseeable future, you have to abstract > > out all the inb/outb etc. operations to go through the pcmcia > > controller driver for one thing. Thats one place iomap might actually save the day

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Alan Cox
The 32-bit sparc port has some but those PCMCIA controllers aren't going to be supported in the foreseeable future, you have to abstract out all the inb/outb etc. operations to go through the pcmcia controller driver for one thing. Thats one place iomap might actually save the day as you

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Alan Cox
NAK We have generic devices and generic DMA mapping. libata already uses the generic stuff. Now fix the platform... Nice theory but your generic helpers rely on the map functions working even for generic hardware that doesn't need them, so at the very least there is some clean up required.

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 12:22:18PM +0100, Alan Cox wrote: NAK We have generic devices and generic DMA mapping. libata already uses the generic stuff. Now fix the platform... Nice theory but your generic helpers rely on the map functions working even for generic hardware that doesn't

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 09:56:08AM -0400, Jeff Garzik wrote: On Tue, Jun 05, 2007 at 12:22:18PM +0100, Alan Cox wrote: NAK We have generic devices and generic DMA mapping. libata already uses the generic stuff. Now fix the platform... Nice theory but your generic helpers rely

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 03:17:14PM +0100, Russell King wrote: On Tue, Jun 05, 2007 at 09:56:08AM -0400, Jeff Garzik wrote: On Tue, Jun 05, 2007 at 12:22:18PM +0100, Alan Cox wrote: NAK We have generic devices and generic DMA mapping. libata already uses the generic stuff. Now

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
BTW, please fix your mailer. It emits Mail-Followup-To headers that hijack everyone on the thread into the To field, breaking the normal LKML To/CC standard replying mechanism that has been working for a decade. Jeff - To unsubscribe from this list: send the line unsubscribe

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 10:35:23AM -0400, Jeff Garzik wrote: BTW, please fix your mailer. It emits Mail-Followup-To headers that hijack everyone on the thread into the To field, breaking the normal LKML To/CC standard replying mechanism that has been working for a decade. Sorry, I will

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 03:51:49PM +0100, Russell King wrote: On Tue, Jun 05, 2007 at 10:35:23AM -0400, Jeff Garzik wrote: BTW, please fix your mailer. It emits Mail-Followup-To headers that hijack everyone on the thread into the To field, breaking the normal LKML To/CC standard

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 10:56:03AM -0400, Jeff Garzik wrote: On Tue, Jun 05, 2007 at 03:51:49PM +0100, Russell King wrote: On Tue, Jun 05, 2007 at 10:35:23AM -0400, Jeff Garzik wrote: BTW, please fix your mailer. It emits Mail-Followup-To headers that hijack everyone on the thread

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 03:59:46PM +0100, Russell King wrote: It's the fact that I _am_ CC'd on replies, so I get one message from LKML one from the original poster, maybe one via another mailing list if it's also copied there. Add that in to the mix of all the other mail hitting my MTA and

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 11:11:04AM -0400, Jeff Garzik wrote: On Tue, Jun 05, 2007 at 03:59:46PM +0100, Russell King wrote: It's the fact that I _am_ CC'd on replies, so I get one message from LKML one from the original poster, maybe one via another mailing list if it's also copied there.

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 04:18:47PM +0100, Russell King wrote: If you are unwilling to fix the problem and work within existing community email standards, I think it would be fair to ask vger postmaster to start excising Mail-Followup-To headers. Well, that will leave me with _no_ _choice_

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 04:18:47PM +0100, Russell King wrote: Meanwhile you decide that you have a right over _MY_ personal preferences. It's the same argument I'm afraid, just a different point of view. If _you_ do not wish to abide by the header then turn off that feature in your mailer.

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 11:41:57AM -0400, Jeff Garzik wrote: On Tue, Jun 05, 2007 at 04:18:47PM +0100, Russell King wrote: Meanwhile you decide that you have a right over _MY_ personal preferences. It's the same argument I'm afraid, just a different point of view. If _you_ do not wish to

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Alan Cox
If you don't have DMA capabilities, does libata still need -pad and -pad_dma set? It shouldn't - nor the prd. You don't need to use the default ata_port_start in this case. I've just added ata_sff_port_start to my tree which figures out which to allocate for SFF devices. - To unsubscribe from

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 04:50:56PM +0100, Alan Cox wrote: If you don't have DMA capabilities, does libata still need -pad and -pad_dma set? It shouldn't - nor the prd. You don't need to use the default ata_port_start in this case. I've just added ata_sff_port_start to my tree which

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Russell King [EMAIL PROTECTED] Date: Tue, 5 Jun 2007 15:59:46 +0100 It's the fact that I _am_ CC'd on replies, so I get one message from LKML one from the original poster, maybe one via another mailing list if it's also copied there. Add that in to the mix of all the other mail hitting

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 5 Jun 2007 11:11:04 -0400 On Tue, Jun 05, 2007 at 03:59:46PM +0100, Russell King wrote: Give me a way to stop people CC'ing me on replies and I'll happily remove the header. Unfortunately there isn't, so I can't. So by fiat, you decide that

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Russell King [EMAIL PROTECTED] Date: Tue, 5 Jun 2007 16:18:47 +0100 On Tue, Jun 05, 2007 at 11:11:04AM -0400, Jeff Garzik wrote: You are NOT more important that everyone else. That's not the issue. Yes it is, you're imposing your lousy solution to your problems on other people.

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread David Miller
From: Russell King [EMAIL PROTECTED] Date: Tue, 5 Jun 2007 16:21:33 +0100 Oh sod it, I'm unsubscribing from LKML. Jeff, hope your happy. What an adult way for you to handle this. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Chuck Ebbert
On 06/05/2007 03:24 PM, David Miller wrote: I totally agree, Russel you are being totally unreasonable. ^^ Uh-oh. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 12:23:35PM -0700, David Miller wrote: From: Russell King [EMAIL PROTECTED] Date: Tue, 5 Jun 2007 15:59:46 +0100 It's the fact that I _am_ CC'd on replies, so I get one message from LKML one from the original poster, maybe one via another mailing list if it's also

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 12:27:45PM -0700, David Miller wrote: From: Russell King [EMAIL PROTECTED] Date: Tue, 5 Jun 2007 16:21:33 +0100 Oh sod it, I'm unsubscribing from LKML. Jeff, hope your happy. What an adult way for you to handle this. Indeed; it's obvious that you're not listening

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 10:25:23PM +0100, Russell King wrote: On Tue, Jun 05, 2007 at 12:27:45PM -0700, David Miller wrote: From: Russell King [EMAIL PROTECTED] Date: Tue, 5 Jun 2007 16:21:33 +0100 Oh sod it, I'm unsubscribing from LKML. Jeff, hope your happy. What an adult way

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 10:38:15PM +0100, Russell King wrote: There is one final point on this which I wish to make, in case anyone has decided that this is caused by some recent change at my end. I've been adding this header to all my messages for about the last seven years. It's only

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Russell King
On Tue, Jun 05, 2007 at 05:48:30PM -0400, Jeff Garzik wrote: On Tue, Jun 05, 2007 at 10:38:15PM +0100, Russell King wrote: There is one final point on this which I wish to make, in case anyone has decided that this is caused by some recent change at my end. I've been adding this header

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Jeff Garzik
On Tue, Jun 05, 2007 at 11:03:45PM +0100, Russell King wrote: On Tue, Jun 05, 2007 at 05:48:30PM -0400, Jeff Garzik wrote: On Tue, Jun 05, 2007 at 10:38:15PM +0100, Russell King wrote: There is one final point on this which I wish to make, in case anyone has decided that this is caused by

Re: libata no PCI: dma_[un]map_single undefined

2007-06-05 Thread Valdis . Kletnieks
On Tue, 05 Jun 2007 18:16:25 EDT, Jeff Garzik said: On Tue, Jun 05, 2007 at 11:03:45PM +0100, Russell King wrote: And rather than configuring your MUA to ignore the header... You're using mutt, mutt can be configured so. So, you are seriously proposing that EVERYONE reconfigure their

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-04 Thread William Lee Irwin III
From: Alan Cox <[EMAIL PROTECTED]> Date: Mon, 4 Jun 2007 14:30:05 +0100 >> There are PCMCIA controllers and PCI/PCMCIA/Cardbus adapters for the >> Sparc platform I thought ? On Mon, Jun 04, 2007 at 02:22:43PM -0700, David Miller wrote: > The 32-bit sparc port has some but those PCMCIA controllers

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-04 Thread Jeff Garzik
On Mon, Jun 04, 2007 at 08:47:19AM +0100, Christoph Hellwig wrote: > The right fix is the depend on the new HAS_DMA (or whatever it's called) ACK... if the platform truly does not do DMA. > symbol. The proper long-term fix is to move calln to the dam mapping > functions from the core libata

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-04 Thread David Miller
From: Alan Cox <[EMAIL PROTECTED]> Date: Mon, 4 Jun 2007 14:30:05 +0100 > > It really makes no sense to allow this on Sparc, there are no > > non-PCI Sparc ATA controllers. > > There are PCMCIA controllers and PCI/PCMCIA/Cardbus adapters for the > Sparc platform I thought ? The 32-bit sparc

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-04 Thread Alan Cox
> > CONFIG_PCI=n > > CONFIG_ATA=m > > > > This seems to be a valid configuration since libata can drive non-PCI > > devices too? Yep. > It really makes no sense to allow this on Sparc, there are no > non-PCI Sparc ATA controllers. There are PCMCIA controllers and PCI/PCMCIA/Cardbus adapters

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-04 Thread Geert Uytterhoeven
[ Your email has `m68k' in the body, so I read it :-] On Sun, 3 Jun 2007, David Miller wrote: > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index b4a8d60..7d893a6 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -8,6 +8,7 @@ menuconfig ATA > depends on BLOCK

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-04 Thread Christoph Hellwig
On Sun, Jun 03, 2007 at 05:40:10PM -0700, David Miller wrote: > From: Meelis Roos <[EMAIL PROTECTED]> > Date: Sun, 3 Jun 2007 23:23:33 +0300 (EEST) > > > I accidentally enabled libata config options on my Sun Ultra 1 (sparc64, > > UP, no PCI, only SBUS): > > > > MODPOST 440 modules > > ERROR:

Re: libata no PCI: dma_[un]map_single undefined

2007-06-04 Thread Christoph Hellwig
On Sun, Jun 03, 2007 at 05:40:10PM -0700, David Miller wrote: From: Meelis Roos [EMAIL PROTECTED] Date: Sun, 3 Jun 2007 23:23:33 +0300 (EEST) I accidentally enabled libata config options on my Sun Ultra 1 (sparc64, UP, no PCI, only SBUS): MODPOST 440 modules ERROR: dma_unmap_sg

Re: libata no PCI: dma_[un]map_single undefined

2007-06-04 Thread Geert Uytterhoeven
[ Your email has `m68k' in the body, so I read it :-] On Sun, 3 Jun 2007, David Miller wrote: diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index b4a8d60..7d893a6 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -8,6 +8,7 @@ menuconfig ATA depends on BLOCK

Re: libata no PCI: dma_[un]map_single undefined

2007-06-04 Thread Alan Cox
CONFIG_PCI=n CONFIG_ATA=m This seems to be a valid configuration since libata can drive non-PCI devices too? Yep. It really makes no sense to allow this on Sparc, there are no non-PCI Sparc ATA controllers. There are PCMCIA controllers and PCI/PCMCIA/Cardbus adapters for the Sparc

Re: libata no PCI: dma_[un]map_single undefined

2007-06-04 Thread David Miller
From: Alan Cox [EMAIL PROTECTED] Date: Mon, 4 Jun 2007 14:30:05 +0100 It really makes no sense to allow this on Sparc, there are no non-PCI Sparc ATA controllers. There are PCMCIA controllers and PCI/PCMCIA/Cardbus adapters for the Sparc platform I thought ? The 32-bit sparc port has

Re: libata no PCI: dma_[un]map_single undefined

2007-06-04 Thread Jeff Garzik
On Mon, Jun 04, 2007 at 08:47:19AM +0100, Christoph Hellwig wrote: The right fix is the depend on the new HAS_DMA (or whatever it's called) ACK... if the platform truly does not do DMA. symbol. The proper long-term fix is to move calln to the dam mapping functions from the core libata

Re: libata no PCI: dma_[un]map_single undefined

2007-06-04 Thread William Lee Irwin III
From: Alan Cox [EMAIL PROTECTED] Date: Mon, 4 Jun 2007 14:30:05 +0100 There are PCMCIA controllers and PCI/PCMCIA/Cardbus adapters for the Sparc platform I thought ? On Mon, Jun 04, 2007 at 02:22:43PM -0700, David Miller wrote: The 32-bit sparc port has some but those PCMCIA controllers aren't

Re: libata & no PCI: dma_[un]map_single undefined

2007-06-03 Thread David Miller
From: Meelis Roos <[EMAIL PROTECTED]> Date: Sun, 3 Jun 2007 23:23:33 +0300 (EEST) > I accidentally enabled libata config options on my Sun Ultra 1 (sparc64, > UP, no PCI, only SBUS): > > MODPOST 440 modules > ERROR: "dma_unmap_sg" [drivers/ata/libata.ko] undefined! > ERROR: "dma_map_sg"

libata & no PCI: dma_[un]map_single undefined

2007-06-03 Thread Meelis Roos
I accidentally enabled libata config options on my Sun Ultra 1 (sparc64, UP, no PCI, only SBUS): MODPOST 440 modules ERROR: "dma_unmap_sg" [drivers/ata/libata.ko] undefined! ERROR: "dma_map_sg" [drivers/ata/libata.ko] undefined! ERROR: "dma_unmap_single" [drivers/ata/libata.ko] undefined!

libata no PCI: dma_[un]map_single undefined

2007-06-03 Thread Meelis Roos
I accidentally enabled libata config options on my Sun Ultra 1 (sparc64, UP, no PCI, only SBUS): MODPOST 440 modules ERROR: dma_unmap_sg [drivers/ata/libata.ko] undefined! ERROR: dma_map_sg [drivers/ata/libata.ko] undefined! ERROR: dma_unmap_single [drivers/ata/libata.ko] undefined! ERROR:

Re: libata no PCI: dma_[un]map_single undefined

2007-06-03 Thread David Miller
From: Meelis Roos [EMAIL PROTECTED] Date: Sun, 3 Jun 2007 23:23:33 +0300 (EEST) I accidentally enabled libata config options on my Sun Ultra 1 (sparc64, UP, no PCI, only SBUS): MODPOST 440 modules ERROR: dma_unmap_sg [drivers/ata/libata.ko] undefined! ERROR: dma_map_sg