Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-11 Thread David Miller
From: "Martin Schwidefsky" <[EMAIL PROTECTED]> Date: Wed, 11 Apr 2007 10:15:42 +0200 > On 4/11/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Tue, 10 Apr 2007 22:11:01 -0700 (PDT) David Miller <[EMAIL PROTECTED]> > > wrote: > > I think this means that if CONFIG_32BIT=y, s390 networking gets

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-11 Thread Martin Schwidefsky
On 4/11/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Tue, 10 Apr 2007 22:11:01 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: I think this means that if CONFIG_32BIT=y, s390 networking gets the whizzy assembly version and if CONFIG_32BIT=n, it gets to use the generic version. Possibly th

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 22:11:01 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > diff --git a/arch/s390/lib/Makefile b/arch/s390/lib/Makefile > index 7a44fed..59aea65 100644 > --- a/arch/s390/lib/Makefile > +++ b/arch/s390/lib/Makefile > @@ -5,6 +5,6 @@ > EXTRA_AFLAGS := -traditional > > lib

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 10 Apr 2007 18:47:38 -0700 > attribute(weak) would give a nicer result? > > We'd also need to remove s390's EXPORT_SYMBOL(__div64_32), so s390 ends up > using lib/div64.c's EXPORT_SYMBOL(). Ok, here is the version of the fix I'll use for now: c

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 10 Apr 2007 18:47:38 -0700 > On Tue, 10 Apr 2007 18:36:29 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > From: Andrew Morton <[EMAIL PROTECTED]> > > Date: Tue, 10 Apr 2007 18:29:37 -0700 > > > > > git-net.patch implements generic li

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 18:36:29 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Tue, 10 Apr 2007 18:29:37 -0700 > > > git-net.patch implements generic lib/div64.c, but s390 also has a > > private one. Presumably the appropriate fix is to remove

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 10 Apr 2007 18:29:37 -0700 > git-net.patch implements generic lib/div64.c, but s390 also has a > private one. Presumably the appropriate fix is to remove s390's > private implementation within davem's tree. The s390 version seems to be optimized

Re: link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread Andrew Morton
On Tue, 10 Apr 2007 20:56:16 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > The last for today : link error of 2.6.21-rc6-mm1 for s390 : > > > > /opt/crosstool/gcc-4.1.1-glibc-2.3.6/s390-unknown-linux-gnu/bin/s390-unknown-linux-gnu-ld > -m elf_s390 -e start -o .tmp_vmlinux1 -T arch/s39

link error : 2.6.21-rc6-mm1 for s390

2007-04-10 Thread Mathieu Desnoyers
Hi Andrew, The last for today : link error of 2.6.21-rc6-mm1 for s390 : /opt/crosstool/gcc-4.1.1-glibc-2.3.6/s390-unknown-linux-gnu/bin/s390-unknown-linux-gnu-ld -m elf_s390 -e start -o .tmp_vmlinux1 -T arch/s390/kernel/vmlinux.lds arch/s390/kernel/head.o arch/s390/kernel/init_task.o init/