Re: linux-next: Tree for Feb 12 (chrome/wilco_ec/)

2019-02-13 Thread Randy Dunlap
On 2/13/19 9:26 AM, Nick Crews wrote: > Randy, > > No, I didn't test it, I'm sorry, of course I should done that. > Sorry for the formatting too, I'm new to this and wasn't sure what > tool to use. The following version of the patch was made with > "git format-patch" and now I'm replying in plaint

Re: linux-next: Tree for Feb 12 (chrome/wilco_ec/)

2019-02-13 Thread Nick Crews
Randy, No, I didn't test it, I'm sorry, of course I should done that. Sorry for the formatting too, I'm new to this and wasn't sure what tool to use. The following version of the patch was made with "git format-patch" and now I'm replying in plaintext, it hopefully is better. >From 0cfb3db9706369

Re: linux-next: Tree for Feb 12 (chrome/wilco_ec/)

2019-02-12 Thread Randy Dunlap
On 2/12/19 3:49 PM, Nick Crews wrote: > OK, here is the patch to fix this problem. We had the dependency backwards. > > Should I re-send out the entire patch series to the LKML with this fix in it? > > > diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig > index 462eb

Re: linux-next: Tree for Feb 12 (chrome/wilco_ec/)

2019-02-12 Thread Randy Dunlap
On 2/12/19 3:49 PM, Nick Crews wrote: > OK, here is the patch to fix this problem. We had the dependency backwards. > > Should I re-send out the entire patch series to the LKML with this fix in it? > > > diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig > index 462eb

Re: linux-next: Tree for Feb 12 (chrome/wilco_ec/)

2019-02-12 Thread Randy Dunlap
On 2/12/19 3:26 PM, Nick Crews wrote: > Hi Randy, > > This looks like we have a bad dependency structure in our Kconfig. I'll > figure it out, and then where should I send the patch? AFAICT, all drivers/platform/chrome/ patches go to its maintainers (& to linux-kernel@vger.kernel.org): CHROME H

Re: linux-next: Tree for Feb 12 (chrome/wilco_ec/)

2019-02-12 Thread Randy Dunlap
On 2/11/19 10:50 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190211: > on i386 or x86_64: ld: drivers/platform/chrome/wilco_ec/core.o: in function `wilco_ec_remove': core.c:(.text+0x46): undefined reference to `cros_ec_lpc_mec_destroy' ld: drivers/platform/chrome/wilco_ec/core.o: