Re: linux-next: build warning after merge of the i2c tree

2019-08-01 Thread Uwe Kleine-König
Hello Wolfram, On Fri, Aug 02, 2019 at 01:21:23PM +1000, Stephen Rothwell wrote: > After merging the i2c tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > drivers/i2c/busses/i2c-designware-master.c: In function > 'i2c_dw_init_recovery_info': > drivers/i2c/busses/i

linux-next: build warning after merge of the i2c tree

2019-08-01 Thread Stephen Rothwell
Hi all, After merging the i2c tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/i2c/busses/i2c-designware-master.c: In function 'i2c_dw_init_recovery_info': drivers/i2c/busses/i2c-designware-master.c:658:6: warning: unused variable 'r' [-Wunused-variable] int

Re: linux-next: build warning after merge of the i2c tree

2019-06-12 Thread Wolfram Sang
On Wed, Jun 12, 2019 at 11:15:35PM +1000, Stephen Rothwell wrote: > Hi all, > > On Wed, 12 Jun 2019 09:32:29 -0300 Mauro Carvalho Chehab > wrote: > > > > Em Wed, 12 Jun 2019 14:04:39 +0200 > > Wolfram Sang escreveu: > > > > > > > OK, so that means I should send my pull request after yours in t

Re: linux-next: build warning after merge of the i2c tree

2019-06-12 Thread Stephen Rothwell
Hi all, On Wed, 12 Jun 2019 09:32:29 -0300 Mauro Carvalho Chehab wrote: > > Em Wed, 12 Jun 2019 14:04:39 +0200 > Wolfram Sang escreveu: > > > > > OK, so that means I should send my pull request after yours in the next > > > > merge window? To avoid the build breakage? > > > > > > Either t

Re: linux-next: build warning after merge of the i2c tree

2019-06-12 Thread Mauro Carvalho Chehab
Em Wed, 12 Jun 2019 14:04:39 +0200 Wolfram Sang escreveu: > > > OK, so that means I should send my pull request after yours in the next > > > merge window? To avoid the build breakage? > > > > Either that or you can apply my patch on your tree before the > > patch that caused the breakage. >

Re: linux-next: build warning after merge of the i2c tree

2019-06-12 Thread Wolfram Sang
> > OK, so that means I should send my pull request after yours in the next > > merge window? To avoid the build breakage? > > Either that or you can apply my patch on your tree before the > patch that caused the breakage. > > Just let me know what works best for you. Hmm, the offending patch

Re: linux-next: build warning after merge of the i2c tree

2019-06-12 Thread Mauro Carvalho Chehab
Em Wed, 12 Jun 2019 13:09:04 +0200 Wolfram Sang escreveu: > Hi Mauro, > > > That entire use of _P, _R and _ri looks weird into my eyes. The code there > > Yes. > > > do things like: > > > > #define _P 32 > > > > ... > > > > if (_P == 64) > > reg1[1] |= 0x40; > >

Re: linux-next: build warning after merge of the i2c tree

2019-06-12 Thread Wolfram Sang
Hi Mauro, > That entire use of _P, _R and _ri looks weird into my eyes. The code there Yes. > do things like: > > #define _P 32 > > ... > > if (_P == 64) > reg1[1] |= 0x40; Yup, I saw this, too, but didn't feel like refactoring the driver. Thanks for stepping up! > I

Re: linux-next: build warning after merge of the i2c tree

2019-06-12 Thread Mauro Carvalho Chehab
Em Wed, 12 Jun 2019 10:19:29 +0200 Wolfram Sang escreveu: > On Tue, Jun 11, 2019 at 10:25:28AM +1000, Stephen Rothwell wrote: > > Hi Wolfram, > > > > After merging the i2c tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > > > drivers/media/dvb-frontends/tua6100

Re: linux-next: build warning after merge of the i2c tree

2019-06-12 Thread Wolfram Sang
On Tue, Jun 11, 2019 at 10:25:28AM +1000, Stephen Rothwell wrote: > Hi Wolfram, > > After merging the i2c tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > drivers/media/dvb-frontends/tua6100.c: In function 'tua6100_set_params': > drivers/media/dvb-frontends/tua610

linux-next: build warning after merge of the i2c tree

2019-06-10 Thread Stephen Rothwell
Hi Wolfram, After merging the i2c tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/media/dvb-frontends/tua6100.c: In function 'tua6100_set_params': drivers/media/dvb-frontends/tua6100.c:71: warning: "_P" redefined #define _P 32 In file included from include/a

Re: linux-next: build warning after merge of the i2c tree

2017-06-15 Thread Stephen Rothwell
Hi Wolfram, On Thu, 15 Jun 2017 09:02:44 +0200 Wolfram Sang wrote: > > > > drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined > > > #define DEBUG > > > ^ > > > :0:0: note: this is the location of the previous definition > > > > > > Introduced by commit > > > > > > 6c42778780c4 ("i2c: s

Re: linux-next: build warning after merge of the i2c tree

2017-06-15 Thread Wolfram Sang
> > drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined > > #define DEBUG > > ^ > > :0:0: note: this is the location of the previous definition > > > > Introduced by commit > > > > 6c42778780c4 ("i2c: stub: use pr_fmt") > > I am still getting this ... Sorry, that slipped through the cra

Re: linux-next: build warning after merge of the i2c tree

2017-06-14 Thread Stephen Rothwell
Hi Wolfram, On Mon, 5 Jun 2017 11:11:31 +1000 Stephen Rothwell wrote: > > After merging the i2c tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined > #define DEBUG > ^ > :0:0: note: this is the location of t

linux-next: build warning after merge of the i2c tree

2017-06-04 Thread Stephen Rothwell
Hi Wolfram, After merging the i2c tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined #define DEBUG ^ :0:0: note: this is the location of the previous definition Introduced by commit 6c42778780c4 ("i2c: stub: us

linux-next: build warning after merge of the i2c tree

2014-03-05 Thread Stephen Rothwell
Hi Wolfram, After merging the i2c tree, today's linux-next build (powerpc ppc64_defconfig, x86_64 allmodconfig and arm multi_v7_defconfig) produced this warning: drivers/video/Kconfig:42:error: recursive dependency detected! drivers/video/Kconfig:42: symbol FB is selected by DRM_KMS_FB_HELP