Re: lockdep warning: console vs. mem hotplug

2017-07-24 Thread Sergey Senozhatsky
Hello, On (07/24/17 14:46), Sebastian Ott wrote: > [ 347.644660] == > [ 347.644660] WARNING: possible circular locking dependency detected > [ 347.644661] 4.13.0-rc2 #146 Not tainted > [ 347.644661]

Re: lockdep warning: console vs. mem hotplug

2017-07-24 Thread Sergey Senozhatsky
Hello, On (07/24/17 14:46), Sebastian Ott wrote: > [ 347.644660] == > [ 347.644660] WARNING: possible circular locking dependency detected > [ 347.644661] 4.13.0-rc2 #146 Not tainted > [ 347.644661]

Re: lockdep warning: console vs. mem hotplug

2017-07-24 Thread Sebastian Ott
Hello Sergey, On Tue, 21 Mar 2017, Sergey Senozhatsky wrote: > // I kept only lockdep splats from the original report and cut off .configs > // full version: > // lkml.kernel.org/r/alpine.LFD.2.20.1703201736070.1753@schleppi > > On (03/20/17 17:43), Sebastian Ott wrote: > > Since commit

Re: lockdep warning: console vs. mem hotplug

2017-07-24 Thread Sebastian Ott
Hello Sergey, On Tue, 21 Mar 2017, Sergey Senozhatsky wrote: > // I kept only lockdep splats from the original report and cut off .configs > // full version: > // lkml.kernel.org/r/alpine.LFD.2.20.1703201736070.1753@schleppi > > On (03/20/17 17:43), Sebastian Ott wrote: > > Since commit

Re: lockdep warning: console vs. mem hotplug

2017-03-30 Thread Petr Mladek
On Wed 2017-03-29 09:31:47, Michal Hocko wrote: > On Tue 28-03-17 18:00:16, Petr Mladek wrote: > > On Tue 2017-03-28 16:22:27, Michal Hocko wrote: > > > On Sat 25-03-17 09:04:42, Sergey Senozhatsky wrote: > > > > On (03/21/17 13:44), Sergey Senozhatsky wrote: > > > > [..] > > > > > so we probably

Re: lockdep warning: console vs. mem hotplug

2017-03-30 Thread Petr Mladek
On Wed 2017-03-29 09:31:47, Michal Hocko wrote: > On Tue 28-03-17 18:00:16, Petr Mladek wrote: > > On Tue 2017-03-28 16:22:27, Michal Hocko wrote: > > > On Sat 25-03-17 09:04:42, Sergey Senozhatsky wrote: > > > > On (03/21/17 13:44), Sergey Senozhatsky wrote: > > > > [..] > > > > > so we probably

Re: lockdep warning: console vs. mem hotplug

2017-03-29 Thread Sergey Senozhatsky
On (03/28/17 16:22), Michal Hocko wrote: [..] > > Sebastian, does this change make lockdep happy? > > > > it removes console drivers from the __offline_isolated_pages(). not the > > best solution I can think of, but the simplest one. > > > > --- > > > > mm/page_alloc.c | 2 +- > > 1 file

Re: lockdep warning: console vs. mem hotplug

2017-03-29 Thread Sergey Senozhatsky
On (03/28/17 16:22), Michal Hocko wrote: [..] > > Sebastian, does this change make lockdep happy? > > > > it removes console drivers from the __offline_isolated_pages(). not the > > best solution I can think of, but the simplest one. > > > > --- > > > > mm/page_alloc.c | 2 +- > > 1 file

Re: lockdep warning: console vs. mem hotplug

2017-03-29 Thread Michal Hocko
On Tue 28-03-17 18:00:16, Petr Mladek wrote: > On Tue 2017-03-28 16:22:27, Michal Hocko wrote: > > On Sat 25-03-17 09:04:42, Sergey Senozhatsky wrote: > > > On (03/21/17 13:44), Sergey Senozhatsky wrote: > > > [..] > > > > so we probably can > > > > > > > > > > > > 1) move pr_info() out of

Re: lockdep warning: console vs. mem hotplug

2017-03-29 Thread Michal Hocko
On Tue 28-03-17 18:00:16, Petr Mladek wrote: > On Tue 2017-03-28 16:22:27, Michal Hocko wrote: > > On Sat 25-03-17 09:04:42, Sergey Senozhatsky wrote: > > > On (03/21/17 13:44), Sergey Senozhatsky wrote: > > > [..] > > > > so we probably can > > > > > > > > > > > > 1) move pr_info() out of

Re: lockdep warning: console vs. mem hotplug

2017-03-28 Thread Petr Mladek
On Tue 2017-03-28 16:22:27, Michal Hocko wrote: > On Sat 25-03-17 09:04:42, Sergey Senozhatsky wrote: > > On (03/21/17 13:44), Sergey Senozhatsky wrote: > > [..] > > > so we probably can > > > > > > > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). > > >meh... > > > >

Re: lockdep warning: console vs. mem hotplug

2017-03-28 Thread Petr Mladek
On Tue 2017-03-28 16:22:27, Michal Hocko wrote: > On Sat 25-03-17 09:04:42, Sergey Senozhatsky wrote: > > On (03/21/17 13:44), Sergey Senozhatsky wrote: > > [..] > > > so we probably can > > > > > > > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). > > >meh... > > > >

Re: lockdep warning: console vs. mem hotplug

2017-03-28 Thread Michal Hocko
On Sat 25-03-17 09:04:42, Sergey Senozhatsky wrote: > On (03/21/17 13:44), Sergey Senozhatsky wrote: > [..] > > so we probably can > > > > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). > >meh... > > > > > > 2) switch to printk_deferred() in

Re: lockdep warning: console vs. mem hotplug

2017-03-28 Thread Michal Hocko
On Sat 25-03-17 09:04:42, Sergey Senozhatsky wrote: > On (03/21/17 13:44), Sergey Senozhatsky wrote: > [..] > > so we probably can > > > > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). > >meh... > > > > > > 2) switch to printk_deferred() in

Re: lockdep warning: console vs. mem hotplug

2017-03-25 Thread Sebastian Ott
On Sat, 25 Mar 2017, Sergey Senozhatsky wrote: > On (03/21/17 13:44), Sergey Senozhatsky wrote: > [..] > > so we probably can > > > > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). > >meh... > > > > > > 2) switch to printk_deferred() in __offline_isolated_pages().

Re: lockdep warning: console vs. mem hotplug

2017-03-25 Thread Sebastian Ott
On Sat, 25 Mar 2017, Sergey Senozhatsky wrote: > On (03/21/17 13:44), Sergey Senozhatsky wrote: > [..] > > so we probably can > > > > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). > >meh... > > > > > > 2) switch to printk_deferred() in __offline_isolated_pages().

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Sergey Senozhatsky
On (03/24/17 21:08), Steven Rostedt wrote: > > Sebastian, does this change make lockdep happy? > > > > it removes console drivers from the __offline_isolated_pages(). not the > > best solution I can think of, but the simplest one. > > > > --- > > > > mm/page_alloc.c | 2 +- > > 1 file changed,

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Sergey Senozhatsky
On (03/24/17 21:08), Steven Rostedt wrote: > > Sebastian, does this change make lockdep happy? > > > > it removes console drivers from the __offline_isolated_pages(). not the > > best solution I can think of, but the simplest one. > > > > --- > > > > mm/page_alloc.c | 2 +- > > 1 file changed,

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Steven Rostedt
On Sat, 25 Mar 2017 09:04:42 +0900 Sergey Senozhatsky wrote: > On (03/21/17 13:44), Sergey Senozhatsky wrote: > [..] > > so we probably can > > > > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). > >meh... > > > > > > 2) switch to

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Steven Rostedt
On Sat, 25 Mar 2017 09:04:42 +0900 Sergey Senozhatsky wrote: > On (03/21/17 13:44), Sergey Senozhatsky wrote: > [..] > > so we probably can > > > > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). > >meh... > > > > > > 2) switch to printk_deferred() in

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Steven Rostedt
On Sat, 25 Mar 2017 09:00:05 +0900 Sergey Senozhatsky wrote: > Hello, > > On (03/24/17 12:39), Steven Rostedt wrote: > [..] > > Is there a stack trace of where the lockdep dump happened? That is > > useful too. Otherwise we don't see where the inverse happened. >

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Steven Rostedt
On Sat, 25 Mar 2017 09:00:05 +0900 Sergey Senozhatsky wrote: > Hello, > > On (03/24/17 12:39), Steven Rostedt wrote: > [..] > > Is there a stack trace of where the lockdep dump happened? That is > > useful too. Otherwise we don't see where the inverse happened. > > Steven, isn't it the

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Sergey Senozhatsky
On (03/21/17 13:44), Sergey Senozhatsky wrote: [..] > so we probably can > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). >meh... > > > 2) switch to printk_deferred() in __offline_isolated_pages(). >meh.. there might a bunch of other printks done from under

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Sergey Senozhatsky
On (03/21/17 13:44), Sergey Senozhatsky wrote: [..] > so we probably can > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). >meh... > > > 2) switch to printk_deferred() in __offline_isolated_pages(). >meh.. there might a bunch of other printks done from under

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Sergey Senozhatsky
Hello, On (03/24/17 12:39), Steven Rostedt wrote: [..] > Is there a stack trace of where the lockdep dump happened? That is > useful too. Otherwise we don't see where the inverse happened. Steven, isn't it the inversion I describe in [1] (after the first lockdep warning)? [1]

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Sergey Senozhatsky
Hello, On (03/24/17 12:39), Steven Rostedt wrote: [..] > Is there a stack trace of where the lockdep dump happened? That is > useful too. Otherwise we don't see where the inverse happened. Steven, isn't it the inversion I describe in [1] (after the first lockdep warning)? [1]

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Sebastian Ott
On Fri, 24 Mar 2017, Steven Rostedt wrote: > Is there a stack trace of where the lockdep dump happened? That is > useful too. Otherwise we don't see where the inverse happened. Sure. Here you go. [ 132.379220] == [ 132.379220] [ INFO:

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Sebastian Ott
On Fri, 24 Mar 2017, Steven Rostedt wrote: > Is there a stack trace of where the lockdep dump happened? That is > useful too. Otherwise we don't see where the inverse happened. Sure. Here you go. [ 132.379220] == [ 132.379220] [ INFO:

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Steven Rostedt
On Mon, 20 Mar 2017 17:43:23 +0100 (CET) Sebastian Ott wrote: > Since commit f975237b7682 ("printk: use printk_safe buffers in printk") > I observe lockdep warnings on s390 when doing memory hotplug: > > [ 132.379220]

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Steven Rostedt
On Mon, 20 Mar 2017 17:43:23 +0100 (CET) Sebastian Ott wrote: > Since commit f975237b7682 ("printk: use printk_safe buffers in printk") > I observe lockdep warnings on s390 when doing memory hotplug: > > [ 132.379220] == > [ 132.379220] [

Re: lockdep warning: console vs. mem hotplug

2017-03-20 Thread Sergey Senozhatsky
[..] > 3) move add_timer() out of sclp_con_lock console in sclp_console_write(). I take it back. Won't improve anything. -ss

Re: lockdep warning: console vs. mem hotplug

2017-03-20 Thread Sergey Senozhatsky
[..] > 3) move add_timer() out of sclp_con_lock console in sclp_console_write(). I take it back. Won't improve anything. -ss

Re: lockdep warning: console vs. mem hotplug

2017-03-20 Thread Sergey Senozhatsky
Cc Michal, Linus, Peter, Thomas, Andrew, Martin // I kept only lockdep splats from the original report and cut off .configs // full version: // lkml.kernel.org/r/alpine.LFD.2.20.1703201736070.1753@schleppi Sebastian, thanks. On (03/20/17 17:43), Sebastian Ott wrote: [..] > Since commit

Re: lockdep warning: console vs. mem hotplug

2017-03-20 Thread Sergey Senozhatsky
Cc Michal, Linus, Peter, Thomas, Andrew, Martin // I kept only lockdep splats from the original report and cut off .configs // full version: // lkml.kernel.org/r/alpine.LFD.2.20.1703201736070.1753@schleppi Sebastian, thanks. On (03/20/17 17:43), Sebastian Ott wrote: [..] > Since commit

lockdep warning: console vs. mem hotplug

2017-03-20 Thread Sebastian Ott
Since commit f975237b7682 ("printk: use printk_safe buffers in printk") I observe lockdep warnings on s390 when doing memory hotplug: [ 132.379220] == [ 132.379220] [ INFO: possible circular locking dependency detected ] [ 132.379221]

lockdep warning: console vs. mem hotplug

2017-03-20 Thread Sebastian Ott
Since commit f975237b7682 ("printk: use printk_safe buffers in printk") I observe lockdep warnings on s390 when doing memory hotplug: [ 132.379220] == [ 132.379220] [ INFO: possible circular locking dependency detected ] [ 132.379221]