Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-28 Thread Nate Eldredge
On Tue, 28 Jan 2014, George Spelvin wrote: I'm trying it now. But it takes a while for me to reproduce, and even longer to be sure the problem has gone away. So anything you hear from me within a week will be bad news. Well, it's been a week, and: good news! I'd still wish for some review

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-28 Thread George Spelvin
> I'm trying it now. But it takes a while for me to reproduce, and even > longer to be sure the problem has gone away. So anything you hear from > me within a week will be bad news. Well, it's been a week, and: good news! I'd still wish for some review by someone who really understands this

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-28 Thread George Spelvin
I'm trying it now. But it takes a while for me to reproduce, and even longer to be sure the problem has gone away. So anything you hear from me within a week will be bad news. Well, it's been a week, and: good news! I'd still wish for some review by someone who really understands this code;

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-28 Thread Nate Eldredge
On Tue, 28 Jan 2014, George Spelvin wrote: I'm trying it now. But it takes a while for me to reproduce, and even longer to be sure the problem has gone away. So anything you hear from me within a week will be bad news. Well, it's been a week, and: good news! I'd still wish for some review

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-21 Thread George Spelvin
Nate Eldredge wrote: > On Sun, 19 Jan 2014, George Spelvin wrote: >>> It's credited to Suresh Siddha, whom I've cc'ed (along with others who >>> signed off). Suresh, if you're still around, could you comment on why >>> math_state_restore always leaves interrupts disabled, regardless of their >>>

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-21 Thread Jan Kara
On Mon 20-01-14 19:22:51, Nate Eldredge wrote: > On Sun, 19 Jan 2014, George Spelvin wrote: > > >>It's credited to Suresh Siddha, whom I've cc'ed (along with others who > >>signed off). Suresh, if you're still around, could you comment on why > >>math_state_restore always leaves interrupts

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-21 Thread Jan Kara
On Mon 20-01-14 19:22:51, Nate Eldredge wrote: On Sun, 19 Jan 2014, George Spelvin wrote: It's credited to Suresh Siddha, whom I've cc'ed (along with others who signed off). Suresh, if you're still around, could you comment on why math_state_restore always leaves interrupts disabled,

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-21 Thread George Spelvin
Nate Eldredge wrote: On Sun, 19 Jan 2014, George Spelvin wrote: It's credited to Suresh Siddha, whom I've cc'ed (along with others who signed off). Suresh, if you're still around, could you comment on why math_state_restore always leaves interrupts disabled, regardless of their state on

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-20 Thread Nate Eldredge
On Sun, 19 Jan 2014, George Spelvin wrote: It's credited to Suresh Siddha, whom I've cc'ed (along with others who signed off). Suresh, if you're still around, could you comment on why math_state_restore always leaves interrupts disabled, regardless of their state on entry? Is there a deep

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-20 Thread Nate Eldredge
On Sun, 19 Jan 2014, George Spelvin wrote: It's credited to Suresh Siddha, whom I've cc'ed (along with others who signed off). Suresh, if you're still around, could you comment on why math_state_restore always leaves interrupts disabled, regardless of their state on entry? Is there a deep

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-19 Thread George Spelvin
> It's credited to Suresh Siddha, whom I've cc'ed (along with others who > signed off). Suresh, if you're still around, could you comment on why > math_state_restore always leaves interrupts disabled, regardless of their > state on entry? Is there a deep reason or is it a bug? What the

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-19 Thread Nate Eldredge
[Here's my original message, since George's reply didn't quote or reference it: https://lkml.org/lkml/2014/1/18/3. Summary: math_state_restore() always leaves interrupts disabled, and I think this is a bug.] On Sun, 19 Jan 2014, George Spelvin wrote: THANK YOU! I've been having a problem

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-19 Thread George Spelvin
THANK YOU! I've been having a problem with ext4 metadata checksums, which use SSE for large blocks, and traced it to kernel_fpu_end() disabling interrupts, but had paused to debug this (I assumed well-tested) piece of kernel code before pushing it harder. (Search October-December LKML archives

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-19 Thread George Spelvin
THANK YOU! I've been having a problem with ext4 metadata checksums, which use SSE for large blocks, and traced it to kernel_fpu_end() disabling interrupts, but had paused to debug this (I assumed well-tested) piece of kernel code before pushing it harder. (Search October-December LKML archives

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-19 Thread Nate Eldredge
[Here's my original message, since George's reply didn't quote or reference it: https://lkml.org/lkml/2014/1/18/3. Summary: math_state_restore() always leaves interrupts disabled, and I think this is a bug.] On Sun, 19 Jan 2014, George Spelvin wrote: THANK YOU! I've been having a problem

Re: math_state_restore and kernel_fpu_end disable interrupts?

2014-01-19 Thread George Spelvin
It's credited to Suresh Siddha, whom I've cc'ed (along with others who signed off). Suresh, if you're still around, could you comment on why math_state_restore always leaves interrupts disabled, regardless of their state on entry? Is there a deep reason or is it a bug? What the comments

math_state_restore and kernel_fpu_end disable interrupts?

2014-01-17 Thread Nate Eldredge
In trying to track down a bug (see below), I noticed that math_state_restore() in arch/x86/kernel/traps.c appears to unconditionally disable interrupts when called. Is this intended behavior or a bug? The bug in question is triggered by dumping core on an ecryptfs file system when

math_state_restore and kernel_fpu_end disable interrupts?

2014-01-17 Thread Nate Eldredge
In trying to track down a bug (see below), I noticed that math_state_restore() in arch/x86/kernel/traps.c appears to unconditionally disable interrupts when called. Is this intended behavior or a bug? The bug in question is triggered by dumping core on an ecryptfs file system when