Re: media: i2c: add OV02A10 image sensor driver

2020-12-04 Thread Sakari Ailus
On Thu, Dec 03, 2020 at 08:30:03PM +0200, Andy Shevchenko wrote: > On Thu, Dec 3, 2020 at 8:24 PM Colin Ian King > wrote: > > On 03/12/2020 18:10, Andy Shevchenko wrote: > > > On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King > > > wrote: > > > > > >> Static analysis on linux-next with Coverity has

Re: media: i2c: add OV02A10 image sensor driver

2020-12-03 Thread Tomasz Figa
On Fri, Dec 4, 2020 at 11:47 AM Dongchun Zhu wrote: > > Hi Andy, > > On Thu, 2020-12-03 at 20:10 +0200, Andy Shevchenko wrote: > > On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King > > wrote: > > > > > Static analysis on linux-next with Coverity has detected an issue with > > > the following commit:

Re: media: i2c: add OV02A10 image sensor driver

2020-12-03 Thread Dongchun Zhu
Hi Andy, On Thu, 2020-12-03 at 20:10 +0200, Andy Shevchenko wrote: > On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King > wrote: > > > Static analysis on linux-next with Coverity has detected an issue with > > the following commit: > > If you want to fix it properly, see my comments below... > > >

Re: media: i2c: add OV02A10 image sensor driver

2020-12-03 Thread Andy Shevchenko
On Thu, Dec 3, 2020 at 8:24 PM Colin Ian King wrote: > On 03/12/2020 18:10, Andy Shevchenko wrote: > > On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King > > wrote: > > > >> Static analysis on linux-next with Coverity has detected an issue with > >> the following commit: > > > > If you want to fix it

Re: media: i2c: add OV02A10 image sensor driver

2020-12-03 Thread Colin Ian King
On 03/12/2020 18:10, Andy Shevchenko wrote: > On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King > wrote: > >> Static analysis on linux-next with Coverity has detected an issue with >> the following commit: > > If you want to fix it properly, see my comments below... > >> 529 static int ov02a10_s_s

Re: media: i2c: add OV02A10 image sensor driver

2020-12-03 Thread Andy Shevchenko
On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King wrote: > Static analysis on linux-next with Coverity has detected an issue with > the following commit: If you want to fix it properly, see my comments below... > 529 static int ov02a10_s_stream(struct v4l2_subdev *sd, int on) > 530 { > 531s

re: media: i2c: add OV02A10 image sensor driver

2020-12-03 Thread Colin Ian King
Hi, Static analysis on linux-next with Coverity has detected an issue with the following commit: 529 static int ov02a10_s_stream(struct v4l2_subdev *sd, int on) 530 { 531struct ov02a10 *ov02a10 = to_ov02a10(sd); 532struct i2c_client *client = v4l2_get_subdevdata(&ov02a10->subdev);